Repository navigation
Commit 2219f29
perf(mobile): project favicons mount their image in one commit
Problem: every ProjectFaviconImage with a URL committed twice on mount and
on each request change. The first render had activeFaviconRequest === null,
so it drew only the fallback; the layout effect then called setState to
mount the Image in a synchronous second render. The gate guarded nothing:
markProjectFaviconLoaded/Failed only run from expo-image's native
onLoad/onError, which arrive after the same commit's layout effect has
registered the request.
Fix: drop the activeFaviconRequest state and render the Image whenever a
request exists. The layout effect stays, now only registering the request
with the module loader and returning its end function (external
registration, no setState).
Effects: ProjectFavicon.tsx 1 -> 1 (layout effect kept, its setState and
set-state-in-effect suppression removed).
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent dc84b09 commit 2219f29
3 files changed
Lines changed: 54 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
166 | | - | |
| 166 | + | |
| 167 | + | |
167 | 168 | | |
168 | 169 | | |
169 | | - | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
| 170 | + | |
174 | 171 | | |
175 | 172 | | |
176 | 173 | | |
| |||
179 | 176 | | |
180 | 177 | | |
181 | 178 | | |
182 | | - | |
183 | | - | |
| 179 | + | |
184 | 180 | | |
185 | 181 | | |
186 | 182 | | |
| |||
203 | 199 | | |
204 | 200 | | |
205 | 201 | | |
206 | | - | |
| 202 | + | |
207 | 203 | | |
208 | 204 | | |
209 | 205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
0 commit comments