Clean up temp files after atomic settings writes

juliusmarminge · juliusmarminge · commit 21838dc9ef98 · 2026-03-25T23:48:15.000-07:00
- Remove leftover temp files after renaming keybindings and server settings
- Keep atomic write flow while avoiding stale temporary artifacts
diff --git a/apps/server/src/keybindings.ts b/apps/server/src/keybindings.ts
@@ -674,6 +674,7 @@ const makeKeybindings = Effect.gen(function* () {
       Effect.tap(() => fs.makeDirectory(path.dirname(keybindingsConfigPath), { recursive: true })),
       Effect.tap((encoded) => fs.writeFileString(tempPath, encoded)),
       Effect.flatMap(() => fs.rename(tempPath, keybindingsConfigPath)),
+      Effect.ensuring(fs.remove(tempPath, { force: true }).pipe(Effect.ignore({ log: true }))),
       Effect.mapError(
         (cause) =>
           new KeybindingsConfigError({
diff --git a/apps/server/src/serverSettings.ts b/apps/server/src/serverSettings.ts
@@ -226,6 +226,7 @@ const makeServerSettings = Effect.gen(function* () {
       Effect.tap(() => fs.makeDirectory(pathService.dirname(settingsPath), { recursive: true })),
       Effect.tap((encoded) => fs.writeFileString(tempPath, encoded)),
       Effect.flatMap(() => fs.rename(tempPath, settingsPath)),
+      Effect.ensuring(fs.remove(tempPath, { force: true }).pipe(Effect.ignore({ log: true }))),
       Effect.mapError(
         (cause) =>
           new ServerSettingsError({
