@@ -186,6 +186,7 @@ const {
186186 fromId,
187187 getFocusedWebContents,
188188 mkdir,
189+ previewSession,
189190 showItemInFolder,
190191 webviewSend,
191192 writeFile,
@@ -200,6 +201,7 @@ const {
200201 fromId : vi . fn < ( _id ?: number ) => Electron . WebContents | null > ( ( _id ?: number ) => null ) ,
201202 getFocusedWebContents : vi . fn ( ( ) => null ) ,
202203 mkdir : vi . fn ( ( _path : string ) => undefined ) ,
204+ previewSession : { on : vi . fn ( ) } ,
203205 showItemInFolder : vi . fn ( ) ,
204206 webviewSend : vi . fn ( ) ,
205207 writeFile : vi . fn ( ( _path : string , _data : Uint8Array ) => undefined ) ,
@@ -236,7 +238,7 @@ const browserSessionLayer = Layer.succeed(
236238 BrowserSession . BrowserSession . of ( {
237239 getPartition : ( ) => Effect . succeed ( "persist:t3code-preview-test" ) ,
238240 isPartition : ( partition ) => partition . startsWith ( "persist:t3code-preview-" ) ,
239- getSession : ( ) => Effect . die ( "unexpected getSession" ) ,
241+ getSession : ( ) => Effect . succeed ( previewSession as unknown as Electron . Session ) ,
240242 clearCookies : ( ) => Effect . void ,
241243 clearCache : ( ) => Effect . void ,
242244 } ) ,
@@ -547,6 +549,7 @@ describe("PreviewManager", () => {
547549 getFocusedWebContents . mockReset ( ) ;
548550 getFocusedWebContents . mockReturnValue ( null ) ;
549551 mkdir . mockClear ( ) ;
552+ previewSession . on . mockClear ( ) ;
550553 writeFile . mockClear ( ) ;
551554 showItemInFolder . mockClear ( ) ;
552555 clipboardItemConstructor . mockClear ( ) ;
@@ -4536,6 +4539,121 @@ describe("PreviewManager", () => {
45364539 } ) ,
45374540 ) ,
45384541 ) ;
4542+ effectIt . effect ( "saves downloads from agent-driven pages without a Save dialog" , ( ) =>
4543+ withManager ( ( manager ) =>
4544+ Effect . gen ( function * ( ) {
4545+ let humanInput : ( ( event : unknown , signal ?: unknown ) => void ) | undefined ;
4546+ const wc = makeTestPreviewWebContents ( vi . fn ( ) ) ;
4547+ Object . assign ( wc , {
4548+ isDevToolsOpened : ( ) => false ,
4549+ loadURL : vi . fn ( async ( ) => undefined ) ,
4550+ reload : vi . fn ( ) ,
4551+ } ) ;
4552+ Object . assign ( wc . ipc , {
4553+ on : vi . fn ( ( channel : string , listener : typeof humanInput ) => {
4554+ if ( channel === "preview:human-input" ) humanInput = listener ;
4555+ } ) ,
4556+ } ) ;
4557+ let holdEvaluate = false ;
4558+ let releaseEvaluate : ( ( ) => void ) | undefined ;
4559+ Object . assign ( wc . debugger , {
4560+ sendCommand : vi . fn ( async ( method : string , params ?: { expression ?: string } ) => {
4561+ if ( method !== "Runtime.evaluate" ) return undefined ;
4562+ if ( params ?. expression ?. includes ( "matched" ) )
4563+ return { result : { value : { matched : true } } } ;
4564+ if ( holdEvaluate ) {
4565+ holdEvaluate = false ;
4566+ await new Promise < void > ( ( resolve ) => {
4567+ releaseEvaluate = resolve ;
4568+ } ) ;
4569+ }
4570+ return { result : { value : 42 } } ;
4571+ } ) ,
4572+ } ) ;
4573+ fromId . mockReturnValue ( wc ) ;
4574+ const takeovers = [ yield * Deferred . make < void > ( ) , yield * Deferred . make < void > ( ) ] ;
4575+ let takeoverCount = 0 ;
4576+ let controller = "none" ;
4577+ yield * manager . subscribeStateChanges ( ( _tabId , state ) => {
4578+ const takeover =
4579+ controller !== "human" && state . controller === "human"
4580+ ? takeovers [ takeoverCount ++ ]
4581+ : undefined ;
4582+ controller = state . controller ;
4583+ return takeover ? Deferred . succeed ( takeover , undefined ) . pipe ( Effect . asVoid ) : Effect . void ;
4584+ } ) ;
4585+ yield * manager . getBrowserSession ( ) ;
4586+ yield * manager . getBrowserSession ( ) ;
4587+ const installs = previewSession . on . mock . calls . filter (
4588+ ( [ event ] ) => event === "will-download" ,
4589+ ) ;
4590+ expect ( installs ) . toHaveLength ( 1 ) ;
4591+ const willDownload = installs [ 0 ] ! [ 1 ] as (
4592+ event : unknown ,
4593+ item : {
4594+ getFilename : ( ) => string ;
4595+ getStartTime : ( ) => number ;
4596+ setSavePath : ( path : string ) => void ;
4597+ } ,
4598+ source : Electron . WebContents ,
4599+ ) => void ;
4600+ const download = ( ) => {
4601+ const setSavePath = vi . fn ( ) ;
4602+ willDownload (
4603+ { } ,
4604+ { getFilename : ( ) => "chart.png" , getStartTime : ( ) => 1_790_844_530.5 , setSavePath } ,
4605+ wc ,
4606+ ) ;
4607+ return setSavePath ;
4608+ } ;
4609+ yield * manager . createTab ( "tab_1" ) ;
4610+ yield * manager . registerWebview ( "tab_1" , 42 ) ;
4611+
4612+ expect ( download ( ) ) . not . toHaveBeenCalled ( ) ;
4613+
4614+ yield * manager . automationEvaluate ( "tab_1" , { expression : "42" } ) ;
4615+ const startedAt = ( 1_790_844_530_500 ) . toString ( 36 ) ;
4616+ expect ( download ( ) ) . toHaveBeenCalledWith (
4617+ `/tmp/t3/dev/browser-artifacts/browser-download-${ startedAt } -0-chart.png` ,
4618+ ) ;
4619+ // Same name, same millisecond: still a separate file.
4620+ expect ( download ( ) ) . toHaveBeenCalledWith (
4621+ `/tmp/t3/dev/browser-artifacts/browser-download-${ startedAt } -1-chart.png` ,
4622+ ) ;
4623+
4624+ humanInput ?.( { } , { kind : "pointer" , x : 10 , y : 10 , button : 0 } ) ;
4625+ yield * Deferred . await ( takeovers [ 0 ] ! ) ;
4626+ expect ( download ( ) ) . not . toHaveBeenCalled ( ) ;
4627+
4628+ // An action still waiting for the page when the human takes over must
4629+ // not mark it as agent-driven again.
4630+ holdEvaluate = true ;
4631+ const running = yield * manager
4632+ . automationEvaluate ( "tab_1" , { expression : "42" } )
4633+ . pipe ( Effect . forkChild ( { startImmediately : true } ) ) ;
4634+ yield * settle ( ( ) => releaseEvaluate !== undefined ) ;
4635+ const queued = yield * manager
4636+ . automationEvaluate ( "tab_1" , { expression : "42" } )
4637+ . pipe ( Effect . forkChild ( { startImmediately : true } ) ) ;
4638+ humanInput ?.( { } , { kind : "pointer" , x : 20 , y : 20 , button : 0 } ) ;
4639+ yield * Deferred . await ( takeovers [ 1 ] ! ) ;
4640+ releaseEvaluate ?.( ) ;
4641+ yield * Fiber . await ( running ) ;
4642+ expect ( Exit . isFailure ( yield * Fiber . await ( queued ) ) ) . toBe ( true ) ;
4643+ expect ( download ( ) ) . not . toHaveBeenCalled ( ) ;
4644+
4645+ // URL-bar navigation hands the page back to the human.
4646+ yield * manager . automationEvaluate ( "tab_1" , { expression : "42" } ) ;
4647+ expect ( download ( ) ) . toHaveBeenCalled ( ) ;
4648+ yield * manager . navigate ( "tab_1" , "https://example.com/report.csv" ) ;
4649+ expect ( download ( ) ) . not . toHaveBeenCalled ( ) ;
4650+
4651+ // Reading the page does not make it agent-driven.
4652+ yield * manager . automationWaitFor ( "tab_1" , { text : "Example" } ) ;
4653+ expect ( download ( ) ) . not . toHaveBeenCalled ( ) ;
4654+ } ) ,
4655+ ) ,
4656+ ) ;
45394657} ) ;
45404658
45414659describe ( "PreviewOperationError" , ( ) => {
0 commit comments