You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 20fddd2
Browse filesBrowse the repository at this point in the historyBrowse files
fix(effect-acp): a dying extension or notification handler no longer stops the reader
disableFatalDefects only covers core methods, which go through
RpcServer. Extension requests and notifications are handled in the
protocol layer, where Effect.ignore and matchEffect let a defect
through and end the stdin reader: that request and every later one on
the connection went unanswered, and termination never fired.
A dying extension handler now answers its own request with an internal
error, and notification handlers are guarded on their whole cause.
The ACP tests now assert the defect itself, and the client test checks
that a later request is still answered after each kind of handler dies.
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
0 commit comments