Skip to content

Commit 204559d

Browse files
committed
fix(web): swap approval action for checks summary
1 parent e653f1b commit 204559d

1 file changed

Lines changed: 19 additions & 18 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx‎

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2120,22 +2120,7 @@ export function PullRequestDetailPanel({
21202120
))}
21212121
</ToggleGroup>
21222122
{tab === "summary" ? (
2123-
<span className="ml-auto inline-flex shrink-0 items-center gap-2">
2124-
<span
2125-
className="inline-flex items-center gap-1.5 text-xs text-muted-foreground"
2126-
aria-label={checksSummary ? `Checks: ${checksSummary}` : "Checks"}
2127-
>
2128-
{checksState !== null ? (
2129-
<PullRequestChecksPopover
2130-
checks={detail.checks}
2131-
checksState={checksState}
2132-
threadRef={threadRef}
2133-
/>
2134-
) : (
2135-
<CircleDotIcon aria-hidden className="size-3.5" />
2136-
)}
2137-
{checksSummary}
2138-
</span>
2123+
<span className="ml-auto inline-flex shrink-0 items-center">
21392124
{workflowApprovalsRequired > 0 && can("approve-workflows") ? (
21402125
<Tooltip>
21412126
<TooltipTrigger
@@ -2155,7 +2140,7 @@ export function PullRequestDetailPanel({
21552140
}
21562141
>
21572142
<PlayIcon aria-hidden className="size-3.5" />
2158-
<span className="@max-[40rem]/pr-header:hidden">
2143+
<span>
21592144
{pendingAction === "approve-workflows"
21602145
? "Approving..."
21612146
: "Approve workflows to run"}
@@ -2170,7 +2155,23 @@ export function PullRequestDetailPanel({
21702155
: "Approve workflows to run"}
21712156
</TooltipPopup>
21722157
</Tooltip>
2173-
) : null}
2158+
) : (
2159+
<span
2160+
className="inline-flex items-center gap-1.5 text-xs text-muted-foreground"
2161+
aria-label={checksSummary ? `Checks: ${checksSummary}` : "Checks"}
2162+
>
2163+
{checksState !== null ? (
2164+
<PullRequestChecksPopover
2165+
checks={detail.checks}
2166+
checksState={checksState}
2167+
threadRef={threadRef}
2168+
/>
2169+
) : (
2170+
<CircleDotIcon aria-hidden className="size-3.5" />
2171+
)}
2172+
{checksSummary}
2173+
</span>
2174+
)}
21742175
</span>
21752176
) : tab === "timeline" ? (
21762177
<div className="ml-auto flex shrink-0 items-center gap-2 text-xs text-muted-foreground">

0 commit comments

Comments
 (0)