Repository navigation
Commit 2022287
committed
fix(server): review guides in a fork checkout cover only the pull request's change
In a checkout with both `origin` (a fork) and `upstream`, the project's
repository identity is read from `upstream`, but the guide fetched the base
branch from the checkout's primary remote, `origin`. When the fork's base
branch was behind upstream's, the guide was measured from that stale tip and
covered every upstream commit since, not the pull request's own change.
The guide now fetches from the remote whose URL is the one the identity was
read from, looked up among the checkout's current remotes so a cached remote
name that has since been renamed still resolves.1 parent 2577baf commit 2022287
2 files changed
Lines changed: 104 additions & 7 deletions
File tree
- apps/server/src/pullRequest
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
91 | | - | |
| 91 | + | |
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
| 151 | + | |
150 | 152 | | |
151 | 153 | | |
152 | 154 | | |
| |||
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
194 | | - | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
195 | 200 | | |
196 | 201 | | |
197 | 202 | | |
| |||
655 | 660 | | |
656 | 661 | | |
657 | 662 | | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
658 | 714 | | |
659 | 715 | | |
660 | 716 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
112 | 117 | | |
113 | 118 | | |
114 | 119 | | |
115 | 120 | | |
116 | 121 | | |
117 | 122 | | |
| 123 | + | |
118 | 124 | | |
119 | 125 | | |
120 | 126 | | |
| |||
148 | 154 | | |
149 | 155 | | |
150 | 156 | | |
| 157 | + | |
151 | 158 | | |
152 | 159 | | |
153 | 160 | | |
154 | 161 | | |
155 | 162 | | |
156 | | - | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
157 | 196 | | |
158 | 197 | | |
159 | 198 | | |
160 | 199 | | |
161 | | - | |
| 200 | + | |
162 | 201 | | |
163 | 202 | | |
164 | 203 | | |
| |||
327 | 366 | | |
328 | 367 | | |
329 | 368 | | |
| 369 | + | |
330 | 370 | | |
331 | 371 | | |
332 | 372 | | |
| |||
349 | 389 | | |
350 | 390 | | |
351 | 391 | | |
| 392 | + | |
352 | 393 | | |
353 | 394 | | |
354 | 395 | | |
| |||
412 | 453 | | |
413 | 454 | | |
414 | 455 | | |
415 | | - | |
| 456 | + | |
416 | 457 | | |
417 | 458 | | |
418 | 459 | | |
| |||
465 | 506 | | |
466 | 507 | | |
467 | 508 | | |
468 | | - | |
| 509 | + | |
469 | 510 | | |
470 | 511 | | |
471 | 512 | | |
| |||
0 commit comments