Repository navigation
Commit 1ff1ebf
refactor(web): pull request views record answers and refresh by revision
Pull request pages and panels record shared summaries, snapshots and
guide watches from query answers, refetch when a host revision changes,
and keep files-viewed writes in a scope-keyed store instead of chaining
effects on tokens and counters.
Effect categories removed:
- shared summary, list, detail snapshot and running-guide mirrors moved
into query answer handlers
- window and document key listeners moved to dispatcher scopes (detail,
page, guide tour, list search, close-sweep Escape)
- sentinels, overflow, condense and stats visibility observers moved to
ref callbacks
- values reported back to parents derived in render (selected commit,
stats batches, tab fallback)
- refresh-token and revalidation-counter effects replaced by reads keyed
on the pull request's host revision
- per-watch guide run components replaced by an app-lifetime poller
- files-viewed mirror and scope-leave effects moved into a scoped store
- code tab file reveals became requests that pend until the file loads
Bugs fixed:
- A review guide seen as Running reported the previous run's failure as
a toast or desktop notification.
- A selected commit missing from a still-loading list was reset to "all
commits" permanently.
- Comment overflow was measured after paint, so the fade and button
popped in.
- A guide open request with review guides disabled looped between tabs.
- A files-viewed answer for a scope that was left and re-entered was
applied to the new visit.
Kept effects:
- Linked-selection panel open: the URL changes through reload and
back/forward and resolves against late project data.
- Guide tab maximize on show: needs the page's maximized state in a store.
- Close-sweep sensor cancel.
Temporary compat shims (removed in a later layer of this stack):
- components/pullRequest/guide/PullRequestGuideRunCoordinator.tsx: final startGuideRunNotifications plus a compat PullRequestGuideRunCoordinator component that the base __root mounts until appInit starts it in the web-chat-view layer; guideRunStore's final shape removes the state the base coordinator used (removed in layer 10)
- hooks/useSettings.ts: starts model-preference migration at module load until appInit starts it in the app-bootstrap layer (the final module drops useMigrateModelPreferences) (removed in layer 10)
- components/diffs/useCodeViewFileReveal.ts: final hook plus a retry effect for the base DiffPanel's (viewer, scope, readyFileKeys) call, so DiffPanel's reveal still waits for the file to render until DiffPanel lands in the web-files layer; the PR code tab needs the final hook (removed in layer 07)
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 9648c2d commit 1ff1ebf
34 files changed
Lines changed: 2436 additions & 1217 deletions
File tree
- apps/web/src
- components
- diffs
- pullRequest
- guide
- settings
- hooks
- state
- packages/client-runtime/src/state
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | 45 | | |
48 | 46 | | |
49 | 47 | | |
| |||
53 | 51 | | |
54 | 52 | | |
55 | 53 | | |
| 54 | + | |
56 | 55 | | |
57 | 56 | | |
58 | 57 | | |
| |||
204 | 203 | | |
205 | 204 | | |
206 | 205 | | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
207 | 213 | | |
208 | 214 | | |
209 | 215 | | |
| |||
379 | 385 | | |
380 | 386 | | |
381 | 387 | | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | | - | |
396 | | - | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
397 | 409 | | |
398 | 410 | | |
399 | 411 | | |
| |||
445 | 457 | | |
446 | 458 | | |
447 | 459 | | |
448 | | - | |
| 460 | + | |
449 | 461 | | |
450 | 462 | | |
451 | 463 | | |
| |||
734 | 746 | | |
735 | 747 | | |
736 | 748 | | |
737 | | - | |
| 749 | + | |
738 | 750 | | |
739 | 751 | | |
740 | 752 | | |
| |||
926 | 938 | | |
927 | 939 | | |
928 | 940 | | |
929 | | - | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
930 | 945 | | |
931 | 946 | | |
932 | 947 | | |
| |||
958 | 973 | | |
959 | 974 | | |
960 | 975 | | |
961 | | - | |
962 | | - | |
963 | | - | |
964 | | - | |
965 | | - | |
966 | | - | |
967 | | - | |
968 | | - | |
969 | | - | |
970 | | - | |
971 | | - | |
972 | | - | |
973 | | - | |
974 | | - | |
975 | | - | |
976 | | - | |
977 | | - | |
978 | | - | |
979 | | - | |
980 | | - | |
981 | | - | |
982 | | - | |
983 | | - | |
984 | | - | |
985 | | - | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
| 997 | + | |
| 998 | + | |
| 999 | + | |
| 1000 | + | |
| 1001 | + | |
| 1002 | + | |
986 | 1003 | | |
| 1004 | + | |
987 | 1005 | | |
988 | 1006 | | |
989 | 1007 | | |
| |||
999 | 1017 | | |
1000 | 1018 | | |
1001 | 1019 | | |
| 1020 | + | |
1002 | 1021 | | |
1003 | 1022 | | |
1004 | 1023 | | |
| |||
1182 | 1201 | | |
1183 | 1202 | | |
1184 | 1203 | | |
1185 | | - | |
1186 | | - | |
1187 | | - | |
1188 | | - | |
1189 | | - | |
1190 | | - | |
1191 | | - | |
1192 | | - | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
1193 | 1207 | | |
1194 | 1208 | | |
1195 | | - | |
1196 | | - | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
1201 | | - | |
1202 | | - | |
1203 | | - | |
1204 | | - | |
1205 | | - | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
1206 | 1215 | | |
1207 | | - | |
1208 | | - | |
1209 | | - | |
1210 | | - | |
1211 | | - | |
1212 | | - | |
1213 | 1216 | | |
1214 | 1217 | | |
1215 | 1218 | | |
| |||
1221 | 1224 | | |
1222 | 1225 | | |
1223 | 1226 | | |
1224 | | - | |
| 1227 | + | |
1225 | 1228 | | |
1226 | 1229 | | |
| 1230 | + | |
| 1231 | + | |
| 1232 | + | |
1227 | 1233 | | |
1228 | | - | |
1229 | | - | |
| 1234 | + | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
| 1240 | + | |
| 1241 | + | |
| 1242 | + | |
1230 | 1243 | | |
1231 | 1244 | | |
1232 | 1245 | | |
| |||
1238 | 1251 | | |
1239 | 1252 | | |
1240 | 1253 | | |
| 1254 | + | |
1241 | 1255 | | |
1242 | 1256 | | |
1243 | 1257 | | |
| |||
1249 | 1263 | | |
1250 | 1264 | | |
1251 | 1265 | | |
1252 | | - | |
| 1266 | + | |
1253 | 1267 | | |
1254 | 1268 | | |
1255 | 1269 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
97 | 96 | | |
98 | | - | |
| 97 | + | |
| 98 | + | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
| 103 | + | |
109 | 104 | | |
110 | 105 | | |
111 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
0 commit comments