Skip to content

Commit 1f6df6b

Browse files
feat(pull-requests): guided reviews, a beta tour of a pull request (#18124)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 8d199b4 commit 1f6df6b

74 files changed

Lines changed: 4913 additions & 134 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎apps/server/src/auth/RpcAuthorization.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ export const RPC_REQUIRED_SCOPES = {
132132
[WS_METHODS.pullRequestsPreview]: AuthOrchestrationReadScope,
133133
[WS_METHODS.pullRequestsChecks]: AuthOrchestrationReadScope,
134134
[WS_METHODS.pullRequestsActivity]: AuthOrchestrationReadScope,
135+
[WS_METHODS.pullRequestsReviewGuide]: AuthOrchestrationReadScope,
135136
[WS_METHODS.pullRequestsThreadComments]: AuthOrchestrationReadScope,
136137
[WS_METHODS.pullRequestsDiffFileContents]: AuthOrchestrationReadScope,
137138
[WS_METHODS.pullRequestsFilesViewed]: AuthOrchestrationReadScope,

‎apps/server/src/git/GitManager.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ function createTextGeneration(
347347
Effect.succeed({
348348
title: "Update workflow",
349349
}),
350+
generateReviewGuide: () => Effect.succeed({ stops: [] }),
350351
...overrides,
351352
};
352353

@@ -395,6 +396,7 @@ function createTextGeneration(
395396
}),
396397
),
397398
),
399+
generateReviewGuide: (input) => implementation.generateReviewGuide(input),
398400
};
399401
}
400402

‎apps/server/src/observability/RpcInstrumentation.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,8 @@ const RPC_AGGREGATES = {
107107
[WS_METHODS.pullRequestsPreview]: "pull-requests",
108108
[WS_METHODS.pullRequestsChecks]: "pull-requests",
109109
[WS_METHODS.pullRequestsActivity]: "pull-requests",
110+
[WS_METHODS.pullRequestsReviewGuide]: "pull-requests",
111+
[WS_METHODS.pullRequestsGenerateReviewGuide]: "pull-requests",
110112
[WS_METHODS.pullRequestsThreadComments]: "pull-requests",
111113
[WS_METHODS.pullRequestsDiffFileContents]: "pull-requests",
112114
[WS_METHODS.pullRequestsFilesViewed]: "pull-requests",

‎apps/server/src/persistence/Errors.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,5 +129,6 @@ export type ProviderSessionRuntimeRepositoryError = PersistenceSqlError | Persis
129129
export type AuthPairingLinkRepositoryError = PersistenceSqlError | PersistenceDecodeError;
130130
export type AuthSessionRepositoryError = PersistenceSqlError | PersistenceDecodeError;
131131
export type PullRequestFilesViewedRepositoryError = PersistenceSqlError | PersistenceDecodeError;
132+
export type PullRequestReviewGuideRepositoryError = PersistenceSqlError | PersistenceDecodeError;
132133

133134
export type ProjectionRepositoryError = PersistenceSqlError | PersistenceDecodeError;

‎apps/server/src/persistence/Migrations.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ import Migration0057 from "./Migrations/057_ScheduledTaskWebhooks.ts";
7474
import Migration0058 from "./Migrations/058_WebhookRelayDeliveries.ts";
7575
import Migration0059 from "./Migrations/059_McpAppModelContext.ts";
7676
import Migration0060 from "./Migrations/060_ThreadSnapshotWindowIndexes.ts";
77+
import Migration0061 from "./Migrations/061_PullRequestReviewGuides.ts";
7778

7879
/**
7980
* Migration loader with all migrations defined inline.
@@ -148,6 +149,7 @@ export const migrationEntries = [
148149
[58, "WebhookRelayDeliveries", Migration0058],
149150
[59, "McpAppModelContext", Migration0059],
150151
[60, "ThreadSnapshotWindowIndexes", Migration0060],
152+
[61, "PullRequestReviewGuides", Migration0061],
151153
] as const;
152154

153155
export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);

‎apps/server/src/persistence/Migrations/055_OrchestrationV2.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ layer("055_OrchestrationV2", (it) => {
1313
Effect.sync(() => {
1414
assert.deepStrictEqual(
1515
migrationEntries.map(([id]) => id),
16-
Array.from({ length: 60 }, (_, index) => index + 1),
16+
Array.from({ length: 61 }, (_, index) => index + 1),
1717
);
1818
}),
1919
);
@@ -32,6 +32,7 @@ layer("055_OrchestrationV2", (it) => {
3232
[58, "WebhookRelayDeliveries"],
3333
[59, "McpAppModelContext"],
3434
[60, "ThreadSnapshotWindowIndexes"],
35+
[61, "PullRequestReviewGuides"],
3536
]);
3637
assert.deepStrictEqual(yield* runMigrations(), []);
3738

@@ -58,6 +59,7 @@ layer("055_OrchestrationV2", (it) => {
5859
{ migration_id: 58, name: "WebhookRelayDeliveries" },
5960
{ migration_id: 59, name: "McpAppModelContext" },
6061
{ migration_id: 60, name: "ThreadSnapshotWindowIndexes" },
62+
{ migration_id: 61, name: "PullRequestReviewGuides" },
6163
]);
6264

6365
const tables = yield* sql<{ readonly name: string }>`
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import * as Effect from "effect/Effect";
2+
import * as SqlClient from "effect/sql/SqlClient";
3+
4+
export default Effect.gen(function* () {
5+
const sql = yield* SqlClient.SqlClient;
6+
7+
// The latest guide per pull request, keyed by its host-level identity so every project that
8+
// checks out the same repository shares one. Guides cost a model run, so a push leaves the old
9+
// one in place for the page to call stale rather than deleting it.
10+
yield* sql`
11+
CREATE TABLE IF NOT EXISTS pull_request_review_guides (
12+
host TEXT NOT NULL,
13+
repository TEXT NOT NULL,
14+
number INTEGER NOT NULL,
15+
guide_json TEXT NOT NULL,
16+
PRIMARY KEY (host, repository, number)
17+
) WITHOUT ROWID
18+
`;
19+
});
Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
import * as Context from "effect/Context";
2+
import * as Effect from "effect/Effect";
3+
import * as Layer from "effect/Layer";
4+
import * as Option from "effect/Option";
5+
import * as Schema from "effect/Schema";
6+
import * as SqlClient from "effect/sql/SqlClient";
7+
import * as SqlSchema from "effect/sql/SqlSchema";
8+
9+
import { PullRequestReviewGuide, ThreadPullRequestKey } from "@t3tools/contracts";
10+
11+
import {
12+
PersistenceDecodeError,
13+
PersistenceSqlError,
14+
type PullRequestReviewGuideRepositoryError,
15+
} from "./Errors.ts";
16+
17+
const GuideRow = Schema.Struct({
18+
guide: Schema.fromJsonString(PullRequestReviewGuide),
19+
});
20+
21+
/** The latest review guide per pull request, keyed by host-level identity. */
22+
export class PullRequestReviewGuideRepository extends Context.Service<
23+
PullRequestReviewGuideRepository,
24+
{
25+
readonly get: (
26+
key: ThreadPullRequestKey,
27+
) => Effect.Effect<
28+
Option.Option<PullRequestReviewGuide>,
29+
PullRequestReviewGuideRepositoryError
30+
>;
31+
readonly put: (
32+
key: ThreadPullRequestKey,
33+
guide: PullRequestReviewGuide,
34+
) => Effect.Effect<void, PullRequestReviewGuideRepositoryError>;
35+
}
36+
>()("t3/persistence/PullRequestReviewGuides/PullRequestReviewGuideRepository") {}
37+
38+
const make = Effect.gen(function* () {
39+
const sql = yield* SqlClient.SqlClient;
40+
41+
const findGuide = SqlSchema.findOneOption({
42+
Request: ThreadPullRequestKey,
43+
Result: GuideRow,
44+
execute: ({ host, repository, number }) =>
45+
sql`
46+
SELECT guide_json AS "guide"
47+
FROM pull_request_review_guides
48+
WHERE host = ${host} AND repository = ${repository} AND number = ${number}
49+
`,
50+
});
51+
const encodeGuide = Schema.encodeEffect(Schema.fromJsonString(PullRequestReviewGuide));
52+
53+
return PullRequestReviewGuideRepository.of({
54+
get: (key) =>
55+
findGuide(key).pipe(
56+
Effect.map(Option.map((row) => row.guide)),
57+
Effect.mapError((cause) =>
58+
Schema.isSchemaError(cause)
59+
? PersistenceDecodeError.fromSchemaError("PullRequestReviewGuide", cause)
60+
: new PersistenceSqlError({ operation: "getPullRequestReviewGuide", cause }),
61+
),
62+
),
63+
put: (key, guide) =>
64+
encodeGuide(guide).pipe(
65+
Effect.mapError((cause) =>
66+
PersistenceDecodeError.fromSchemaError("PullRequestReviewGuide", cause),
67+
),
68+
Effect.flatMap((guideJson) =>
69+
sql`
70+
INSERT INTO pull_request_review_guides (host, repository, number, guide_json)
71+
VALUES (${key.host}, ${key.repository}, ${key.number}, ${guideJson})
72+
ON CONFLICT (host, repository, number) DO UPDATE SET guide_json = excluded.guide_json
73+
`.pipe(
74+
Effect.mapError(
75+
(cause) => new PersistenceSqlError({ operation: "putPullRequestReviewGuide", cause }),
76+
),
77+
),
78+
),
79+
Effect.asVoid,
80+
),
81+
});
82+
});
83+
84+
export const layer = Layer.effect(PullRequestReviewGuideRepository, make);

‎apps/server/src/persistence/reconcileV2PreviewMigration.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ describe("V2 preview upgrade", () => {
4141
[58, "WebhookRelayDeliveries"],
4242
[59, "McpAppModelContext"],
4343
[60, "ThreadSnapshotWindowIndexes"],
44+
[61, "PullRequestReviewGuides"],
4445
]);
4546
assert.deepStrictEqual(yield* runMigrations(), []);
4647
assert.deepStrictEqual(yield* sql`SELECT * FROM orchestration_v2_legacy_imports`, imports);
@@ -124,6 +125,7 @@ describe("V2 preview upgrade", () => {
124125
[58, "WebhookRelayDeliveries"],
125126
[59, "McpAppModelContext"],
126127
[60, "ThreadSnapshotWindowIndexes"],
128+
[61, "PullRequestReviewGuides"],
127129
]);
128130
}).pipe(Effect.provide(NodeSqliteClient.layer({ filename: ":memory:" }))),
129131
);

‎apps/server/src/provider/Drivers/CodexManagedProvider.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,8 @@ export const makeManagedCodexProvider = Effect.fn("makeManagedCodexProvider")(fu
260260
protect("generateBranchName", nativeGeneration.generateBranchName(value)),
261261
generateThreadTitle: (value) =>
262262
protect("generateThreadTitle", nativeGeneration.generateThreadTitle(value)),
263+
generateReviewGuide: (value) =>
264+
protect("generateReviewGuide", nativeGeneration.generateReviewGuide(value)),
263265
};
264266
return {
265267
instanceId,

0 commit comments

Comments
 (0)