@@ -18,7 +18,7 @@ const rowNode = (path: string) => ({
1818
1919describe ( "createFileTreeDragMentionController" , ( ) => {
2020 it ( "tags a row drag with the mention payload and flags the drag" , ( ) => {
21- const controller = createFileTreeDragMentionController ( { deselect : ( ) => { } } ) ;
21+ const controller = createFileTreeDragMentionController ( { } ) ;
2222 const transfer = makeTransfer ( ) ;
2323 controller . handleDragStart ( {
2424 dataTransfer : transfer ,
@@ -29,7 +29,7 @@ describe("createFileTreeDragMentionController", () => {
2929 } ) ;
3030
3131 it ( "strips the trailing slash from directory rows" , ( ) => {
32- const controller = createFileTreeDragMentionController ( { deselect : ( ) => { } } ) ;
32+ const controller = createFileTreeDragMentionController ( { } ) ;
3333 const transfer = makeTransfer ( ) ;
3434 controller . handleDragStart ( {
3535 dataTransfer : transfer ,
@@ -40,7 +40,6 @@ describe("createFileTreeDragMentionController", () => {
4040
4141 it ( "mentions rows of a host folder by their host path" , ( ) => {
4242 const controller = createFileTreeDragMentionController ( {
43- deselect : ( ) => { } ,
4443 mentionPath : ( path ) => `/Users/me/scope/${ path } ` ,
4544 } ) ;
4645 const transfer = makeTransfer ( ) ;
@@ -52,15 +51,15 @@ describe("createFileTreeDragMentionController", () => {
5251 } ) ;
5352
5453 it ( "does not tag drags of selected text from the panel chrome" , ( ) => {
55- const controller = createFileTreeDragMentionController ( { deselect : ( ) => { } } ) ;
54+ const controller = createFileTreeDragMentionController ( { } ) ;
5655 const transfer = makeTransfer ( "selected text" ) ;
5756 controller . handleDragStart ( { dataTransfer : transfer , composedPath : ( ) => [ { } ] } ) ;
5857 expect ( transfer . data . has ( COMPOSER_MENTION_DRAG_TYPE ) ) . toBe ( false ) ;
5958 expect ( controller . isDragInProgress ( ) ) . toBe ( false ) ;
6059 } ) ;
6160
6261 it ( "ignores drags that carry no row path" , ( ) => {
63- const controller = createFileTreeDragMentionController ( { deselect : ( ) => { } } ) ;
62+ const controller = createFileTreeDragMentionController ( { } ) ;
6463 const transfer = makeTransfer ( ) ;
6564 controller . handleDragStart ( { dataTransfer : transfer , composedPath : ( ) => [ { } ] } ) ;
6665 expect ( transfer . data . has ( COMPOSER_MENTION_DRAG_TYPE ) ) . toBe ( false ) ;
@@ -69,24 +68,22 @@ describe("createFileTreeDragMentionController", () => {
6968
7069 it ( "deselects the dragged row exactly once when the drag ends" , ( ) => {
7170 const deselected : Array < string > = [ ] ;
72- const controller = createFileTreeDragMentionController ( {
73- deselect : ( path ) => deselected . push ( path ) ,
74- } ) ;
71+ const controller = createFileTreeDragMentionController ( { } ) ;
72+ const deselect = ( path : string ) => void deselected . push ( path ) ;
7573 controller . handleDragStart ( {
7674 dataTransfer : makeTransfer ( ) ,
7775 composedPath : ( ) => [ rowNode ( "src/app.ts" ) ] ,
7876 } ) ;
79- controller . handleDragEnd ( ) ;
80- controller . handleDragEnd ( ) ;
77+ controller . handleDragEnd ( deselect ) ;
78+ controller . handleDragEnd ( deselect ) ;
8179 expect ( deselected ) . toEqual ( [ "src/app.ts" ] ) ;
8280 expect ( controller . isDragInProgress ( ) ) . toBe ( false ) ;
8381 } ) ;
8482
8583 it ( "drags the whole selection when the dragged row is part of it" , ( ) => {
8684 const deselected : Array < string > = [ ] ;
87- const controller = createFileTreeDragMentionController ( {
88- deselect : ( path ) => deselected . push ( path ) ,
89- } ) ;
85+ const controller = createFileTreeDragMentionController ( { } ) ;
86+ const deselect = ( path : string ) => void deselected . push ( path ) ;
9087 controller . handleSelectionChange ( [ "docs/index.md" , "docs/api.md" , "src/app.ts" ] ) ;
9188 const transfer = makeTransfer ( ) ;
9289 controller . handleDragStart ( {
@@ -96,12 +93,12 @@ describe("createFileTreeDragMentionController", () => {
9693 expect ( transfer . getData ( COMPOSER_MENTION_DRAG_TYPE ) ) . toBe (
9794 "[index.md](docs/index.md) [api.md](docs/api.md) [app.ts](src/app.ts)" ,
9895 ) ;
99- controller . handleDragEnd ( ) ;
96+ controller . handleDragEnd ( deselect ) ;
10097 expect ( deselected ) . toEqual ( [ "docs/index.md" , "docs/api.md" , "src/app.ts" ] ) ;
10198 } ) ;
10299
103100 it ( "drags only the row under the cursor when it is outside the selection" , ( ) => {
104- const controller = createFileTreeDragMentionController ( { deselect : ( ) => { } } ) ;
101+ const controller = createFileTreeDragMentionController ( { } ) ;
105102 controller . handleSelectionChange ( [ "docs/index.md" ] ) ;
106103 const transfer = makeTransfer ( ) ;
107104 controller . handleDragStart ( {
@@ -113,10 +110,9 @@ describe("createFileTreeDragMentionController", () => {
113110
114111 it ( "does not deselect anything when no drag was started" , ( ) => {
115112 const deselected : Array < string > = [ ] ;
116- const controller = createFileTreeDragMentionController ( {
117- deselect : ( path ) => deselected . push ( path ) ,
118- } ) ;
119- controller . handleDragEnd ( ) ;
113+ const controller = createFileTreeDragMentionController ( { } ) ;
114+ const deselect = ( path : string ) => void deselected . push ( path ) ;
115+ controller . handleDragEnd ( deselect ) ;
120116 expect ( deselected ) . toEqual ( [ ] ) ;
121117 } ) ;
122118} ) ;
0 commit comments