Skip to content

Commit 1d2160a

Browse files
fix(web,mobile): a workflow's opening reads like the rest of the thread
The opening was a bordered card holding collapsible sections: the phase list folded its agents once they finished, and the script sat behind a "View script" toggle as unhighlighted text. Every part of it stays open now. Agents render like the timeline's subagent rows, with their answer under the label, and the script renders as a highlighted code block that folds only when long, the way a long message does, and opens for Find. The Lineage panel's phase list is back to its shape on main. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent c0c9629 commit 1d2160a

4 files changed

Lines changed: 372 additions & 184 deletions

File tree

‎apps/mobile/src/features/threads/thread-workflow-opening.tsx‎

Lines changed: 61 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,15 @@ import { useState } from "react";
1212
import { Pressable, View } from "react-native";
1313

1414
import { AppText as Text } from "../../components/ui/AppText";
15-
import { SymbolView } from "../../components/ui/AppSymbol";
1615
import { environmentThreadDetails } from "../../state/threads";
16+
import { useAppearancePreferences } from "../settings/appearance/AppearancePreferencesProvider";
17+
import { useMarkdownCodeHighlight } from "./markdownCodeHighlightState";
1718
import { SubagentRow } from "./SubagentRow";
1819
import { WorkLogBlock } from "./work-log-layout";
1920

21+
// A script longer than this many lines shows its head until opened.
22+
const FOLDED_SCRIPT_LINES = 10;
23+
2024
/** The workflow opening for a thread, or null; the parent's detail loads only for a workflow. */
2125
export function useWorkflowOpening(environmentId: EnvironmentId, threadId: ThreadId) {
2226
const threadAtom = environmentThreadDetails.threadAtom(scopeThreadRef(environmentId, threadId));
@@ -67,14 +71,13 @@ function memberRowSubagent(
6771

6872
type WorkflowOpeningValue = NonNullable<ReturnType<typeof useWorkflowOpening>>;
6973

70-
/** Replaces a workflow coordinator's script message: the plan, then the script on demand. */
74+
/** Replaces a workflow coordinator's script message: the plan, its agents, then the script. */
7175
export function ThreadWorkflowOpening(props: {
7276
readonly environmentId: EnvironmentId;
7377
readonly threadId: ThreadId;
7478
readonly opening: WorkflowOpeningValue;
7579
}) {
7680
const navigation = useNavigation();
77-
const [scriptOpen, setScriptOpen] = useState(false);
7881
const { opening } = props;
7982
const headline = workflowOpeningHeadline(opening);
8083
const canListMembers = opening.driver !== null && opening.providerInstanceId !== null;
@@ -109,7 +112,7 @@ export function ThreadWorkflowOpening(props: {
109112
};
110113
return (
111114
<WorkLogBlock>
112-
<View className="mb-5 gap-2 rounded-xl border border-border bg-card/30 p-3">
115+
<View className="mb-5 gap-3">
113116
<View className="flex-row items-start gap-2">
114117
<View className="min-w-0 flex-1 gap-0.5">
115118
<Text className="font-t3-medium text-2xs text-foreground-muted">Workflow started</Text>
@@ -137,25 +140,63 @@ export function ThreadWorkflowOpening(props: {
137140
))
138141
: null}
139142
{canListMembers ? unphased.map(renderMember) : null}
143+
<WorkflowScript script={opening.script} />
144+
</View>
145+
</WorkLogBlock>
146+
);
147+
}
148+
149+
/** The script as highlighted code; a long one shows its head until opened. */
150+
function WorkflowScript(props: { readonly script: string }) {
151+
const [expanded, setExpanded] = useState(false);
152+
const { themeAppearance } = useAppearancePreferences();
153+
const script = props.script.trimEnd();
154+
const lines = useMarkdownCodeHighlight({
155+
code: script,
156+
language: "javascript",
157+
theme: themeAppearance,
158+
enabled: true,
159+
});
160+
const lineCount = script.split("\n").length;
161+
const canFold = lineCount > FOLDED_SCRIPT_LINES;
162+
const shownLines = canFold && !expanded ? FOLDED_SCRIPT_LINES : lineCount;
163+
// Tokens are keyed by their offset into the script, like the work log's REPL code.
164+
let offset = 0;
165+
const highlighted = lines?.slice(0, shownLines).flatMap((line, lineIndex) => {
166+
const separator = lineIndex > 0 ? "\n" : "";
167+
offset += separator.length;
168+
return [
169+
separator,
170+
...line.map((token) => {
171+
const start = offset;
172+
offset += token.content.length;
173+
return (
174+
<Text key={start} style={token.color ? { color: token.color } : undefined}>
175+
{token.content}
176+
</Text>
177+
);
178+
}),
179+
];
180+
});
181+
return (
182+
<View className="gap-1">
183+
<View className="rounded-lg bg-subtle px-3 py-2.5">
184+
<Text selectable className="font-mono text-2xs leading-normal text-foreground">
185+
{highlighted ?? script.split("\n").slice(0, shownLines).join("\n")}
186+
</Text>
187+
</View>
188+
{canFold ? (
140189
<Pressable
141190
accessibilityRole="button"
142-
accessibilityState={{ expanded: scriptOpen }}
143-
onPress={() => setScriptOpen((open) => !open)}
144-
className="flex-row items-center gap-1.5 py-1 active:opacity-70"
191+
accessibilityState={{ expanded }}
192+
onPress={() => setExpanded((value) => !value)}
193+
className="self-start py-1 active:opacity-70"
145194
>
146-
<Text className="font-t3-medium text-xs text-foreground-muted">View script</Text>
147-
<SymbolView
148-
name={scriptOpen ? "chevron.up" : "chevron.down"}
149-
size={10}
150-
tintColorClassName="accent-icon-subtle"
151-
/>
152-
</Pressable>
153-
{scriptOpen ? (
154-
<Text selectable className="font-mono text-2xs text-foreground-muted">
155-
{opening.script}
195+
<Text className="font-t3-medium text-xs text-foreground-muted">
196+
{expanded ? "Show less" : "Show full script"}
156197
</Text>
157-
) : null}
158-
</View>
159-
</WorkLogBlock>
198+
</Pressable>
199+
) : null}
200+
</View>
160201
);
161202
}

‎apps/web/src/components/chat/ThreadLineageWorkflowRow.tsx‎

Lines changed: 66 additions & 95 deletions
Original file line numberDiff line numberDiff line change
@@ -108,92 +108,6 @@ function WorkflowMemberRow({
108108
);
109109
}
110110

111-
/** A workflow's phases, each listing its member agents; a member row opens its thread. */
112-
export function WorkflowPhaseList({
113-
group,
114-
providerInstanceId,
115-
provider,
116-
providers,
117-
driver,
118-
onOpenThread,
119-
isThreadAvailable,
120-
}: {
121-
readonly group: SubagentWorkflowGroup;
122-
readonly providerInstanceId: ProviderInstanceId;
123-
readonly provider: ServerProvider | undefined;
124-
readonly providers: ReadonlyArray<ServerProvider> | undefined;
125-
readonly driver: ProviderDriverKind | undefined;
126-
readonly onOpenThread: (threadId: string) => void;
127-
readonly isThreadAvailable: (threadId: string) => boolean;
128-
}) {
129-
const [phaseOpen, setPhaseOpen] = useState<ReadonlyMap<number, boolean>>(() => new Map());
130-
const phases = group.phases.filter((phase) => phase.members.length > 0);
131-
return (
132-
<ul className="m-0 list-none p-0 ps-6.5">
133-
{phases.map((phase) => {
134-
const open = phaseOpen.get(phase.index) ?? phase.state === "running";
135-
const status = phaseStatusLabel(phase);
136-
return (
137-
<li key={phase.index}>
138-
<CollapsibleSectionHeader
139-
variant="panel"
140-
tone={phase.state === "running" ? "emphasized" : "muted"}
141-
expanded={open}
142-
aria-label={`${open ? "Collapse" : "Expand"} ${phase.title} phase, ${status}`}
143-
onClick={() => setPhaseOpen((phases) => new Map(phases).set(phase.index, !open))}
144-
accessory={
145-
<>
146-
{status === "failed" ? <SectionHeaderStatus>Failed</SectionHeaderStatus> : null}
147-
<span className="shrink-0 text-2xs font-normal tabular-nums">
148-
{phase.settledCount}/{phase.members.length}{" "}
149-
{phase.members.length === 1 ? "agent" : "agents"}
150-
</span>
151-
<span className="shrink-0 text-2xs font-normal tabular-nums empty:hidden">
152-
<AgentElapsed agent={phaseElapsed(phase)} />
153-
</span>
154-
</>
155-
}
156-
>
157-
{phase.title}
158-
</CollapsibleSectionHeader>
159-
{open ? (
160-
<ul className="m-0 list-none p-0">
161-
{phase.members.map((member) => (
162-
<WorkflowMemberRow
163-
key={member.id}
164-
member={member}
165-
providerInstanceId={providerInstanceId}
166-
provider={provider}
167-
providers={providers}
168-
driver={driver}
169-
onOpen={onOpenThread}
170-
isThreadAvailable={isThreadAvailable}
171-
/>
172-
))}
173-
</ul>
174-
) : null}
175-
</li>
176-
);
177-
})}
178-
{group.unphasedMembers.map((member) => (
179-
<WorkflowMemberRow
180-
key={member.id}
181-
member={member}
182-
providerInstanceId={providerInstanceId}
183-
provider={provider}
184-
providers={providers}
185-
driver={driver}
186-
onOpen={onOpenThread}
187-
isThreadAvailable={isThreadAvailable}
188-
/>
189-
))}
190-
{phases.length === 0 && group.unphasedMembers.length === 0 ? (
191-
<li className="px-2.5 py-1.5 text-2xs text-muted-foreground/70">No agents yet</li>
192-
) : null}
193-
</ul>
194-
);
195-
}
196-
197111
export function ThreadLineageWorkflowRow({
198112
group,
199113
header,
@@ -220,7 +134,9 @@ export function ThreadLineageWorkflowRow({
220134
readonly stopDisabled: boolean;
221135
}) {
222136
const [expanded, setExpanded] = useState(false);
137+
const [phaseOpen, setPhaseOpen] = useState<ReadonlyMap<number, boolean>>(() => new Map());
223138
const label = group.workflow.workflowName ?? group.workflow.title;
139+
const phases = group.phases.filter((phase) => phase.members.length > 0);
224140
return (
225141
<li className="group" data-workflow-expanded={expanded ? "" : undefined}>
226142
<div className={cn("relative", THREAD_DETAILS_PANEL_SPLIT_GROUP_CLASS)}>
@@ -270,15 +186,70 @@ export function ThreadLineageWorkflowRow({
270186
</ThreadDetailsControl>
271187
</div>
272188
{expanded ? (
273-
<WorkflowPhaseList
274-
group={group}
275-
providerInstanceId={providerInstanceId}
276-
provider={provider}
277-
providers={providers}
278-
driver={driver}
279-
onOpenThread={onOpenThread}
280-
isThreadAvailable={isThreadAvailable}
281-
/>
189+
<ul className="m-0 list-none p-0 ps-6.5">
190+
{phases.map((phase) => {
191+
const open = phaseOpen.get(phase.index) ?? phase.state === "running";
192+
const status = phaseStatusLabel(phase);
193+
return (
194+
<li key={phase.index}>
195+
<CollapsibleSectionHeader
196+
variant="panel"
197+
tone={phase.state === "running" ? "emphasized" : "muted"}
198+
expanded={open}
199+
aria-label={`${open ? "Collapse" : "Expand"} ${phase.title} phase, ${status}`}
200+
onClick={() => setPhaseOpen((phases) => new Map(phases).set(phase.index, !open))}
201+
accessory={
202+
<>
203+
{status === "failed" ? (
204+
<SectionHeaderStatus>Failed</SectionHeaderStatus>
205+
) : null}
206+
<span className="shrink-0 text-2xs font-normal tabular-nums">
207+
{phase.settledCount}/{phase.members.length}{" "}
208+
{phase.members.length === 1 ? "agent" : "agents"}
209+
</span>
210+
<span className="shrink-0 text-2xs font-normal tabular-nums empty:hidden">
211+
<AgentElapsed agent={phaseElapsed(phase)} />
212+
</span>
213+
</>
214+
}
215+
>
216+
{phase.title}
217+
</CollapsibleSectionHeader>
218+
{open ? (
219+
<ul className="m-0 list-none p-0">
220+
{phase.members.map((member) => (
221+
<WorkflowMemberRow
222+
key={member.id}
223+
member={member}
224+
providerInstanceId={providerInstanceId}
225+
provider={provider}
226+
providers={providers}
227+
driver={driver}
228+
onOpen={onOpenThread}
229+
isThreadAvailable={isThreadAvailable}
230+
/>
231+
))}
232+
</ul>
233+
) : null}
234+
</li>
235+
);
236+
})}
237+
{group.unphasedMembers.map((member) => (
238+
<WorkflowMemberRow
239+
key={member.id}
240+
member={member}
241+
providerInstanceId={providerInstanceId}
242+
provider={provider}
243+
providers={providers}
244+
driver={driver}
245+
onOpen={onOpenThread}
246+
isThreadAvailable={isThreadAvailable}
247+
/>
248+
))}
249+
{phases.length === 0 && group.unphasedMembers.length === 0 ? (
250+
<li className="px-2.5 py-1.5 text-2xs text-muted-foreground/70">No agents yet</li>
251+
) : null}
252+
</ul>
282253
) : null}
283254
</li>
284255
);

0 commit comments

Comments
 (0)