Skip to content

Commit 1b1067c

Browse files
committed
fix(web): use the shared text-generation provider filter in GeneralSettingsPanel
The instance-model and model-options handlers now resolve against the same filtered provider list the panel renders, so a selection can never fall back to a hidden ACP instance.
1 parent f766508 commit 1b1067c

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

‎apps/web/src/components/settings/SettingsPanels.tsx‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ import { usePrimarySettings, useUpdatePrimarySettings } from "../../hooks/useSet
6969
import { useThreadActions } from "../../hooks/useThreadActions";
7070
import { useDesktopUpdateState } from "../../state/desktopUpdate";
7171
import {
72+
filterTextGenerationProviders,
7273
getCustomModelOptionsByInstance,
7374
resolveAppModelSelectionState,
7475
withoutPlanAgentSelection,
@@ -1909,9 +1910,7 @@ export function GeneralSettingsPanel() {
19091910
const serverProviders = useAtomValue(primaryServerProvidersAtom);
19101911
const supportsAutoSettlement =
19111912
useAtomValue(primaryServerConfigAtom)?.environment.capabilities.threadAutoSettlement === true;
1912-
const textGenerationProviders = serverProviders.filter(
1913-
(provider) => provider.driver !== ProviderDriverKind.make("acp"),
1914-
);
1913+
const textGenerationProviders = filterTextGenerationProviders(serverProviders);
19151914
const diagnosticsDescription = formatDiagnosticsDescription({
19161915
localTracingEnabled: observability?.localTracingEnabled ?? false,
19171916
otlpTracesEnabled: observability?.otlpTracesEnabled ?? false,
@@ -2566,7 +2565,7 @@ export function GeneralSettingsPanel() {
25662565
...settings,
25672566
textGenerationModelSelection: createModelSelection(instanceId, model),
25682567
},
2569-
serverProviders,
2568+
textGenerationProviders,
25702569
),
25712570
});
25722571
}}
@@ -2599,7 +2598,7 @@ export function GeneralSettingsPanel() {
25992598
nextOptions,
26002599
),
26012600
},
2602-
serverProviders,
2601+
textGenerationProviders,
26032602
),
26042603
});
26052604
}}

0 commit comments

Comments
 (0)