Skip to content

Commit 1a9d391

Browse files
committed
fix(web): reject unsupported HEIC image sequences
1 parent 0810a80 commit 1a9d391

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

‎apps/web/src/lib/imageCompression.test.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,9 @@ describe("compressImageForStash", () => {
305305
describe("HEIC attachment preparation", () => {
306306
it("recognizes HEIC and HEIF MIME types and case-insensitive file extensions", () => {
307307
expect(isHeicImageFile({ name: "photo.bin", type: "image/heic" })).toBe(true);
308-
expect(isHeicImageFile({ name: "photo.bin", type: "image/heif-sequence" })).toBe(true);
308+
expect(isHeicImageFile({ name: "photo.bin", type: "image/heif" })).toBe(true);
309+
expect(isHeicImageFile({ name: "photo.heic", type: "image/heic-sequence" })).toBe(false);
310+
expect(isHeicImageFile({ name: "photo.heif", type: "image/heif-sequence" })).toBe(false);
309311
expect(isHeicImageFile({ name: "IMG_1234.HEIC", type: "" })).toBe(true);
310312
expect(isHeicImageFile({ name: "photo.heif", type: "application/octet-stream" })).toBe(true);
311313
expect(isHeicImageFile({ name: "photo.png", type: "image/png" })).toBe(false);

‎apps/web/src/lib/imageCompression.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const MAX_HEIC_METADATA_BYTES = 1024 * 1024;
3535
const QUALITY_STEPS = [0.92, 0.85, 0.78, 0.68] as const;
3636
/** Extra downscale passes applied when even the lowest quality overflows. */
3737
const FALLBACK_SCALE_STEPS = [0.75, 0.55] as const;
38-
const HEIC_IMAGE_MIME_TYPE = /^image\/hei(?:c|f)(?:-sequence)?$/i;
38+
const HEIC_IMAGE_MIME_TYPE = /^image\/hei(?:c|f)$/i;
3939
const HEIC_IMAGE_EXTENSION = /\.(?:heic|heif)$/i;
4040

4141
export interface CompressedStashImage {

0 commit comments

Comments
 (0)