Skip to content

Commit 1996aa0

Browse files
perf(web): the pull request state hooks compile without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit 1996aa0

2 files changed

Lines changed: 16 additions & 21 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/state/pullRequests.ts",
99100
] as const;

‎apps/web/src/state/pullRequests.ts‎

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import {
2121
} from "@t3tools/shared/threadPullRequests";
2222
import * as Option from "effect/Option";
2323
import { AsyncResult, Atom } from "effect/reactivity";
24-
import { useCallback, useLayoutEffect, useMemo } from "react";
24+
import { useLayoutEffect } from "react";
2525

2626
import { connectionAtomRuntime } from "../connection/runtime";
2727
import { appAtomRegistry } from "../rpc/atomRegistry";
@@ -288,16 +288,13 @@ function createMergedEnvironmentQuery<Input, A>(
288288
return function useMergedQuery(targets: ReadonlyArray<EnvironmentQueryTarget<Input>>) {
289289
const key = JSON.stringify(targets);
290290
const view = useAtomValue(targets.length === 0 ? empty : family(key));
291-
const refresh = useCallback(
292-
(override?: ReadonlyArray<EnvironmentQueryTarget<Input>>) => {
293-
const refreshTargets =
294-
override ?? (JSON.parse(key) as ReadonlyArray<EnvironmentQueryTarget<Input>>);
295-
for (const atom of new Set(refreshTargets.map(atomFor))) {
296-
appAtomRegistry.refresh(atom);
297-
}
298-
},
299-
[key],
300-
);
291+
const refresh = (override?: ReadonlyArray<EnvironmentQueryTarget<Input>>) => {
292+
const refreshTargets =
293+
override ?? (JSON.parse(key) as ReadonlyArray<EnvironmentQueryTarget<Input>>);
294+
for (const atom of new Set(refreshTargets.map(atomFor))) {
295+
appAtomRegistry.refresh(atom);
296+
}
297+
};
301298
return { ...view, refresh };
302299
};
303300
}
@@ -359,7 +356,7 @@ export function usePullRequestList(
359356
}
360357
}
361358
}, [query.observations]);
362-
const data = useMemo(() => mergePullRequestLists(query.values), [query.values]);
359+
const data = mergePullRequestLists(query.values);
363360
return { data, error: query.error, isPending: query.isPending, refresh: query.refresh };
364361
}
365362

@@ -373,14 +370,11 @@ export function usePullRequestListStats(
373370
) => void;
374371
} {
375372
const query = usePullRequestStatsQuery(targets);
376-
const stats = useMemo(
377-
() =>
378-
query.values.length === 0
379-
? null
380-
: query.values.flatMap(([environmentId, result]) =>
381-
result.stats.map((stat) => ({ ...stat, environmentId })),
382-
),
383-
[query.values],
384-
);
373+
const stats =
374+
query.values.length === 0
375+
? null
376+
: query.values.flatMap(([environmentId, result]) =>
377+
result.stats.map((stat) => ({ ...stat, environmentId })),
378+
);
385379
return { stats, isPending: query.isPending, refresh: query.refresh };
386380
}

0 commit comments

Comments
 (0)