Skip to content

Commit 190dde8

Browse files
ci: scope UI consistency evidence checks
Co-authored-by: Julius Marminge <[email protected]>
1 parent 148b0fb commit 190dde8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎.macroscope/check-run-agents/ui-consistency.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ The goal is not to minimize CSS or class counts at any cost. The goal is to put
6363
## Visual and layout preservation
6464

6565
- Preserve responsive geometry, titlebar insets, panel and inline-preview modes, desktop Electron layout, light and dark contrast, clipping, radius, and composable shadows.
66-
- For meaningful visual changes, require verification in the real app using the actual component and state. A mock recreation is not evidence. Light and dark checks are expected when theme-sensitive styles change.
66+
- For meaningful visual changes, prefer available real-app evidence using the actual component and state. A mock recreation does not validate the real component. Light and dark evidence is useful when theme-sensitive styles change, but missing or inaccessible evidence alone is not a finding; report only a concrete regression supported by the diff, code, or available artifacts.
6767
- Do not treat a screenshot as proof of keyboard, overflow, scrollbar, responsive, or runtime-theme behavior. Pair visual evidence with source, computed-style, emitted-CSS, or interaction checks as appropriate.
6868
- Be alert to shared primitive color indirection. When a primitive routes icon color through a CSS variable, ensure migrated contextual icons retain their intended tone, including pressed and disabled states.
6969

@@ -73,10 +73,10 @@ The goal is not to minimize CSS or class counts at any cost. The goal is to put
7373
- Prefer the smallest durable contract over a component-specific workaround or a broad abstraction with one consumer.
7474
- Preserve intentional exceptions and comments that explain browser, virtualizer, theme, or Electron constraints.
7575
- If a proposed cleanup cannot prove ownership or semantic equivalence, ask for evidence or leave it unchanged rather than guessing.
76-
- Treat typecheck, focused tests, production build, emitted-CSS inspection, and relevant real-app evidence as complementary gates. Passing one does not replace the others.
76+
- Select verification gates according to the changed behavior: typecheck or focused tests for typing and interaction contracts, production build and emitted-CSS inspection for Tailwind or selector transformations, and real-app evidence for meaningful visual behavior when available. These gates are complementary when applicable, but do not require every gate for tiny visual-only migrations or fail solely because an artifact the configured tools cannot produce is absent.
7777

7878
## Reporting
7979

80-
Report only concrete violations introduced or retained in the pull request's changed scope. Prefer precise inline comments on the smallest relevant line range. Explain the broken behavior or ownership rule, not merely the preferred syntax, and state the smallest expected fix. A clear consistency or regression risk may fail the check. Do not fail for optional aesthetic preferences, harmless class ordering, or unrelated legacy code.
80+
Report only concrete violations introduced by changed lines or behavior, plus pre-existing behavior that the patch directly makes relevant or worsens. Touching a large file does not make unrelated retained issues reportable. Prefer precise inline comments on the smallest relevant line range. Explain the broken behavior or ownership rule, not merely the preferred syntax, and state the smallest expected fix. A clear consistency or regression risk may fail the check. Do not fail for optional aesthetic preferences, harmless class ordering, or unrelated legacy code.
8181

8282
This check defaults to failure. When there are no findings, stop immediately and make the entire final response exactly `All clear` on one line. Do not add a title, explanation, punctuation, Markdown, JSON, or trailing analysis, and do not continue reasoning after deciding the review is clean.

0 commit comments

Comments
 (0)