Skip to content

Commit 16f9b1d

Browse files
committed
fix(grok): reject native permission bypass commands
1 parent 061c8c1 commit 16f9b1d

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎apps/server/src/provider/Layers/GrokAdapter.test.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -337,6 +337,13 @@ it.layer(grokAdapterTestLayer)("GrokAdapterLive", (it) => {
337337
],
338338
],
339339
);
340+
const permissionError = yield* adapter
341+
.sendTurn({ threadId, input: "/always-approve on" })
342+
.pipe(Effect.flip);
343+
if (permissionError._tag !== "ProviderAdapterRequestError") {
344+
assert.fail(`Unexpected error: ${permissionError._tag}`);
345+
}
346+
assert.include(permissionError.detail, "permission selector");
340347
yield* adapter.sendTurn({ threadId, input: "/goal status" });
341348
yield* adapter.stopSession(threadId);
342349
const requests = yield* Effect.promise(() => readJsonLines(requestLogPath));

‎apps/server/src/provider/Layers/GrokAdapter.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,6 +1505,13 @@ export function makeGrokAdapter(grokSettings: GrokSettings, options?: GrokAdapte
15051505

15061506
const sendTurn: GrokAdapterShape["sendTurn"] = (input) =>
15071507
Effect.gen(function* () {
1508+
if (/^\/always-approve(?:\s|$)/i.test(input.input?.trim() ?? "")) {
1509+
return yield* new ProviderAdapterRequestError({
1510+
provider: PROVIDER,
1511+
method: "session/prompt",
1512+
detail: "Change permissions with T3's permission selector instead of /always-approve.",
1513+
});
1514+
}
15081515
const prepared = yield* withThreadLock(
15091516
input.threadId,
15101517
Effect.gen(function* () {

0 commit comments

Comments
 (0)