Skip to content

Commit 16b5b60

Browse files
fix(mobile): the Changed files inspector starts below its header
The Changed files list padded its top by the column's safe area plus a fixed 44pt bar. On an unfolded iPhone Duo the column's top inset is 0, because the status bar sits in the vertical bar, while the pane's own native header ends 82pt down, so the first file started under it. The list now lets UIKit inset it for the header, as the Git and Files inspectors already do. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 837323d commit 16b5b60

1 file changed

Lines changed: 2 additions & 11 deletions

File tree

‎apps/mobile/src/features/review/ReviewSheet.tsx‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import { environmentCatalog } from "../../connection/catalog";
4141
import { useEnvironmentPresentation } from "../../state/presentation";
4242
import { useAtomCommand } from "../../state/use-atom-command";
4343
import { useUniwindTheme } from "../../lib/useUniwindTheme";
44-
import { IOS_NAV_BAR_HEIGHT } from "../../lib/layoutMetrics";
4544
import { useThreadDraftForThread } from "../../state/use-thread-composer-state";
4645
import { EnvironmentConnectionNotice } from "../connection/EnvironmentConnectionNotice";
4746
import { useAppearancePreferences } from "../settings/appearance/AppearancePreferencesProvider";
@@ -308,7 +307,6 @@ function ReviewFileNavigator({
308307
onSelectFile,
309308
ref,
310309
}: ReviewFileNavigatorProps) {
311-
const insets = useSafeAreaInsets();
312310
const theme = useUniwindTheme();
313311
const sheetColor = theme["--color-sheet"];
314312
const foregroundColor = theme["--color-foreground"];
@@ -360,15 +358,8 @@ function ReviewFileNavigator({
360358
data={files}
361359
extraData={selectedFileId}
362360
keyExtractor={(file) => file.id}
363-
contentContainerStyle={{
364-
paddingHorizontal: 8,
365-
paddingBottom: 8,
366-
367-
paddingTop: Platform.OS === "ios" ? insets.top + IOS_NAV_BAR_HEIGHT + 8 : 8,
368-
}}
369-
scrollIndicatorInsets={
370-
Platform.OS === "ios" ? { top: insets.top + IOS_NAV_BAR_HEIGHT } : undefined
371-
}
361+
contentInsetAdjustmentBehavior={Platform.OS === "ios" ? "automatic" : "never"}
362+
contentContainerStyle={{ paddingHorizontal: 8, paddingVertical: 8 }}
372363
renderItem={renderFile}
373364
/>
374365
);

0 commit comments

Comments
 (0)