Skip to content

Commit 1656729

Browse files
perf(web): the pull request stack hook compiles without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a702563 commit 1656729

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

‎apps/web/src/state/usePullRequestStack.ts‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import type { EnvironmentId, PullRequestRef } from "@t3tools/contracts";
2-
import { useMemo } from "react";
32
import {
43
savedPullRequestStack,
54
pullRequestStackView,
@@ -8,23 +7,24 @@ import { useThreadShells } from "./entities";
87
import { pullRequestStackAtom } from "./pullRequests";
98
import { useEnvironmentQuery } from "./query";
109

10+
function useSavedPullRequestStack(environmentId: EnvironmentId, reference: PullRequestRef | null) {
11+
"use memo";
12+
const threads = useThreadShells();
13+
return reference === null
14+
? null
15+
: savedPullRequestStack(
16+
threads
17+
.filter((thread) => thread.environmentId === environmentId)
18+
.flatMap((thread) => thread.pullRequests ?? []),
19+
reference,
20+
);
21+
}
22+
1123
export function usePullRequestStack(
1224
environmentId: EnvironmentId,
1325
reference: PullRequestRef | null,
1426
) {
15-
const threads = useThreadShells();
16-
const saved = useMemo(
17-
() =>
18-
reference === null
19-
? null
20-
: savedPullRequestStack(
21-
threads
22-
.filter((thread) => thread.environmentId === environmentId)
23-
.flatMap((thread) => thread.pullRequests ?? []),
24-
reference,
25-
),
26-
[environmentId, reference, threads],
27-
);
27+
const saved = useSavedPullRequestStack(environmentId, reference);
2828
const query = useEnvironmentQuery(
2929
reference === null ? null : pullRequestStackAtom({ environmentId, input: reference }),
3030
);

0 commit comments

Comments
 (0)