Skip to content

Commit 1652982

Browse files
committed
test(mobile): focus sidebar summary demand coverage
1 parent b7a1d0c commit 1652982

1 file changed

Lines changed: 0 additions & 179 deletions

File tree

‎apps/mobile/src/state/use-thread-pr.demand.test.tsx‎

Lines changed: 0 additions & 179 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import { expect, it } from "@effect/vitest";
2929
import { vi } from "vite-plus/test";
3030

3131
const fixture = vi.hoisted(() => ({
32-
registry: undefined as AtomRegistry.AtomRegistry | undefined,
3332
environment: undefined as EnvironmentRegistry.EnvironmentRegistry["Service"] | undefined,
3433
active: "active",
3534
listeners: new Set<() => void>(),
@@ -58,11 +57,6 @@ vi.mock("../connection/runtime", async () => {
5857
),
5958
};
6059
});
61-
vi.mock("./atom-registry", () => ({
62-
get appAtomRegistry() {
63-
return fixture.registry!;
64-
},
65-
}));
6660
vi.mock("./server", async () => {
6761
const { Atom } = await import("effect/reactivity");
6862
const config = Atom.make({ environment: { capabilities: { threadPullRequests: true } } });
@@ -71,7 +65,6 @@ vi.mock("./server", async () => {
7165

7266
import { ThreadPrDemandProvider } from "./thread-pr-demand";
7367
import { useThreadPr } from "./use-thread-pr";
74-
import { deriveLayout, deriveWorkspacePaneLayout, isPrimarySidebarPinned } from "../lib/layout";
7568

7669
const environmentId = EnvironmentId.make("sidebar-environment");
7770
const reference = {
@@ -168,7 +161,6 @@ const setup = Effect.fn("TestThreadPr.setup")(function* () {
168161
fixture.environment =
169162
environment as unknown as EnvironmentRegistry.EnvironmentRegistry["Service"];
170163
const registry = AtomRegistry.make();
171-
fixture.registry = registry;
172164
const container = document.createElement("div");
173165
const root = createRoot(container);
174166
let mounts = 0;
@@ -248,61 +240,6 @@ const setup = Effect.fn("TestThreadPr.setup")(function* () {
248240
};
249241
});
250242

251-
it.effect.each([
252-
{
253-
name: "root pins the sidebar despite a closed preference",
254-
pathname: "/",
255-
preferred: false,
256-
inspector: false,
257-
visible: true,
258-
},
259-
{
260-
name: "detail route keeps an open split sidebar live",
261-
pathname: "/threads/1",
262-
preferred: true,
263-
inspector: false,
264-
visible: true,
265-
},
266-
{
267-
name: "detail route respects a closed sidebar",
268-
pathname: "/threads/1",
269-
preferred: false,
270-
inspector: false,
271-
visible: false,
272-
},
273-
{
274-
name: "inspector suppresses a retained sidebar when the split has no room",
275-
pathname: "/threads/1",
276-
preferred: true,
277-
inspector: true,
278-
visible: false,
279-
},
280-
])("uses the actual pane visibility: $name", ({ pathname, preferred, inspector, visible }) =>
281-
Effect.gen(function* () {
282-
using h = yield* setup();
283-
const layout = deriveLayout({ width: 1024, height: 834 });
284-
const pinned = isPrimarySidebarPinned({
285-
pathname,
286-
nativeWorkspace: false,
287-
usesSplitView: layout.usesSplitView,
288-
});
289-
const panes = deriveWorkspacePaneLayout({
290-
layout,
291-
viewportWidth: 1024,
292-
primarySidebarPreferredVisible: pinned || preferred,
293-
auxiliaryPanePreferredVisible: inspector,
294-
auxiliaryPaneRole: "inspector",
295-
});
296-
expect(panes.primarySidebarVisible).toBe(visible);
297-
yield* Effect.promise(async () => {
298-
await h.render({ visible: panes.primarySidebarVisible });
299-
await h.advance(190_000);
300-
expect(h.requests).toHaveLength(visible ? 4 : 0);
301-
expect(h.badge()).toBe(visible ? "#12 pull request open" : "none");
302-
});
303-
}),
304-
);
305-
306243
it.effect(
307244
"releases retained hidden sidebar demand and keeps the badge while reveal revalidates",
308245
() =>
@@ -386,104 +323,6 @@ it.effect.each(["inactive", "background"])("releases sidebar demand while the OS
386323
}),
387324
);
388325

389-
it.effect.each([
390-
{ field: "environment", changed: { environmentId: EnvironmentId.make("other") } },
391-
{
392-
field: "project",
393-
changed: { branchPullRequest: { ...reference, projectId: ProjectId.make("other") } },
394-
},
395-
{
396-
field: "repository",
397-
changed: { branchPullRequest: { ...reference, repository: "acme/other" } },
398-
},
399-
{ field: "PR", changed: { branchPullRequest: { ...reference, number: 13 } } },
400-
])("does not show an old badge after a hidden $field change", ({ changed }) =>
401-
Effect.gen(function* () {
402-
using h = yield* setup();
403-
yield* Effect.promise(async () => {
404-
await h.render();
405-
await h.render({ visible: false });
406-
await h.advance(10_000);
407-
const before = h.requests.length;
408-
const value = thread(changed);
409-
await h.render({ visible: false, value });
410-
expect(h.badge()).toBe("none");
411-
await h.advance(180_000);
412-
expect(h.requests.length).toBe(before);
413-
h.holdReplies();
414-
await h.render({ value });
415-
expect(h.badge()).toBe("none");
416-
expect(h.requests.length).toBe(before + 1);
417-
expect(h.requests.at(-1)?.environmentId).toBe(value.environmentId);
418-
expect(h.requests.at(-1)?.input).toMatchObject({
419-
projectId: value.branchPullRequest!.projectId,
420-
repository: value.branchPullRequest!.repository,
421-
number: value.branchPullRequest!.number,
422-
});
423-
await h.releaseReplies();
424-
expect(h.badge()).toBe(`#${value.branchPullRequest!.number} pull request open`);
425-
expect(h.mounts).toBe(1);
426-
});
427-
}),
428-
);
429-
430-
it.effect("clears a removed PR while hidden instead of resurrecting its cached badge", () =>
431-
Effect.gen(function* () {
432-
using h = yield* setup();
433-
yield* Effect.promise(async () => {
434-
await h.render();
435-
const value = thread({ branchPullRequest: null });
436-
await h.render({ visible: false, value });
437-
expect(h.badge()).toBe("none");
438-
await h.advance(190_000);
439-
await h.render({ value });
440-
expect(h.requests).toHaveLength(1);
441-
expect(h.badge()).toBe("none");
442-
});
443-
}),
444-
);
445-
446-
it.effect.each([true, false])(
447-
"renders linked presentations with no fallback RPC, snapshot present: %s",
448-
(snapshot) =>
449-
Effect.gen(function* () {
450-
using h = yield* setup();
451-
yield* Effect.promise(async () => {
452-
const value = thread({
453-
pullRequests: [
454-
{
455-
host: "github.com",
456-
repository: "acme/app",
457-
number: 14,
458-
url: "https://github.com/acme/app/pull/14",
459-
source: "manual",
460-
linkedAt: "2026-10-26T00:00:00Z",
461-
stack: null,
462-
snapshot: snapshot
463-
? {
464-
title: "Linked",
465-
state: "open",
466-
isDraft: false,
467-
headBranch: "feature",
468-
baseBranch: "main",
469-
updatedAt: null,
470-
syncedAt: "2026-10-26T00:00:00Z",
471-
}
472-
: null,
473-
},
474-
],
475-
});
476-
await h.render({ value });
477-
expect(h.badge()).toBe(`#14 pull request ${snapshot ? "open" : "status pending"}`);
478-
await h.render({ value, visible: false });
479-
await h.advance(190_000);
480-
await h.render({ value });
481-
expect(h.requests).toHaveLength(0);
482-
expect(h.badge()).toBe(`#14 pull request ${snapshot ? "open" : "status pending"}`);
483-
});
484-
}),
485-
);
486-
487326
it.effect("keeps mounted passive state through an Android-style Activity tab switch", () =>
488327
Effect.gen(function* () {
489328
using h = yield* setup();
@@ -504,21 +343,3 @@ it.effect("keeps mounted passive state through an Android-style Activity tab swi
504343
});
505344
}),
506345
);
507-
508-
it.effect(
509-
"allows only the existing idle-grace poll when the sidebar closes just before a tick",
510-
() =>
511-
Effect.gen(function* () {
512-
using h = yield* setup();
513-
yield* Effect.promise(async () => {
514-
await h.render();
515-
await h.advance(59_000);
516-
await h.render({ visible: false });
517-
await h.advance(10_000);
518-
const afterGrace = h.requests.length;
519-
expect(afterGrace).toBeLessThanOrEqual(2);
520-
await h.advance(180_000);
521-
expect(h.requests.length).toBe(afterGrace);
522-
});
523-
}),
524-
);

0 commit comments

Comments
 (0)