@@ -2146,8 +2146,8 @@ describe("PreviewManager", () => {
21462146 { sourceId : "tab:41" , width : 800 , height : 600 } ,
21472147 { sourceId : "tab:42" , width : 390 , height : 844 } ,
21482148 ] ) ;
2149- expect ( firstCapturePage ) . not . toHaveBeenCalled ( ) ;
2150- expect ( secondCapturePage ) . not . toHaveBeenCalled ( ) ;
2149+ expect ( firstCapturePage ) . toHaveBeenCalledOnce ( ) ;
2150+ expect ( secondCapturePage ) . toHaveBeenCalledOnce ( ) ;
21512151 expect ( firstSendCommand ) . not . toHaveBeenCalledWith (
21522152 "Page.startScreencast" ,
21532153 expect . anything ( ) ,
@@ -2440,19 +2440,19 @@ describe("PreviewManager", () => {
24402440 const pictureInPictureFramesBeforeRecording = pictureInPictureSend . mock . calls . length ;
24412441
24422442 yield * manager . startRecording ( "tab_pip" ) ;
2443- expect ( capturePage ) . toHaveBeenCalledOnce ( ) ;
2443+ expect ( capturePage ) . toHaveBeenCalledTimes ( 2 ) ;
24442444 expect ( recordingFrames ) . toHaveLength ( 0 ) ;
24452445
24462446 yield * TestClock . adjust ( 100 ) ;
2447- expect ( capturePage ) . toHaveBeenCalledTimes ( 2 ) ;
2447+ expect ( capturePage ) . toHaveBeenCalledTimes ( 3 ) ;
24482448 expect ( pictureInPictureSend ) . toHaveBeenCalledTimes ( pictureInPictureFramesBeforeRecording ) ;
24492449 expect ( recordingFrames ) . toHaveLength ( 0 ) ;
24502450
24512451 yield * manager . stopRecording ( "tab_pip" ) ;
24522452 expect ( setBackgroundThrottling . mock . calls ) . toEqual ( [ [ false ] ] ) ;
24532453 const framesBeforePictureInPictureOnlyTick = pictureInPictureSend . mock . calls . length ;
24542454 yield * TestClock . adjust ( 100 ) ;
2455- expect ( capturePage ) . toHaveBeenCalledTimes ( 3 ) ;
2455+ expect ( capturePage ) . toHaveBeenCalledTimes ( 4 ) ;
24562456 expect ( pictureInPictureSend . mock . calls . length ) . toBe ( framesBeforePictureInPictureOnlyTick ) ;
24572457 expect ( recordingFrames ) . toHaveLength ( 0 ) ;
24582458
@@ -2470,7 +2470,7 @@ describe("PreviewManager", () => {
24702470 ) ,
24712471 ) ;
24722472
2473- effectIt . effect ( "starts picture-in-picture without an extra recording capture " , ( ) =>
2473+ effectIt . effect ( "keeps picture-in-picture capture separate from recording warmup " , ( ) =>
24742474 withManager ( ( manager ) =>
24752475 Effect . gen ( function * ( ) {
24762476 const jpeg = Buffer . from ( "shared-preview-frame" ) ;
@@ -2495,14 +2495,14 @@ describe("PreviewManager", () => {
24952495 yield * manager . startRecording ( "tab_recording_then_pip" ) ;
24962496
24972497 expect ( recordingFrames ) . toHaveLength ( 0 ) ;
2498- expect ( capturePage ) . not . toHaveBeenCalled ( ) ;
2499- yield * manager . openPictureInPicture ( "tab_recording_then_pip" ) ;
25002498 expect ( capturePage ) . toHaveBeenCalledOnce ( ) ;
2499+ yield * manager . openPictureInPicture ( "tab_recording_then_pip" ) ;
2500+ expect ( capturePage ) . toHaveBeenCalledTimes ( 2 ) ;
25012501 expect ( send ) . toHaveBeenCalledOnce ( ) ;
25022502
25032503 yield * TestClock . adjust ( 100 ) ;
25042504
2505- expect ( capturePage ) . toHaveBeenCalledTimes ( 2 ) ;
2505+ expect ( capturePage ) . toHaveBeenCalledTimes ( 3 ) ;
25062506 expect ( recordingFrames ) . toHaveLength ( 0 ) ;
25072507 expect ( send ) . toHaveBeenCalledOnce ( ) ;
25082508 yield * manager . closePictureInPicture ( "tab_recording_then_pip" ) ;
0 commit comments