Skip to content

Commit 14b8f21

Browse files
committed
fix(mobile): release prepared audio before preparing again
1 parent 4c795fd commit 14b8f21

3 files changed

Lines changed: 49 additions & 0 deletions

File tree

‎apps/mobile/modules/t3-voice-transcription/android/build.gradle‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ dependencies {
2020
implementation 'androidx.media3:media3-common:1.9.1'
2121
implementation 'com.google.mlkit:genai-speech-recognition:1.0.0-alpha2'
2222
testImplementation 'junit:junit:4.13.2'
23+
testImplementation 'com.facebook.react:react-android'
2324
testImplementation 'org.robolectric:robolectric:4.16.1'
2425
testImplementation 'org.jetbrains.kotlinx:kotlinx-coroutines-test:1.10.2'
2526
}

‎apps/mobile/modules/t3-voice-transcription/android/src/main/java/expo/modules/t3voicetranscription/LiveVoiceRecorder.kt‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ internal class LiveVoiceRecorder(
4141
@Suppress("TooGenericExceptionCaught") // Release native handles for every setup failure.
4242
fun prepare() {
4343
check(capture?.isRecording != true) { "Another voice recording is active." }
44+
capture?.abort()
4445
pipe?.close()
4546
inputCanceled = false
4647
inferenceStarted = false
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
package expo.modules.t3voicetranscription
2+
3+
import android.media.AudioRecord
4+
import com.facebook.react.bridge.BridgeReactContext
5+
import expo.modules.kotlin.AppContext
6+
import expo.modules.kotlin.ModulesProvider
7+
import expo.modules.kotlin.modules.Module
8+
import java.lang.ref.WeakReference
9+
import kotlinx.coroutines.test.runTest
10+
import org.junit.Assert.assertEquals
11+
import org.junit.Test
12+
import org.junit.runner.RunWith
13+
import org.robolectric.RobolectricTestRunner
14+
import org.robolectric.RuntimeEnvironment
15+
import org.robolectric.annotation.Config
16+
import org.robolectric.util.ReflectionHelpers
17+
18+
@RunWith(RobolectricTestRunner::class)
19+
@Config(manifest = Config.NONE, sdk = [31])
20+
class LiveVoiceRecorderTest {
21+
@Test fun preparingAgainReleasesTheUnusedMicrophone() = runTest {
22+
val context = RuntimeEnvironment.getApplication()
23+
val reactContext = BridgeReactContext(context)
24+
val appContext = AppContext(
25+
object : ModulesProvider {
26+
override fun getModulesMap() = emptyMap<Class<out Module>, String?>()
27+
},
28+
expo.modules.core.ModuleRegistry(emptyList(), emptyList()),
29+
WeakReference(reactContext)
30+
)
31+
val recorder = LiveVoiceRecorder(context, appContext, this) {}
32+
try {
33+
recorder.prepare()
34+
val previous = ReflectionHelpers.getField<AudioRecord>(recorder, "audio")
35+
assertEquals(AudioRecord.STATE_INITIALIZED, previous.state)
36+
recorder.prepare()
37+
assertEquals(AudioRecord.STATE_UNINITIALIZED, previous.state)
38+
} finally {
39+
recorder.sharedObjectDidRelease()
40+
appContext.javaClass.declaredMethods.first {
41+
it.name.startsWith("onDestroy") && it.parameterCount == 0
42+
}
43+
.invoke(appContext)
44+
reactContext.destroy()
45+
}
46+
}
47+
}

0 commit comments

Comments
 (0)