Skip to content

Commit 1474563

Browse files
fix(ci): scope the relay teardown concurrency group to the teardown job
The workflow-level group applied to every run, including closed events that skip all jobs. GitHub replaces a pending run in a group with a newer one, so a label-less close could drop a queued teardown for the same PR. The group now sits on the teardown job, which is the only job that needs it. Co-Authored-By: Claude Haiku 5.5 <[email protected]>
1 parent 5d543a2 commit 1474563

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

‎.github/workflows/relay-preview-cleanup.yml‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ permissions:
1818
issues: read
1919
pull-requests: read
2020

21-
concurrency:
22-
group: relay-preview-${{ github.event.pull_request.number || 'sweep' }}
23-
cancel-in-progress: false
24-
2521
jobs:
2622
cleanup_pr:
2723
name: Tear down relay preview
@@ -31,6 +27,12 @@ jobs:
3127
(github.event.action == 'unlabeled' && github.event.label.name == 'relay:preview') ||
3228
(github.event.action == 'closed' && contains(github.event.pull_request.labels.*.name, 'relay:preview'))
3329
)
30+
# Job-level so that events which skip this job, such as a closed PR without
31+
# the label, never take the group's pending slot. GitHub replaces a pending
32+
# run in a group with a newer one, which would drop a queued teardown.
33+
concurrency:
34+
group: relay-preview-${{ github.event.pull_request.number }}
35+
cancel-in-progress: false
3436
runs-on: blacksmith-8vcpu-ubuntu-2404
3537
timeout-minutes: 30
3638
environment:

0 commit comments

Comments
 (0)