Skip to content

Commit 137feb2

Browse files
afrojunclaude
andcommitted
fix(server): Codex network waits no longer show a stale retry limit
When Codex runs out of numbered reconnects ("Reconnecting... 5/5") it keeps waiting for the network indefinitely ("Reconnecting... waiting for network"). The adapter kept the old maximum for those uncounted retries, so the label climbed past it, for example "Retrying provider (272/5)". Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent ff7aa5a commit 137feb2

2 files changed

Lines changed: 30 additions & 5 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts‎

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3634,6 +3634,25 @@ describe("CodexAdapterV2 post-settle continuation", () => {
36343634
},
36353635
},
36363636
},
3637+
{
3638+
type: "emit_inbound",
3639+
label: "error/retry/waiting-for-network",
3640+
frame: {
3641+
method: "error",
3642+
params: {
3643+
threadId: nativeThreadId,
3644+
turnId: nativeTurnId,
3645+
willRetry: true,
3646+
error: {
3647+
message: "Reconnecting... waiting for network",
3648+
additionalDetails: "Connection failed: error sending request",
3649+
codexErrorInfo: {
3650+
responseStreamDisconnected: { httpStatusCode: null },
3651+
},
3652+
},
3653+
},
3654+
},
3655+
},
36373656
{
36383657
type: "emit_inbound",
36393658
label: "item/started/after-retry",
@@ -3717,17 +3736,22 @@ describe("CodexAdapterV2 post-settle continuation", () => {
37173736
? [event.turnItem]
37183737
: [],
37193738
);
3720-
assert.lengthOf(retryItems, 2);
3739+
assert.lengthOf(retryItems, 3);
37213740
assert.equal(retryItems[0]?.status, "running");
37223741
assert.equal(retryItems[0]?.failure.code, "responseStreamDisconnected");
37233742
assert.deepEqual(retryItems[0]?.retry, {
37243743
attempt: 2,
37253744
maxAttempts: 5,
37263745
retryDelayMs: null,
37273746
});
3728-
assert.equal(retryItems[1]?.id, retryItems[0]?.id);
3729-
assert.equal(retryItems[1]?.status, "completed");
3730-
assert.equal(retryItems[1]?.title, "Provider recovered");
3747+
assert.deepEqual(retryItems[1]?.retry, {
3748+
attempt: 3,
3749+
maxAttempts: null,
3750+
retryDelayMs: null,
3751+
});
3752+
assert.equal(retryItems[2]?.id, retryItems[0]?.id);
3753+
assert.equal(retryItems[2]?.status, "completed");
3754+
assert.equal(retryItems[2]?.title, "Provider recovered");
37313755

37323756
const recoveredIndex = harness.events.findIndex(
37333757
(event) =>

‎apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4771,7 +4771,8 @@ export const makeCodexAdapterV2 = Effect.fn("makeCodexAdapterV2")(function* (
47714771
const progress = parseCodexRetryProgress(payload.error.message);
47724772
const retry: OrchestrationV2ProviderRetry = {
47734773
attempt: progress?.attempt ?? (previous?.retry.attempt ?? 0) + 1,
4774-
maxAttempts: progress?.maxAttempts ?? previous?.retry.maxAttempts ?? null,
4774+
// Codex drops the count once it starts waiting for the network, which has no limit.
4775+
maxAttempts: progress?.maxAttempts ?? null,
47754776
retryDelayMs: null,
47764777
};
47774778
const code = codexErrorInfoCode(payload.error.codexErrorInfo);

0 commit comments

Comments
 (0)