Skip to content

Commit 12711eb

Browse files
committed
fix(server): never auto-confirm a persistence field with a Yes choice
A required Yes/No field titled like "Always allow this application" would have been answered Yes, granting persistent access. Confirmation choices now skip persistence fields.
1 parent 31688a3 commit 12711eb

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.test.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,6 +1347,12 @@ describe("ClaudeAdapterV2 MCP elicitation acceptance", () => {
13471347
"confirmation",
13481348
]),
13491349
form({ grant: { type: "string", enum: ["No", "Yes always", "yes_for_session"] } }, ["grant"]),
1350+
form(
1351+
{
1352+
remember: { type: "string", title: "Always allow this application", enum: ["Yes", "No"] },
1353+
},
1354+
["remember"],
1355+
),
13501356
{ serverName: "deploys", message: "Deploy web?", mode: "form" },
13511357
] satisfies ReadonlyArray<ElicitationRequest>) {
13521358
assert.isUndefined(ClaudeAdapterV2.claudeMcpElicitationAcceptance(request));

‎apps/server/src/provider/CodexMcpElicitation.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ export function toMcpElicitationResponse(
212212
? mcpElicitationPersistenceDecision(option.value) === decision
213213
: (ONE_TIME_APPROVAL_CHOICE.test(option.value.trim()) ||
214214
(responseOptions?.acceptConfirmationChoices === true &&
215+
!isMcpElicitationPersistenceField(key, field) &&
215216
ONE_TIME_CONFIRMATION_CHOICE.test(option.value.trim()))) &&
216217
mcpElicitationPersistenceDecision(option.value) === null,
217218
);

0 commit comments

Comments
 (0)