Repository navigation
Commit 1212fd8
refactor(clients): forge settings, routing and icons come from definitions
Clients still held forge knowledge outside the forge packages: the Source
Control settings mounted GitHub-only token and account panels by kind, with
the PAT URL, GH_TOKEN, gh and "GitHub CLI" hardcoded; settings search listed
every forge's name by hand; the per-hostname settings schema lived in
contracts as GitHubHost; the forge-neutral pull request routing trust was
named GitHub in code, storage and UI; and web and mobile each drew every
forge's mark from their own brand components or switch.
Definitions now carry it:
- `credentials` (cliName, cliLabel, loginCommand, tokenEnvVar, tokenAccess,
newTokenUrl), implemented by GitHub. Settings with credentials use core's
`hostCredentialSettingsFields` (hosts/tokens keyed by SourceControlHostName,
replacing contracts' GitHubHost). Web renders SourceControlTokenSettings and
SourceControlAccountSettings for any definition with credentials, through
`readHostCredentialSettings(settings, kind)` and patches of
`sourceControlHosts[kind]`.
- `searchKeywords`; settings search builds each host's entry, the credentials
entry and the shared host terms from the definitions.
- `icon` is declarative artwork (viewBox, paths with fill/stroke/fill-rule,
`currentColor`, user-space linear gradients), or null for the generic glyph.
One renderer per client (React DOM svg, react-native-svg) replaces the brand
components and the mobile switch. `vp run sync:link-icons` renders each
definition's artwork to the mobile link-icon PNGs.
GitHub routing is renamed pull request routing throughout. Storage migrates:
web reads `t3code:github-routing:<id>` while `t3code:pull-request-routing:<id>`
is absent and every write removes the old key; the mobile catalog document
reads `githubRoutingPermissions` while `pullRequestRoutingPermissions` is
absent and every write replaces it, as does removing a connection.
Behaviour changes: routing copy says pull request routing/sharing and source
control access; the settings search target for GitHub's accounts is now its
host entry; mobile links to gitlab.com, codeberg.org, bitbucket.org and other
hosts with artwork show their colour mark (untinted); mobile Bitbucket's
gradient is now in user space, as on web; the integrations copy no longer
names GitHub.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent f5f485e commit 1212fd8
61 files changed
Lines changed: 1115 additions & 930 deletions
File tree
- apps
- mobile
- assets/link-icons
- scripts
- src
- connection
- features
- connection
- projects
- settings
- lib
- native
- web/src
- components
- settings
- connection
- docs
- internals
- user
- packages
- client-runtime/src
- connection
- platform
- state
- contracts/src
- source-control-azure-devops/src/client
- source-control-bitbucket/src/client
- source-control-core/src/client
- source-control-forgejo/src/client
- source-control-gitcafe/src/client
- source-control-github/src/client
- source-control-gitlab/src/client
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Loading
Loading
Loading
Loading
Loading
Loading
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
44 | 45 | | |
45 | 46 | | |
46 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
| 153 | + | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
0 commit comments