Repository navigation
Commit 11ba35e
committed
fix(server): skip nested repositories with no commits before indexing the review
The earlier fix relied on `git add --intent-to-add --ignore-errors` exiting 1
on a nested repository with no commits. That only holds up to Git 2.52. Since
Git 2.53 (6fe288bfbcbb, read-cache: drop submodule check from add_to_cache())
the add succeeds and records a gitlink, then `git diff --numstat` dies with
"cannot hash scaffold" and exit 128, so the review still failed on CI's Git
2.55.0.
Accepting exit 1 was also too wide. --ignore-errors skips any path Git cannot
index, so an untracked file named git~1 was left out of the diff with no sign
that the result was partial.
Ask each nested repository for its HEAD first and leave out the ones with no
commits, which gives the same result on every Git version. --ignore-errors and
the exit 1 handling are gone, so any other add failure is reported again.1 parent bb68209 commit 11ba35e
2 files changed
Lines changed: 78 additions & 32 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2177 | 2177 | | |
2178 | 2178 | | |
2179 | 2179 | | |
| 2180 | + | |
| 2181 | + | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
2180 | 2188 | | |
2181 | 2189 | | |
2182 | 2190 | | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
| 2195 | + | |
| 2196 | + | |
| 2197 | + | |
| 2198 | + | |
| 2199 | + | |
| 2200 | + | |
| 2201 | + | |
| 2202 | + | |
| 2203 | + | |
| 2204 | + | |
| 2205 | + | |
| 2206 | + | |
| 2207 | + | |
| 2208 | + | |
| 2209 | + | |
| 2210 | + | |
| 2211 | + | |
| 2212 | + | |
| 2213 | + | |
| 2214 | + | |
| 2215 | + | |
| 2216 | + | |
| 2217 | + | |
| 2218 | + | |
| 2219 | + | |
| 2220 | + | |
| 2221 | + | |
| 2222 | + | |
| 2223 | + | |
| 2224 | + | |
| 2225 | + | |
| 2226 | + | |
| 2227 | + | |
| 2228 | + | |
| 2229 | + | |
2183 | 2230 | | |
2184 | 2231 | | |
2185 | 2232 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2980 | 2980 | | |
2981 | 2981 | | |
2982 | 2982 | | |
2983 | | - | |
| 2983 | + | |
| 2984 | + | |
| 2985 | + | |
| 2986 | + | |
| 2987 | + | |
| 2988 | + | |
| 2989 | + | |
| 2990 | + | |
| 2991 | + | |
| 2992 | + | |
| 2993 | + | |
| 2994 | + | |
| 2995 | + | |
| 2996 | + | |
| 2997 | + | |
2984 | 2998 | | |
2985 | 2999 | | |
2986 | 3000 | | |
| |||
3015 | 3029 | | |
3016 | 3030 | | |
3017 | 3031 | | |
3018 | | - | |
3019 | | - | |
3020 | | - | |
3021 | | - | |
3022 | | - | |
3023 | | - | |
3024 | | - | |
3025 | | - | |
3026 | | - | |
3027 | | - | |
3028 | | - | |
3029 | | - | |
3030 | | - | |
3031 | | - | |
3032 | | - | |
3033 | | - | |
3034 | | - | |
3035 | | - | |
3036 | | - | |
3037 | | - | |
3038 | | - | |
3039 | | - | |
3040 | | - | |
3041 | | - | |
3042 | | - | |
3043 | | - | |
3044 | | - | |
3045 | | - | |
3046 | | - | |
3047 | | - | |
3048 | | - | |
| 3032 | + | |
| 3033 | + | |
| 3034 | + | |
| 3035 | + | |
| 3036 | + | |
| 3037 | + | |
| 3038 | + | |
| 3039 | + | |
| 3040 | + | |
| 3041 | + | |
| 3042 | + | |
| 3043 | + | |
| 3044 | + | |
| 3045 | + | |
| 3046 | + | |
| 3047 | + | |
3049 | 3048 | | |
3050 | 3049 | | |
3051 | 3050 | | |
| |||
0 commit comments