Skip to content

Commit 1059e25

Browse files
chore(mobile): link react-native-pdf-jsi on Android only
iOS previews PDFs in a WebView, so the library never runs there. Excluding it from iOS autolinking drops its iOS build patch, and its config plugin did nothing Android needs (New Architecture is already on, OCR defaults off). Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 78f4f44 commit 1059e25

5 files changed

Lines changed: 9 additions & 52 deletions

File tree

‎apps/mobile/app.config.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,6 @@ const config: ExpoConfig = {
326326
},
327327
plugins: [
328328
"expo-asset",
329-
// iOS previews PDFs in a WebView; keep the plugin from exposing Documents in the Files app.
330-
["react-native-pdf-jsi", { iosFileSharing: false }],
331329
[
332330
"expo-font",
333331
{

‎apps/mobile/package.json‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,12 @@
179179
"expo-video",
180180
"expo-network",
181181
"expo-sharing"
182-
]
182+
],
183+
"ios": {
184+
"exclude": [
185+
"react-native-pdf-jsi"
186+
]
187+
}
183188
}
184189
},
185190
"reanimated": {

‎patches/[email protected]‎

Lines changed: 0 additions & 43 deletions
This file was deleted.

‎pnpm-lock.yaml‎

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎pnpm-workspace.yaml‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ overrides:
123123
react-native-gesture-handler: 3.5.0
124124
react-native-reanimated: 4.7.1
125125
react-native-keyboard-controller: 1.23.0
126+
# 6.1.1 cannot build Android: it downloads PDFium from a release asset that was never published.
126127
react-native-pdf-jsi: 6.1.0
127128
react-native-webview: 14.0.1
128129
react-native-svg: 15.16.1
@@ -244,9 +245,6 @@ patchedDependencies:
244245
245246
# Screens v5 stack, split and tab screens leave at once, like legacy screens. Exiting animations
246247
# inside one otherwise hold its removal for a later mount, after its stack has moved on.
247-
# iOS: 6.1.1's fix for the NitroPdfJsi-Swift.h build failure (upstream #44). 6.1.1 itself
248-
# cannot build Android: it downloads PDFium from a release asset that was never published.
249-
250248
251249
252250
# Android: a nested WebView hands a vertical drag to its scrolling parent at the page's edge.

0 commit comments

Comments
 (0)