Skip to content

Commit 0f498c3

Browse files
baileyclaude
authored andcommitted
fix(clients): keep the Goal label beside an open async question
While an async question is open, the row hid its status label because the spinner and timer already say Working. Upstream now labels a working thread with an active goal "Goal", which carries more than Working, so hiding it dropped the goal from the web card, the web and mobile accessible labels, and the mobile row. Only the Working label is hidden now; a goal reads "Input, Goal". Reviewed-by: gpt-6.1-sol (Codex) Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent fbeafad commit 0f498c3

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

‎apps/mobile/src/features/threads/thread-list-v2-items.tsx‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,8 @@ export const ThreadListV2Row = memo(function ThreadListV2Row(props: {
11701170
selected ? selectedThreadRowColors.foregroundClassName : statusLabel.className,
11711171
)}
11721172
>
1173-
{hasAsyncQuestion ? null : statusLabel.label}
1173+
{/* Beside Input the spinner and timer already say Working; Goal says more. */}
1174+
{hasAsyncQuestion && statusLabel.label === "Working" ? null : statusLabel.label}
11741175
{status === "working" ? (
11751176
<ThreadListV2Duration startedAt={resolveThreadWorkingStartedAt(thread)} />
11761177
) : status === "waiting" ? (
@@ -1320,7 +1321,7 @@ export const ThreadListV2Row = memo(function ThreadListV2Row(props: {
13201321

13211322
const rowAccessibilityLabel = [
13221323
thread.title,
1323-
hasAsyncQuestion ? "Input, still working" : null,
1324+
hasAsyncQuestion ? `Input, ${statusLabel?.label === "Goal" ? "Goal" : "still working"}` : null,
13241325
props.hasQueuedMessages ? "messages queued to send" : null,
13251326
]
13261327
.filter(Boolean)

‎apps/web/src/components/sidebar/SidebarThreadRow.tsx‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,9 +1000,12 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
10001000
</span>
10011001
) : null;
10021002

1003+
// Beside an async question's Input, the spinner and timer already say Working; Goal says more.
1004+
const topStatusLabel =
1005+
hasAsyncQuestion && topStatus?.label === "Working" ? null : (topStatus?.label ?? null);
10031006
const accessibility = resolveSidebarRowAccessibility({
10041007
title: thread.title,
1005-
statusLabel: hasAsyncQuestion ? "Input, still working" : (topStatus?.label ?? null),
1008+
statusLabel: hasAsyncQuestion ? `Input, ${topStatusLabel ?? "still working"}` : topStatusLabel,
10061009
projectDisplayName: props.projectDisplayName,
10071010
isActive: props.isActive,
10081011
});
@@ -1514,7 +1517,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: SidebarThreadRowP
15141517
{/* Not a live region: a collapsed sidebar is inert, so
15151518
BackgroundThreadAnnouncer and the open thread's
15161519
timeline speak status changes instead. */}
1517-
{hasAsyncQuestion ? null : topStatus.label}
1520+
{topStatusLabel}
15181521
{status === "working" ? (
15191522
<span aria-hidden>
15201523
<WorkingDuration startedAt={resolveWorkingStartedAt(thread)} />

0 commit comments

Comments
 (0)