Repository navigation
Commit 0d71f46
committed
fix(server): stop the metadata reader from piling up stuck reads, and time its answers
A file read cannot be cancelled once started and holds a libuv thread until the disk answers. While an attempt that ran out of budget is still pending, the reader now starts no new reads and leaves every command to git, so a stuck disk or share cannot exhaust the threadpool and stall unrelated file work. Answered commands now record their read time in t3_git_command_duration instead of almost zero.1 parent 35e22bd commit 0d71f46
4 files changed
Lines changed: 70 additions & 13 deletions
File tree
- apps/server/src
- observability
- vcs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
108 | 121 | | |
109 | 122 | | |
110 | 123 | | |
| |||
129 | 142 | | |
130 | 143 | | |
131 | 144 | | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | 145 | | |
138 | 146 | | |
139 | 147 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
509 | 510 | | |
510 | 511 | | |
511 | 512 | | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
512 | 539 | | |
513 | 540 | | |
514 | 541 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | 52 | | |
| |||
1294 | 1296 | | |
1295 | 1297 | | |
1296 | 1298 | | |
1297 | | - | |
| 1299 | + | |
1298 | 1300 | | |
1299 | 1301 | | |
1300 | 1302 | | |
1301 | 1303 | | |
1302 | 1304 | | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
1303 | 1309 | | |
1304 | 1310 | | |
1305 | 1311 | | |
1306 | 1312 | | |
1307 | 1313 | | |
1308 | | - | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
1309 | 1318 | | |
1310 | 1319 | | |
1311 | 1320 | | |
1312 | 1321 | | |
1313 | 1322 | | |
1314 | 1323 | | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
| 1328 | + | |
| 1329 | + | |
| 1330 | + | |
1315 | 1331 | | |
1316 | 1332 | | |
1317 | 1333 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
1008 | 1013 | | |
1009 | 1014 | | |
1010 | 1015 | | |
1011 | | - | |
| 1016 | + | |
| 1017 | + | |
1012 | 1018 | | |
1013 | 1019 | | |
1014 | 1020 | | |
| |||
1017 | 1023 | | |
1018 | 1024 | | |
1019 | 1025 | | |
1020 | | - | |
1021 | | - | |
| 1026 | + | |
| 1027 | + | |
1022 | 1028 | | |
1023 | | - | |
| 1029 | + | |
1024 | 1030 | | |
1025 | 1031 | | |
1026 | 1032 | | |
| |||
0 commit comments