Skip to content

Commit 0d4347a

Browse files
only21milclaude
andcommitted
test(server): delete the ACP registry and Grok replay temp directories
The ACP registry and Grok replay testkits made their replay status directory with makeTempDirectory, so each scenario left one behind. Use makeTempDirectoryScoped, and type layerFromAdaptersEffect the way Layer.effect behaves: the layer supplies Scope to the adapters effect. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 45aa377 commit 0d4347a

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ function layerAcpRegistryProviderAdapterRegistryReplay(
4545
const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
4646
const replayGate = options.replayGate;
4747
const replayDir = yield* fileSystem
48-
.makeTempDirectory({
48+
.makeTempDirectoryScoped({
4949
prefix: `t3-orchestration-v2-acp-registry-replay-${transcript.scenario}-`,
5050
})
5151
.pipe(Effect.orDie);

‎apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ function layerGrokProviderAdapterRegistryReplay(
4747
const continuationRequests = yield* ProviderContinuationRequests.ProviderContinuationRequests;
4848
const replayGate = options.replayGate;
4949
const replayDir = yield* fileSystem
50-
.makeTempDirectory({
50+
.makeTempDirectoryScoped({
5151
prefix: `t3-orchestration-v2-grok-replay-${transcript.scenario}-`,
5252
})
5353
.pipe(Effect.orDie);

‎apps/server/src/orchestration-v2/ProviderAdapterRegistry.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ export function layerFromAdapters(
188188

189189
export function layerFromAdaptersEffect<R, E>(
190190
adapters: Effect.Effect<ReadonlyArray<ProviderAdapter.ProviderAdapterV2["Service"]>, E, R>,
191-
): Layer.Layer<ProviderAdapterRegistryV2, E, R> {
191+
): Layer.Layer<ProviderAdapterRegistryV2, E, Exclude<R, Scope.Scope>> {
192192
return Layer.effect(
193193
ProviderAdapterRegistryV2,
194194
adapters.pipe(Effect.map((entries) => ProviderAdapterRegistryV2.of(makeRegistry(entries)))),

0 commit comments

Comments
 (0)