@@ -10,7 +10,12 @@ import { describe, expect, it } from "vite-plus/test";
1010import { createModelSelection } from "@t3tools/shared/model" ;
1111import { deriveEffectiveComposerModelState } from "./composerDraftStore" ;
1212import { getComposerProviderState } from "./components/chat/composerProviderState" ;
13- import { deriveProviderInstanceEntries , NO_PROVIDER_MODEL_SELECTION } from "./providerInstances" ;
13+ import { resolveComposerProviderSelection } from "./components/ChatView.logic" ;
14+ import {
15+ deriveProviderInstanceEntries ,
16+ NO_PROVIDER_MODEL_SELECTION ,
17+ sortProviderInstanceEntries ,
18+ } from "./providerInstances" ;
1419import {
1520 getAppModelOptionsForInstance ,
1621 resolveAppModelSelectionForInstance ,
@@ -780,3 +785,128 @@ describe("default model settings and new-thread composer parity", () => {
780785 } ,
781786 ) ;
782787} ) ;
788+
789+ describe ( "composer fallback to another instance of the same driver" , ( ) => {
790+ const claude = ProviderDriverKind . make ( "claudeAgent" ) ;
791+ const codex = ProviderDriverKind . make ( "codex" ) ;
792+ const disabled = ProviderInstanceId . make ( "claudeAgent" ) ;
793+ const fallback = ProviderInstanceId . make ( "claude_team" ) ;
794+ const effortModels : ServerProvider [ "models" ] = [
795+ {
796+ slug : "claude-opus-5-5" ,
797+ name : "Claude Opus 5.5" ,
798+ isCustom : false ,
799+ capabilities : {
800+ optionDescriptors : [
801+ {
802+ id : "effort" ,
803+ label : "Effort" ,
804+ type : "select" ,
805+ options : [ "medium" , "high" , "xhigh" ] . map ( ( id ) => ( {
806+ id,
807+ label : id ,
808+ isDefault : id === "medium" ,
809+ } ) ) ,
810+ } ,
811+ ] ,
812+ } ,
813+ } ,
814+ ] ;
815+ const providers : ReadonlyArray < ServerProvider > = [
816+ {
817+ ...provider ( { provider : claude , instanceId : disabled } ) ,
818+ enabled : false ,
819+ models : effortModels ,
820+ } ,
821+ { ...provider ( { provider : claude , instanceId : fallback } ) , models : effortModels } ,
822+ ] ;
823+ const picked = createModelSelection ( disabled , "claude-opus-5-5" , [
824+ { id : "effort" , value : "xhigh" } ,
825+ ] ) ;
826+
827+ // The same steps useComposerProviderModel takes, without the draft store.
828+ function composerFor ( input : {
829+ readonly providers : ReadonlyArray < ServerProvider > ;
830+ readonly draft ?: Parameters < typeof deriveEffectiveComposerModelState > [ 0 ] [ "draft" ] ;
831+ readonly threadModelSelection : ReturnType < typeof createModelSelection > ;
832+ } ) {
833+ const selection = resolveComposerProviderSelection ( {
834+ entries : sortProviderInstanceEntries ( deriveProviderInstanceEntries ( input . providers ) ) ,
835+ candidateInstanceIds : [ input . threadModelSelection . instanceId ] ,
836+ lockedProvider : null ,
837+ lockedInstanceId : undefined ,
838+ } ) ;
839+ const selectedInstanceId = selection . selectedProviderEntry ! . instanceId ;
840+ const selectedProvider = selection . selectedProviderEntry ! . driverKind ;
841+ const state = deriveEffectiveComposerModelState ( {
842+ draft : input . draft ?? null ,
843+ providers : input . providers ,
844+ selectedProvider,
845+ selectedInstanceId,
846+ requestedInstanceId : selection . requestedInstanceId ,
847+ threadModelSelection : input . threadModelSelection ,
848+ projectModelSelection : null ,
849+ settings : DEFAULT_UNIFIED_SETTINGS ,
850+ } ) ;
851+ const traits = getComposerProviderState ( {
852+ provider : selectedProvider ,
853+ model : state . selectedModel ,
854+ models : selection . selectedProviderEntry ! . models ,
855+ modelOptions : state . modelOptions ?. [ selectedInstanceId ] ,
856+ planModeEnabled : false ,
857+ } ) ;
858+ return { selectedInstanceId, state, traits } ;
859+ }
860+
861+ it ( "keeps the requested instance's effort on the fallback instance" , ( ) => {
862+ const { selectedInstanceId, state, traits } = composerFor ( {
863+ providers,
864+ threadModelSelection : picked ,
865+ } ) ;
866+
867+ expect ( selectedInstanceId ) . toBe ( fallback ) ;
868+ expect ( state . selectedModel ) . toBe ( "claude-opus-5-5" ) ;
869+ expect ( traits . promptEffort ) . toBe ( "xhigh" ) ;
870+ expect (
871+ createModelSelection ( fallback , state . selectedModel , traits . modelOptionsForDispatch ) ,
872+ ) . toEqual (
873+ createModelSelection ( fallback , "claude-opus-5-5" , [ { id : "effort" , value : "xhigh" } ] ) ,
874+ ) ;
875+ } ) ;
876+
877+ it ( "keeps options the fallback instance already has" , ( ) => {
878+ const { traits } = composerFor ( {
879+ providers,
880+ threadModelSelection : picked ,
881+ draft : {
882+ activeProvider : disabled ,
883+ modelSelectionByProvider : {
884+ [ disabled ] : picked ,
885+ [ fallback ] : createModelSelection ( fallback , "claude-opus-5-5" , [
886+ { id : "effort" , value : "high" } ,
887+ ] ) ,
888+ } ,
889+ } ,
890+ } ) ;
891+
892+ expect ( traits . promptEffort ) . toBe ( "high" ) ;
893+ } ) ;
894+
895+ it ( "does not carry options to another driver" , ( ) => {
896+ const codexOnly : ReadonlyArray < ServerProvider > = [
897+ {
898+ ...provider ( { provider : claude , instanceId : disabled } ) ,
899+ enabled : false ,
900+ models : effortModels ,
901+ } ,
902+ provider ( { provider : codex , instanceId : "codex" , models : [ "gpt-6-astra" ] } ) ,
903+ ] ;
904+ const { selectedInstanceId, state } = composerFor ( {
905+ providers : codexOnly ,
906+ threadModelSelection : picked ,
907+ } ) ;
908+
909+ expect ( selectedInstanceId ) . toBe ( ProviderInstanceId . make ( "codex" ) ) ;
910+ expect ( state . modelOptions ?. [ selectedInstanceId ] ) . toBeUndefined ( ) ;
911+ } ) ;
912+ } ) ;
0 commit comments