Skip to content

Commit 0c94e6d

Browse files
committed
refactor(server): simplify title retry coverage
1 parent 1e2fdef commit 0c94e6d

2 files changed

Lines changed: 18 additions & 62 deletions

File tree

‎apps/server/src/orchestration/Layers/ProviderCommandReactor.test.ts‎

Lines changed: 16 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -678,11 +678,24 @@ describe("ProviderCommandReactor", () => {
678678
}),
679679
);
680680

681-
it("generates a thread title on the first turn", async () => {
681+
it("retries thread title generation after a transient failure", async () => {
682682
const harness = await createHarness();
683683
const now = "2026-01-01T00:00:00.000Z";
684684
const seededTitle = "Please investigate reconnect failures after restar...";
685-
harness.generateThreadTitle.mockReturnValue(Effect.succeed({ title: "Generated title" }));
685+
let attempts = 0;
686+
harness.generateThreadTitle.mockReturnValue(
687+
Effect.suspend(() => {
688+
attempts += 1;
689+
return attempts === 1
690+
? Effect.fail(
691+
new TextGenerationError({
692+
operation: "generateThreadTitle",
693+
detail: "Claude CLI request timed out.",
694+
}),
695+
)
696+
: Effect.succeed({ title: "Generated title" });
697+
}),
698+
);
686699

687700
await Effect.runPromise(
688701
harness.engine.dispatch({
@@ -726,64 +739,9 @@ describe("ProviderCommandReactor", () => {
726739
const readModel = await harness.readModel();
727740
const thread = readModel.threads.find((entry) => entry.id === ThreadId.make("thread-1"));
728741
expect(thread?.title).toBe("Generated title");
742+
expect(attempts).toBe(2);
729743
});
730744

731-
effectIt.effect("retries thread title generation after a transient failure", () =>
732-
Effect.gen(function* () {
733-
const harness = yield* Effect.promise(() => createHarness());
734-
const now = "2026-01-01T00:00:00.000Z";
735-
const seededTitle = "Please investigate reconnect failures after restar...";
736-
let attempts = 0;
737-
harness.generateThreadTitle.mockReturnValue(
738-
Effect.suspend(() => {
739-
attempts += 1;
740-
return attempts === 1
741-
? Effect.fail(
742-
new TextGenerationError({
743-
operation: "generateThreadTitle",
744-
detail: "Claude CLI request timed out.",
745-
}),
746-
)
747-
: Effect.succeed({ title: "Generated title" });
748-
}),
749-
);
750-
751-
yield* harness.engine.dispatch({
752-
type: "thread.meta.update",
753-
commandId: CommandId.make("cmd-thread-title-retry-seed"),
754-
threadId: ThreadId.make("thread-1"),
755-
title: seededTitle,
756-
});
757-
758-
yield* harness.engine.dispatch({
759-
type: "thread.turn.start",
760-
commandId: CommandId.make("cmd-turn-start-title-retry"),
761-
threadId: ThreadId.make("thread-1"),
762-
message: {
763-
messageId: asMessageId("user-message-title-retry"),
764-
role: "user",
765-
text: "Please investigate reconnect failures after restarting the session.",
766-
attachments: [],
767-
},
768-
titleSeed: seededTitle,
769-
interactionMode: DEFAULT_PROVIDER_INTERACTION_MODE,
770-
runtimeMode: "approval-required",
771-
createdAt: now,
772-
});
773-
774-
yield* Effect.promise(() =>
775-
waitFor(async () => {
776-
const readModel = await harness.readModel();
777-
return (
778-
readModel.threads.find((entry) => entry.id === ThreadId.make("thread-1"))?.title ===
779-
"Generated title"
780-
);
781-
}),
782-
);
783-
expect(attempts).toBe(2);
784-
}),
785-
);
786-
787745
it("regenerates a thread title from the current conversation", async () => {
788746
const harness = await createHarness();
789747
const now = "2026-01-01T00:00:00.000Z";

‎apps/server/src/orchestration/Layers/ProviderCommandReactor.ts‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,6 @@ const HANDLED_TURN_START_KEY_MAX = 10_000;
9595
const HANDLED_TURN_START_KEY_TTL = Duration.minutes(30);
9696
const DEFAULT_RUNTIME_MODE: RuntimeMode = "full-access";
9797
const MAX_REGENERATION_ATTACHMENTS = 4;
98-
const THREAD_TITLE_GENERATION_RETRIES = 2;
99-
const THREAD_TITLE_RETRY_DELAY = Duration.seconds(2);
10098
const MAX_THREAD_TITLE_CONTEXT_CHARS = 8_000;
10199
const MAX_FIRST_USER_TITLE_CONTEXT_CHARS = 2_000;
102100
const THREAD_TITLE_CONTEXT_TRUNCATION_MARKER = "[Earlier content truncated]\n\n";
@@ -917,8 +915,8 @@ const make = Effect.gen(function* () {
917915
})
918916
.pipe(
919917
Effect.retry({
920-
times: THREAD_TITLE_GENERATION_RETRIES,
921-
schedule: Schedule.exponential(THREAD_TITLE_RETRY_DELAY),
918+
times: 2,
919+
schedule: Schedule.exponential("2 seconds"),
922920
}),
923921
);
924922
if (!generated) return;

0 commit comments

Comments
 (0)