Skip to content

Commit 0c13320

Browse files
committed
fix(web): pinned thread marker stays put when hovering the row
The pin marker sits directly left of the sidebar row's status slot, which swapped which state is in flow on hover: the time label left the flow and the Settle actions entered it. Every width change dragged the pin sideways. The slim row had the same problem in its Woke state. The card slot now stacks the status label and the hover actions in one grid cell, so it is always as wide as its wider state and only opacity swaps on hover. The slim row keeps its Woke action in flow at rest for the same reason. Made by Claude Opus 5.5 in Claude Code.
1 parent f90b77d commit 0c13320

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

‎apps/web/src/components/Sidebar.tsx‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1800,7 +1800,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
18001800
onClick={handleUnsnoozeClick}
18011801
className={cn(
18021802
"pointer-events-none absolute inset-y-0 right-0 -mr-1 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-1.5 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-hover/sidebar-row:pointer-events-auto group-hover/sidebar-row:opacity-100",
1803-
isWoke && "group-hover/sidebar-row:static",
1803+
isWoke && "static",
18041804
)}
18051805
>
18061806
<AlarmClockOffIcon className="mb-px size-3" />
@@ -1816,7 +1816,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
18161816
onClick={handleUnsettleClick}
18171817
className={cn(
18181818
"pointer-events-none absolute inset-y-0 right-0 -mr-1 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-1.5 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-hover/sidebar-row:pointer-events-auto group-hover/sidebar-row:opacity-100",
1819-
isWoke && "group-hover/sidebar-row:static",
1819+
isWoke && "static",
18201820
)}
18211821
/>
18221822
}
@@ -1832,7 +1832,7 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
18321832
onClick={handleSettleClick}
18331833
className={cn(
18341834
"pointer-events-none absolute inset-y-0 right-0 inline-flex cursor-pointer items-center gap-1 rounded-md bg-transparent px-2 text-xs text-muted-foreground opacity-0 transition-opacity hover:text-foreground focus-visible:pointer-events-auto focus-visible:opacity-100 group-hover/sidebar-row:pointer-events-auto group-hover/sidebar-row:opacity-100",
1835-
isWoke && "group-hover/sidebar-row:static",
1835+
isWoke && "static",
18361836
)}
18371837
>
18381838
<CheckIcon className="size-3" />
@@ -1900,24 +1900,23 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
19001900
<span className="flex-1" />
19011901
)}
19021902
{pinIndicator}
1903-
{/* The visible state owns this slot's width: status at rest,
1904-
actions on hover/keyboard focus or while the popover is open. Keeping
1905-
the hidden state out of flow lets the project label reclaim
1906-
space without either state overlapping it. */}
1903+
{/* Status and hover actions share one grid cell, so it is always as wide as
1904+
its wider state and only opacity swaps on hover. That keeps the pin marker
1905+
to its left from shifting; short labels reserve a little extra space. */}
19071906
{sortable?.isDragging ? (
19081907
dragDestination
19091908
) : (
1910-
<span className="group/sidebar-status-slot relative ml-auto flex h-5 min-w-8 shrink-0 items-stretch justify-end text-xs">
1909+
<span className="group/sidebar-status-slot ml-auto grid h-5 min-w-8 shrink-0 grid-flow-col items-stretch justify-end text-xs">
19111910
{/* Read-only status labels yield to the hover actions. Woke is
1912-
itself an action, so it stays pointer-enabled and visible
1913-
while the other controls appear beside it. */}
1911+
itself an action, so it keeps its own column and stays
1912+
pointer-enabled while the other controls appear beside it. */}
19141913
<span
19151914
className={cn(
19161915
isWokeStatus
19171916
? "pointer-events-auto"
1918-
: "pointer-events-none group-has-[:focus-visible]/sidebar-status-slot:absolute group-has-[:focus-visible]/sidebar-status-slot:right-0 group-has-[:focus-visible]/sidebar-status-slot:opacity-0 group-hover/sidebar-row:absolute group-hover/sidebar-row:right-0 group-hover/sidebar-row:opacity-0",
1917+
: "pointer-events-none [grid-area:1/1] group-has-[:focus-visible]/sidebar-status-slot:opacity-0 group-hover/sidebar-row:opacity-0",
19191918
"flex items-center self-center justify-self-end tabular-nums text-secondary-label transition-opacity",
1920-
snoozeMenuOpen && "pointer-events-none absolute right-0 opacity-0",
1919+
snoozeMenuOpen && "pointer-events-none opacity-0",
19211920
)}
19221921
>
19231922
{topStatus ? (
@@ -1982,8 +1981,9 @@ const SidebarThreadRow = memo(function SidebarThreadRow(props: {
19821981
// would keep the controls pinned over the status label
19831982
// once the pointer moves away (e.g. after a failed
19841983
// settle) instead of cross-fading back.
1985-
"pointer-events-none absolute inset-y-0 right-0 flex items-stretch opacity-0 transition-opacity has-[:focus-visible]:pointer-events-auto has-[:focus-visible]:static has-[:focus-visible]:opacity-100 group-hover/sidebar-row:pointer-events-auto group-hover/sidebar-row:static group-hover/sidebar-row:opacity-100",
1986-
snoozeMenuOpen && "pointer-events-auto static opacity-100",
1984+
"pointer-events-none flex items-stretch justify-self-end opacity-0 transition-opacity has-[:focus-visible]:pointer-events-auto has-[:focus-visible]:opacity-100 group-hover/sidebar-row:pointer-events-auto group-hover/sidebar-row:opacity-100",
1985+
!isWokeStatus && "[grid-area:1/1]",
1986+
snoozeMenuOpen && "pointer-events-auto opacity-100",
19871987
)}
19881988
>
19891989
{hasUnsentDraft ? (

0 commit comments

Comments
 (0)