Skip to content

Commit 0bc95fc

Browse files
authored
feat(dev): add startup profiling for cold-start diagnosis (#28566)
1 parent b50d8a1 commit 0bc95fc

11 files changed

Lines changed: 715 additions & 19 deletions

File tree

‎apps/server/src/bin.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@ if (
4040
// Windows desktop launches without stdin; attach before reading, except on fast paths using pipes.
4141
const { attachConsoleStdin } = await import("./cli/consoleStdin.ts");
4242
attachConsoleStdin();
43+
const importStart = performance.now();
4344
const { runCli } = await import("./binCli.ts");
45+
if (process.env.T3CODE_STARTUP_PROFILE_DIR) {
46+
performance.measure("server.import.binCli", { start: importStart });
47+
}
4448
runCli();
4549
}
4650
}

‎apps/server/src/persistence/Sqlite.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const layerSetup = Layer.effectDiscard(
4141
yield* sql`DELETE FROM sqlite_stat1;`;
4242
yield* sql`ANALYZE sqlite_schema;`;
4343
}
44-
}),
44+
}).pipe(Effect.withSpan("Sqlite.setup")),
4545
);
4646

4747
export const layerFromPath = Effect.fn("makeSqlitePersistenceLive")(function* (dbPath: string) {

‎apps/server/src/ws.test.ts‎

Lines changed: 50 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import {
2121
import * as Deferred from "effect/Deferred";
2222
import * as DateTime from "effect/DateTime";
2323
import * as Effect from "effect/Effect";
24+
import * as Fiber from "effect/Fiber";
2425
import * as Layer from "effect/Layer";
2526
import * as PubSub from "effect/PubSub";
2627
import * as Queue from "effect/Queue";
@@ -127,7 +128,7 @@ import {
127128
subscribeOrchestrationV2Shell,
128129
subscribeOrchestrationV2Thread,
129130
WS_RPC_SERVER_OPTIONS,
130-
withLateEditorConfig,
131+
withLateConfigDiscovery,
131132
} from "./ws.ts";
132133

133134
const snapshotConfig = (fields: Partial<ServerConfig>) =>
@@ -142,14 +143,15 @@ const settingsUpdated = (settings: object): ServerConfigStreamEvent => ({
142143
it.effect("resends late editors without rolling back updates already sent", () =>
143144
Effect.gen(function* () {
144145
const settingsSent = yield* Deferred.make<void>();
145-
const events = yield* withLateEditorConfig(
146+
const events = yield* withLateConfigDiscovery(
146147
snapshotConfig({ settings: { enableProviderUpdateChecks: true } as never }),
147148
Stream.make(settingsUpdated({ enableProviderUpdateChecks: false })),
148149
{
149150
resolveAvailableEditors: () => Effect.succeed(["file-manager"]),
150151
resolveFileManagerRevealKind: () =>
151152
Deferred.await(settingsSent).pipe(Effect.as("file-explorer" as const)),
152153
},
154+
{ resolveTargets: () => Effect.succeed([]) },
153155
).pipe(
154156
Stream.tap((event) =>
155157
event.type === "settingsUpdated" ? Deferred.succeed(settingsSent, undefined) : Effect.void,
@@ -169,24 +171,35 @@ it.effect("resends late editors without rolling back updates already sent", () =
169171
}),
170172
);
171173

172-
it.effect("resends a file manager reveal kind that missed the snapshot", () =>
174+
it.effect("resends a reveal kind and remote targets that outlast the snapshot timeout", () =>
173175
Effect.gen(function* () {
174-
const events = yield* withLateEditorConfig(
176+
const targets = [{ kind: "mdns" as const, host: "test.local" }];
177+
const finishDiscovery = yield* Deferred.make<typeof targets>();
178+
const collecting = yield* withLateConfigDiscovery(
175179
snapshotConfig({ availableEditors: ["file-manager"] }),
176180
Stream.empty,
177181
{
178182
resolveAvailableEditors: () => Effect.succeed(["file-manager"]),
179183
resolveFileManagerRevealKind: () => Effect.succeed("file-explorer"),
180184
},
181-
).pipe(Stream.runCollect);
185+
{ resolveTargets: () => Deferred.await(finishDiscovery) },
186+
).pipe(Stream.runCollect, Effect.forkScoped({ startImmediately: true }));
187+
yield* TestClock.adjust("6 seconds");
188+
yield* Deferred.succeed(finishDiscovery, targets);
189+
const events = yield* Fiber.join(collecting);
182190

183-
const [late] = Array.from(events);
184-
assert.equal(events.length, 1);
191+
const [late, remote] = Array.from(events);
192+
assert.equal(events.length, 2);
185193
assert.equal(late?.type, "snapshot");
186194
if (late?.type === "snapshot") {
187195
assert.equal(late.config.shellRevealInFileManagerKind, "file-explorer");
188196
}
189-
}),
197+
assert.equal(remote?.type, "snapshot");
198+
if (remote?.type === "snapshot") {
199+
assert.deepEqual(remote.config.remoteOpenTargets, targets);
200+
assert.equal(remote.config.shellRevealInFileManagerKind, "file-explorer");
201+
}
202+
}).pipe(Effect.scoped),
190203
);
191204

192205
it.effect("runs editor, remote open target and direct endpoint discovery side by side", () =>
@@ -600,9 +613,9 @@ const layerConfigSources = Layer.mergeAll(
600613
Layer.provideMerge(NodeServices.layer),
601614
);
602615

603-
it.effect(
604-
"preserves settings during discovery and keybindings during snapshot ACK at the config RPC boundary",
605-
() =>
616+
it.effect.each(["pending", "cached"] as const)(
617+
"%s remote discovery preserves initial config and updates through discovery and ACK",
618+
(discovery) =>
606619
Effect.gen(function* () {
607620
const keybindings = yield* Keybindings.Keybindings;
608621
const settings = yield* ServerSettings.ServerSettingsService;
@@ -617,6 +630,9 @@ it.effect(
617630
const initialKeybindings = (yield* keybindings.getSnapshot).keybindings;
618631
const discoveryStarted = yield* Deferred.make<void>();
619632
const finishDiscovery = yield* Deferred.make<void>();
633+
const remoteDiscoveryStarted = yield* Deferred.make<void>();
634+
const finishRemoteDiscovery = yield* Deferred.make<void>();
635+
const targets = [{ kind: "mdns" as const, host: "test.local" }];
620636
const responses = yield* Queue.unbounded<ServerConfigStreamEvent>();
621637
const configRpcServices = Layer.mergeAll(
622638
layerUnusedConfigRpcServices,
@@ -635,7 +651,13 @@ it.effect(
635651
}),
636652
Layer.mock(UsageLimitSources.UsageLimitSources)({ streamChanges: Stream.make([]) }),
637653
Layer.mock(RemoteOpenTargets.RemoteOpenTargets)({
638-
resolveTargets: () => Effect.succeed([]),
654+
resolveTargets: () =>
655+
Deferred.succeed(remoteDiscoveryStarted, undefined).pipe(
656+
Effect.andThen(
657+
discovery === "cached" ? Effect.void : Deferred.await(finishRemoteDiscovery),
658+
),
659+
Effect.as(targets),
660+
),
639661
}),
640662
Layer.mock(DirectEndpoints.DirectEndpoints)({ resolve: () => Effect.succeed([]) }),
641663
Layer.mock(ManagedProjectFolders.ManagedProjectFolders)({
@@ -710,12 +732,14 @@ it.effect(
710732
headers: Headers.empty,
711733
});
712734
yield* Deferred.await(discoveryStarted);
735+
assert.isTrue(yield* Deferred.isDone(remoteDiscoveryStarted));
713736

714737
const duringDiscovery = yield* settings.updateSettings({ defaultAutoPull: true });
715738
yield* Deferred.succeed(finishDiscovery, undefined);
716739
const snapshot = yield* Queue.take(responses);
717740
assert.equal(snapshot.type, "snapshot");
718741
if (snapshot.type !== "snapshot") return yield* Effect.die("Missing initial snapshot");
742+
assert.deepEqual(snapshot.config.remoteOpenTargets, discovery === "cached" ? targets : []);
719743
assert.isFalse(snapshot.config.settings.defaultAutoPull);
720744
assert.deepEqual(snapshot.config.keybindings, initialKeybindings);
721745
const duringAck = yield* keybindings.upsertKeybindingRule({
@@ -752,6 +776,20 @@ it.effect(
752776
}
753777
assert.isEmpty(expectedSettings);
754778
assert.isEmpty(expectedKeybindings);
779+
if (discovery === "pending") {
780+
yield* Deferred.await(remoteDiscoveryStarted);
781+
yield* Deferred.succeed(finishRemoteDiscovery, undefined);
782+
const resolved = yield* Queue.take(responses);
783+
assert.equal(resolved.type, "snapshot");
784+
if (resolved.type !== "snapshot") return yield* Effect.die("Missing remote targets");
785+
assert.deepEqual(resolved.config.remoteOpenTargets, targets);
786+
assert.deepEqual(
787+
resolved.config.settings,
788+
ServerSettings.redactServerSettingsForClient(latestSettings),
789+
);
790+
assert.deepEqual(resolved.config.keybindings, latestKeybindings);
791+
yield* acknowledge;
792+
}
755793
yield* server.write(0, { _tag: "Interrupt", requestId, interruptors: [] });
756794
}).pipe(
757795
Effect.provide(

‎apps/server/src/ws.ts‎

Lines changed: 39 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import * as DateTime from "effect/DateTime";
99
import * as Duration from "effect/Duration";
1010
import * as Base64 from "effect/encoding/Base64";
1111
import * as Effect from "effect/Effect";
12+
import * as Fiber from "effect/Fiber";
1213
import * as FileSystem from "effect/FileSystem";
1314
import * as Layer from "effect/Layer";
1415
import * as Option from "effect/Option";
@@ -313,10 +314,11 @@ const resolveEditorConfig = Effect.fn("ws.resolveEditorConfig")(function* <E, R>
313314
};
314315
});
315316

316-
export const withLateEditorConfig = <E, R>(
317+
export const withLateConfigDiscovery = <E, R>(
317318
config: ClientServerConfig,
318319
liveUpdates: Stream.Stream<ServerConfigStreamEvent, E, R>,
319320
launcher: EditorDiscovery,
321+
remoteOpenTargets: RemoteOpenTargets.RemoteOpenTargets["Service"],
320322
) => {
321323
const lateEditorConfig = Stream.fromEffect(launcher.resolveAvailableEditors()).pipe(
322324
Stream.filter(
@@ -337,7 +339,14 @@ export const withLateEditorConfig = <E, R>(
337339
Stream.map((editorConfig) => ({ type: "editorsResolved" as const, editorConfig })),
338340
);
339341

340-
return Stream.merge(liveUpdates, lateEditorConfig).pipe(
342+
const lateRemoteOpenTargets = Stream.fromEffect(remoteOpenTargets.resolveTargets()).pipe(
343+
Stream.filter(
344+
(targets) => JSON.stringify(targets) !== JSON.stringify(config.remoteOpenTargets ?? []),
345+
),
346+
Stream.map((targets) => ({ type: "remoteOpenTargetsResolved" as const, targets })),
347+
);
348+
349+
return Stream.merge(liveUpdates, Stream.merge(lateEditorConfig, lateRemoteOpenTargets)).pipe(
341350
Stream.mapAccum(
342351
(): ClientServerConfig => config,
343352
(current, event): readonly [ClientServerConfig, ReadonlyArray<ServerConfigStreamEvent>] => {
@@ -352,6 +361,10 @@ export const withLateEditorConfig = <E, R>(
352361
const next = { ...rest, ...event.editorConfig };
353362
return [next, [{ version: 1, type: "snapshot", config: next }]];
354363
}
364+
case "remoteOpenTargetsResolved": {
365+
const next = { ...current, remoteOpenTargets: event.targets };
366+
return [next, [{ version: 1, type: "snapshot", config: next }]];
367+
}
355368
case "keybindingsUpdated":
356369
return [{ ...current, ...event.payload }, [event]];
357370
case "providerStatuses":
@@ -1754,6 +1767,7 @@ export const layerWsRpc = (
17541767
const loadServerConfig = Effect.fn("ws.loadServerConfig")(function* (options: {
17551768
readonly usageLimitsCommand: boolean;
17561769
readonly workspaceSnapshotsOnDemand: boolean;
1770+
readonly deferRemoteOpenTargets: boolean;
17571771
}) {
17581772
const keybindingsConfig = yield* keybindings.loadConfigState;
17591773
const currentProviders = yield* providerRegistry.getProviders;
@@ -1773,7 +1787,9 @@ export const layerWsRpc = (
17731787
const discovery = yield* resolveOpenDiscoveryForConfig({
17741788
editors: externalLauncher.resolveAvailableEditors(),
17751789
fileManagerRevealKind: externalLauncher.resolveFileManagerRevealKind(),
1776-
remoteOpenTargets: remoteOpenTargets.resolveTargets(),
1790+
remoteOpenTargets: options.deferRemoteOpenTargets
1791+
? Effect.succeed([])
1792+
: remoteOpenTargets.resolveTargets(),
17771793
directEndpoints: directEndpoints.resolve(),
17781794
});
17791795

@@ -2203,7 +2219,11 @@ export const layerWsRpc = (
22032219
),
22042220
[WS_METHODS.serverProbe]: (_input) => Effect.succeed({}),
22052221
[WS_METHODS.serverGetConfig]: (_input) =>
2206-
loadServerConfig({ usageLimitsCommand: false, workspaceSnapshotsOnDemand: false }),
2222+
loadServerConfig({
2223+
usageLimitsCommand: false,
2224+
workspaceSnapshotsOnDemand: false,
2225+
deferRemoteOpenTargets: false,
2226+
}),
22072227
[WS_METHODS.serverSearchAcpRegistry]: (input) =>
22082228
acpRegistryCatalog
22092229
.search(input)
@@ -3126,9 +3146,13 @@ export const layerWsRpc = (
31263146
// Buffer changes through discovery and the initial snapshot's RPC ACK wait.
31273147
const keybindingsChanges = yield* keybindings.subscribeChanges;
31283148
const settingsChanges = yield* serverSettings.subscribeChanges;
3149+
const remoteTargets = yield* Effect.forkScoped(remoteOpenTargets.resolveTargets(), {
3150+
startImmediately: true,
3151+
});
31293152
const config = yield* loadServerConfig({
31303153
usageLimitsCommand,
31313154
workspaceSnapshotsOnDemand,
3155+
deferRemoteOpenTargets: true,
31323156
});
31333157
const keybindingsUpdates = keybindingsChanges.pipe(
31343158
Stream.map((event) => ({
@@ -3215,9 +3239,18 @@ export const layerWsRpc = (
32153239
),
32163240
);
32173241

3242+
const remoteResult = yield* Effect.sync(() => remoteTargets.pollUnsafe());
3243+
const initialConfig =
3244+
remoteResult?._tag === "Success"
3245+
? { ...config, remoteOpenTargets: remoteResult.value }
3246+
: config;
32183247
return Stream.concat(
3219-
rpcInitialItems([{ version: 1 as const, type: "snapshot" as const, config }]),
3220-
withLateEditorConfig(config, liveUpdates, externalLauncher),
3248+
rpcInitialItems([
3249+
{ version: 1 as const, type: "snapshot" as const, config: initialConfig },
3250+
]),
3251+
withLateConfigDiscovery(initialConfig, liveUpdates, externalLauncher, {
3252+
resolveTargets: () => Fiber.join(remoteTargets),
3253+
}),
32213254
);
32223255
}),
32233256
),

‎apps/web/scripts/warm-dep-cache.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,14 @@ import { optimizeDeps, resolveConfig } from "vite";
1010

1111
const webRoot = NodePath.dirname(NodePath.dirname(NodeURL.fileURLToPath(import.meta.url)));
1212

13+
const configStart = performance.now();
1314
const config = await resolveConfig({ root: webRoot, logLevel: "error" }, "serve");
15+
if (process.env.T3CODE_STARTUP_PROFILE_DIR) {
16+
performance.measure("web.warmDepCache.resolveConfig", { start: configStart });
17+
}
18+
const optimizeStart = performance.now();
1419
await optimizeDeps(config);
20+
if (process.env.T3CODE_STARTUP_PROFILE_DIR) {
21+
performance.measure("web.warmDepCache.optimizeDeps", { start: optimizeStart });
22+
}
1523
console.log("[warm-dep-cache] web dependency cache is warm");

‎docs/operations/development.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,34 @@ To add a scenario, point a `SCENARIOS` entry at a generic ACP replay fixture
8686
The agent replays session updates, permission requests, and questions. It drops session setup
8787
and vendor frames, so Grok and fx recordings lose their vendor-only behavior.
8888

89+
### Profiling dev startup
90+
91+
Run `vp run profile:startup` to capture the first 20 seconds of inherited Node processes under
92+
`.t3/startup-profiles/<timestamp>`. Workers that execute the preload get separate profiles.
93+
It starts the normal dev runner and accepts its flags.
94+
Stop it with Ctrl+C after the capture. Set `T3CODE_STARTUP_PROFILE_DIR` to choose another output
95+
directory. Profiling adds overhead, so compare readiness with an ordinary `vp run dev` run.
96+
97+
Open a `.cpuprofile` in Chrome DevTools' Performance panel for sampled function stacks and source
98+
lines. Each `.modules.json` is a Chrome trace containing timed module resolution, loading,
99+
synchronous subprocess calls, and startup measures. Per-file records include importer URLs,
100+
source loading, preparation, recursive dependency linking, and top-level evaluation. Preparation
101+
uses synchronous loader boundaries; linking includes dependencies, and CommonJS evaluation can
102+
include nested `require` calls. Some ESM/CommonJS interop reports a combined stage. `.process.json` records the process, Node version, and capture window.
103+
The server's nested Effect and SQL spans remain in `.t3/userdata/logs/server.trace.ndjson`.
104+
105+
The preload temporarily adds module-body timing markers and uses one automatic debugger pause
106+
to instrument the live Node loader. The launcher adds `--no-node-snapshot` to inherited
107+
`NODE_OPTIONS` because Node 26's snapshotted loader cannot accept that breakpoint. Include the
108+
same flag when using the preload directly. This disables Node's built-in startup snapshot,
109+
can change compilation-cache hits, and adds overhead.
110+
Treat per-file captures as diagnostic runs; use uninstrumented runs for baseline startup latency.
111+
The first entry module can compile before loader instrumentation is installed.
112+
113+
A fresh process still uses filesystem, Node compilation, provider, and Vite dependency caches.
114+
Measure a missing Vite dependency cache separately from a restart with an existing database.
115+
Neither the Vite ready message nor the HTTP listener proves that a browser has rendered the app.
116+
89117
### Sharing and remote debugging
90118

91119
`vp run dev --share` publishes the web port over the machine's tailnet and prints a pairing URL

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"scripts": {
66
"prepare": "vp config --no-agent",
77
"dev": "node scripts/dev-runner.ts dev",
8+
"profile:startup": "node scripts/profile-startup.mjs",
89
"dev:share": "node scripts/dev-runner.ts dev --share",
910
"dev:server": "node scripts/dev-runner.ts dev:server",
1011
"dev:web": "node scripts/dev-runner.ts dev:web",

‎packages/provider-cursor/src/server/sdk.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import * as NodeModule from "node:module";
33

44
// createRequire loads the disk-backed SDK and adjacent chunks even from a Node SEA executable.
55
const requireCursorSdk = NodeModule.createRequire(import.meta.url);
6+
const sdkImportStart = performance.now();
67
export const {
78
Agent,
89
AuthenticationError,
@@ -12,6 +13,13 @@ export const {
1213
CursorSdkError,
1314
InMemoryCredentialStore,
1415
} = requireCursorSdk("@cursor/sdk") as typeof import("@cursor/sdk");
16+
if (process.env.T3CODE_STARTUP_PROFILE_DIR) {
17+
performance.measure("provider.cursor.importSdk", { start: sdkImportStart });
18+
}
19+
const sqliteImportStart = performance.now();
1520
export const { SqliteLocalAgentStore } = requireCursorSdk(
1621
"@cursor/sdk/sqlite",
1722
) as typeof import("@cursor/sdk/sqlite");
23+
if (process.env.T3CODE_STARTUP_PROFILE_DIR) {
24+
performance.measure("provider.cursor.importSqliteStore", { start: sqliteImportStart });
25+
}

0 commit comments

Comments
 (0)