Skip to content

Commit 0906dd5

Browse files
Pysephclaude
andcommitted
test(server): wait for the external edit to be published before restoring the save
The self-write test waited for the next read of settings.json, which could be a late reload of the saved file instead of the edit's reload. Collect changes from before the save and wait for the edit itself to be published before writing the saved contents back. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 365b9a1 commit 0906dd5

1 file changed

Lines changed: 15 additions & 5 deletions

File tree

‎apps/server/src/serverSettings.test.ts‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,19 @@ it.layer(NodeServices.layer)("server settings", (it) => {
401401
yield* service.start;
402402
yield* Queue.clear(reads);
403403
const changes = yield* service.subscribeChanges;
404+
const editPublished = yield* Deferred.make<void>();
405+
const published = yield* Effect.forkChild(
406+
changes.pipe(
407+
Stream.tap((settings) =>
408+
settings.defaultProjectScripts.length > 0
409+
? Deferred.succeed(editPublished, undefined)
410+
: Effect.void,
411+
),
412+
Stream.take(3),
413+
Stream.runCollect,
414+
),
415+
{ startImmediately: true },
416+
);
404417

405418
yield* service.updateSettings({ responseStreamingMode: "turn" });
406419
const savedContents = yield* fs.readFileString(config.settingsPath);
@@ -411,14 +424,11 @@ it.layer(NodeServices.layer)("server settings", (it) => {
411424
config.settingsPath,
412425
JSON.stringify({ responseStreamingMode: "turn", defaultProjectScripts: [usageScript] }),
413426
);
414-
yield* Queue.take(reads).pipe(Effect.timeout("2 seconds"));
415-
yield* service.withSettingsSnapshot(() => Effect.void);
427+
yield* Deferred.await(editPublished).pipe(Effect.timeout("2 seconds"));
416428
// Once another edit is published, the saved contents are an edit of their own.
417429
yield* fs.writeFileString(config.settingsPath, savedContents);
418430

419-
const [saved, edited, restored] = yield* changes.pipe(
420-
Stream.take(3),
421-
Stream.runCollect,
431+
const [saved, edited, restored] = yield* Fiber.join(published).pipe(
422432
Effect.timeout("2 seconds"),
423433
);
424434
assert.equal(saved?.responseStreamingMode, "turn");

0 commit comments

Comments
 (0)