@@ -6,12 +6,7 @@ import { expect, it, vi } from "vite-plus/test";
66
77const state = vi . hoisted ( ( ) => ( {
88 settings : { } as typeof DEFAULT_SERVER_SETTINGS ,
9- targets : [ ] as {
10- environmentId : string ;
11- settings : typeof DEFAULT_SERVER_SETTINGS ;
12- } [ ] ,
139 run : vi . fn ( ) ,
14- update : vi . fn ( ) ,
1510 report : null as StorageCleanupReport | null ,
1611} ) ) ;
1712
@@ -39,11 +34,11 @@ vi.mock(import("../../state/use-atom-command"), async (original) => ({
3934vi . mock ( import ( "./SettingsScopeContext" ) , async ( original ) => ( {
4035 ...( await original ( ) ) ,
4136 useSettingsScope : ( ( ) => {
42- const environments = state . targets . map ( ( { environmentId , settings } ) => ( {
43- environmentId,
44- label : environmentId ,
37+ const environment = {
38+ environmentId : "env" ,
39+ label : "Build workstation" ,
4540 serverConfig : {
46- settings,
41+ settings : state . settings ,
4742 environment : {
4843 capabilities : {
4944 storageCleanup : true ,
@@ -52,34 +47,30 @@ vi.mock(import("./SettingsScopeContext"), async (original) => ({
5247 } ,
5348 } ,
5449 } ,
55- } ) ) ;
50+ } ;
5651 return {
57- scope : { kind : "all" } ,
58- environments,
59- connectedEnvironments : environments ,
60- targets : state . targets . map ( ( { environmentId, settings } ) => ( {
61- environmentId,
62- settings,
63- } ) ) ,
64- target : state . targets [ 0 ] ? { settings : state . targets [ 0 ] . settings } : null ,
52+ scope : { kind : "environment" } ,
53+ environments : [ environment ] ,
54+ connectedEnvironments : [ environment ] ,
55+ targets : [ ] ,
56+ target : null ,
6557 } ;
6658 } ) as never ,
6759} ) ) ;
6860vi . mock ( import ( "./useScopedSettings" ) , async ( original ) => ( {
6961 ...( await original ( ) ) ,
7062 useScopedSettings : ( ( ) => state . settings ) as never ,
7163 useScopedSettingsMixed : ( ) => false ,
72- useUpdateScopedSettings : ( ) => state . update ,
64+ useUpdateScopedSettings : ( ) => vi . fn ( ) ,
7365 useClearScopedSettings : ( ) => vi . fn ( ) ,
7466} ) ) ;
7567vi . mock ( import ( "./settingsLayout" ) , async ( original ) => ( {
7668 ...( await original ( ) ) ,
7769 SettingsPageContainer : ( ( { children } : { children : ReactNode } ) => children ) as never ,
78- SettingsRow : ( { title, description, status , control, children } ) => (
70+ SettingsRow : ( { title, description, control, children } ) => (
7971 < div >
8072 < h3 > { title } </ h3 >
8173 { description }
82- { status }
8374 { control }
8475 { children }
8576 </ div >
@@ -110,17 +101,6 @@ function setup() {
110101 } ;
111102 state . report = null ;
112103 state . run . mockReset ( ) ;
113- state . targets = [
114- { environmentId : "machine-a" , settings : state . settings } ,
115- {
116- environmentId : "machine-b" ,
117- settings : {
118- ...state . settings ,
119- storageCleanup : { ...state . settings . storageCleanup } ,
120- } ,
121- } ,
122- ] ;
123- state . update . mockReset ( ) . mockResolvedValue ( undefined ) ;
124104}
125105
126106const panel = ( ) => (
@@ -142,155 +122,3 @@ it("keeps cleanup disabled when settled retention and all other rules are off",
142122 await act ( async ( ) => button . click ( ) ) ;
143123 expect ( state . run ) . not . toHaveBeenCalled ( ) ;
144124} ) ;
145-
146- function setArtifactRetention ( machineIndex : number , value : number | null ) {
147- const target = state . targets [ machineIndex ] ! ;
148- target . settings = {
149- ...target . settings ,
150- storageCleanup : { ...target . settings . storageCleanup , browserArtifactsAfterDays : value } ,
151- } ;
152- if ( machineIndex === 0 ) state . settings = target . settings ;
153- }
154-
155- function retentionSwitch ( container : HTMLElement ) {
156- return Array . from ( container . querySelectorAll < HTMLButtonElement > ( '[role="switch"]' ) ) . find (
157- ( control ) => control . getAttribute ( "aria-label" ) === "Delete old browser artifacts" ,
158- ) ! ;
159- }
160-
161- function ruleIsMixed ( container : HTMLElement , title : string ) {
162- return Array . from ( container . querySelectorAll ( "h3" ) )
163- . find ( ( heading ) => heading . textContent === title )
164- ?. parentElement ?. textContent ?. includes ( "Mixed across selected machines" ) ;
165- }
166-
167- const artifactIsMixed = ( container : HTMLElement ) =>
168- ruleIsMixed ( container , "Delete old browser artifacts" ) ;
169- const logsAreMixed = ( container : HTMLElement ) => ruleIsMixed ( container , "Delete old rotated logs" ) ;
170-
171- function deferredSave ( ) {
172- let resolve ! : ( ) => void ;
173- const promise = new Promise < void > ( ( done ) => {
174- resolve = done ;
175- } ) ;
176- return { promise, resolve } ;
177- }
178-
179- function stepArtifacts ( container : HTMLElement , direction : "Increase" | "Decrease" ) {
180- container
181- . querySelector < HTMLButtonElement > ( `[aria-label="${ direction } Delete old browser artifacts"]` ) !
182- . click ( ) ;
183- }
184-
185- it ( "does not add a mixed warning before every machine projects a completed save" , async ( ) => {
186- setup ( ) ;
187- setArtifactRetention ( 0 , 9 ) ;
188- setArtifactRetention ( 1 , 9 ) ;
189- const save = deferredSave ( ) ;
190- state . update . mockReturnValue ( save . promise ) ;
191- await using screen = await render ( panel ( ) ) ;
192- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
193-
194- await act ( async ( ) => stepArtifacts ( screen . container , "Increase" ) ) ;
195- setArtifactRetention ( 0 , 10 ) ;
196- const machineB = state . targets [ 1 ] ! ;
197- machineB . settings = {
198- ...machineB . settings ,
199- storageCleanup : { ...machineB . settings . storageCleanup , logsAfterDays : 30 } ,
200- } ;
201- await act ( async ( ) => save . resolve ( ) ) ;
202- await screen . rerender ( panel ( ) ) ;
203- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
204- expect ( logsAreMixed ( screen . container ) ) . toBe ( true ) ;
205-
206- setArtifactRetention ( 1 , 10 ) ;
207- await screen . rerender ( panel ( ) ) ;
208- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
209-
210- setArtifactRetention ( 1 , 11 ) ;
211- await screen . rerender ( panel ( ) ) ;
212- expect ( artifactIsMixed ( screen . container ) ) . toBe ( true ) ;
213- } ) ;
214-
215- it . each ( [ 14 , 30 ] ) (
216- "shows genuine differences after a partial save fails with a second value of %i" ,
217- async ( secondValue ) => {
218- setup ( ) ;
219- setArtifactRetention ( 0 , 14 ) ;
220- setArtifactRetention ( 1 , secondValue ) ;
221- const save = deferredSave ( ) ;
222- let onFailed ! : ( ) => void ;
223- state . update . mockImplementation ( ( _patch , options ) => {
224- onFailed = options . onFailed ;
225- return save . promise ;
226- } ) ;
227- await using screen = await render ( panel ( ) ) ;
228- expect ( artifactIsMixed ( screen . container ) ) . toBe ( secondValue !== 14 ) ;
229-
230- await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
231- setArtifactRetention ( 0 , null ) ;
232- await screen . rerender ( panel ( ) ) ;
233- expect ( artifactIsMixed ( screen . container ) ) . toBe ( secondValue !== 14 ) ;
234-
235- await act ( async ( ) => {
236- onFailed ( ) ;
237- save . resolve ( ) ;
238- } ) ;
239- expect ( artifactIsMixed ( screen . container ) ) . toBe ( true ) ;
240- } ,
241- ) ;
242-
243- it ( "keeps a reversed edit pending and ignores a superseded save failure" , async ( ) => {
244- setup ( ) ;
245- setArtifactRetention ( 0 , 9 ) ;
246- setArtifactRetention ( 1 , 9 ) ;
247- const first = deferredSave ( ) ;
248- const second = deferredSave ( ) ;
249- let failFirst ! : ( ) => void ;
250- state . update
251- . mockImplementationOnce ( ( _patch , options ) => {
252- failFirst = options . onFailed ;
253- return first . promise ;
254- } )
255- . mockReturnValueOnce ( second . promise ) ;
256- await using screen = await render ( panel ( ) ) ;
257- await act ( async ( ) => stepArtifacts ( screen . container , "Increase" ) ) ;
258- await act ( async ( ) => stepArtifacts ( screen . container , "Decrease" ) ) ;
259-
260- setArtifactRetention ( 0 , 10 ) ;
261- await screen . rerender ( panel ( ) ) ;
262- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
263- await act ( async ( ) => {
264- failFirst ( ) ;
265- first . resolve ( ) ;
266- } ) ;
267- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
268-
269- setArtifactRetention ( 0 , 9 ) ;
270- setArtifactRetention ( 1 , 10 ) ;
271- await act ( async ( ) => second . resolve ( ) ) ;
272- await screen . rerender ( panel ( ) ) ;
273- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
274- setArtifactRetention ( 1 , 9 ) ;
275- await screen . rerender ( panel ( ) ) ;
276- expect ( artifactIsMixed ( screen . container ) ) . toBe ( false ) ;
277-
278- setArtifactRetention ( 1 , 12 ) ;
279- await screen . rerender ( panel ( ) ) ;
280- expect ( artifactIsMixed ( screen . container ) ) . toBe ( true ) ;
281- } ) ;
282-
283- it ( "uses the newly selected machines rather than an older pending edit" , async ( ) => {
284- setup ( ) ;
285- const save = deferredSave ( ) ;
286- state . update . mockReturnValue ( save . promise ) ;
287- await using screen = await render ( panel ( ) ) ;
288- await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
289- setArtifactRetention ( 0 , 8 ) ;
290- state . targets [ 1 ] = { ...state . targets [ 1 ] ! , environmentId : "machine-c" } ;
291- setArtifactRetention ( 1 , 30 ) ;
292- await screen . rerender ( panel ( ) ) ;
293- expect ( artifactIsMixed ( screen . container ) ) . toBe ( true ) ;
294- await act ( async ( ) => save . resolve ( ) ) ;
295- expect ( artifactIsMixed ( screen . container ) ) . toBe ( true ) ;
296- } ) ;
0 commit comments