|
27 | 27 | outputs: |
28 | 28 | typecheck: ${{ steps.detect.outputs.typecheck }} |
29 | 29 | build: ${{ steps.detect.outputs.build }} |
| 30 | + desktop_launch: ${{ steps.detect.outputs.desktop_launch }} |
30 | 31 | test: ${{ steps.detect.outputs.test }} |
31 | 32 | test_packages: ${{ steps.detect.outputs.test_packages }} |
32 | 33 | test_web: ${{ steps.detect.outputs.test_web }} |
@@ -135,13 +136,14 @@ jobs: |
135 | 136 | if: needs.changes.outputs.build != 'false' |
136 | 137 |
|
137 | 138 | # Runs in the background while Vite+ installs; the step before the build waits for it. |
| 139 | + # Xvfb is for the desktop launch check below. |
138 | 140 | - name: Start installing browser secret helper build libraries |
139 | 141 | if: needs.changes.outputs.build != 'false' |
140 | 142 | run: | |
141 | 143 | sudo sed -i 's|http://|https://|g' /etc/apt/blacksmith-ubuntu-mirrors.txt /etc/apt/sources.list.d/ubuntu.sources |
142 | 144 | ( |
143 | 145 | set +e |
144 | | - sudo apt-get update && sudo apt-get install -y libsecret-1-dev pkg-config |
| 146 | + sudo apt-get update && sudo apt-get install -y libsecret-1-dev pkg-config xvfb |
145 | 147 | echo "$?" > "$RUNNER_TEMP/apt-status" |
146 | 148 | ) > "$RUNNER_TEMP/apt.log" 2>&1 < /dev/null & |
147 | 149 |
|
@@ -192,6 +194,25 @@ jobs: |
192 | 194 | if: ${{ !cancelled() && steps.build.outcome == 'success' }} |
193 | 195 | run: node apps/desktop/scripts/verify-preload-bundle.mjs |
194 | 196 |
|
| 197 | + # The release launch check, run unpackaged against the same old-state fixture, for |
| 198 | + # startup and sidebar changes. Packaging and signing stay release-only. |
| 199 | + - name: Open the seeded thread in the built desktop app |
| 200 | + id: desktop_launch |
| 201 | + if: ${{ !cancelled() && steps.build.outcome == 'success' && needs.changes.outputs.desktop_launch != 'false' }} |
| 202 | + timeout-minutes: 4 |
| 203 | + run: | |
| 204 | + electron=$(node -p "require('./apps/desktop/node_modules/electron')") |
| 205 | + xvfb-run -a node scripts/smoke-desktop-app.ts --executable "$electron" --app apps/desktop \ |
| 206 | + --artifacts-dir "$RUNNER_TEMP/desktop-launch-check" |
| 207 | +
|
| 208 | + - name: Upload desktop launch check |
| 209 | + if: ${{ failure() && steps.desktop_launch.outcome == 'failure' }} |
| 210 | + uses: actions/upload-artifact@v7 |
| 211 | + with: |
| 212 | + name: desktop-launch-check |
| 213 | + path: ${{ runner.temp }}/desktop-launch-check |
| 214 | + if-no-files-found: ignore |
| 215 | + |
195 | 216 | # Browser tests run source modules; this boots the production chunk graph. The |
196 | 217 | # desktop build above already produced apps/web/dist, and the client waits about |
197 | 218 | # 15s for a session that never comes, so this runs here instead of in Test Web, |
@@ -622,7 +643,7 @@ jobs: |
622 | 643 | # not needed. Gates are keyed by job name, except merged Build and the |
623 | 644 | # macOS lint. |
624 | 645 | echo "$RESULTS" | jq -e '.changes.outputs as $gates |
625 | | - | {build: ["build", "typecheck"], mobile_native_static_analysis: ["mobile_native"]} as $renamed |
| 646 | + | {build: ["build", "typecheck", "desktop_launch"], mobile_native_static_analysis: ["mobile_native"]} as $renamed |
626 | 647 | | all(to_entries[]; |
627 | 648 | .value.result == "success" |
628 | 649 | or (.value.result == "skipped" |
|
0 commit comments