Skip to content

Commit 079fe96

Browse files
perf(web): scheduled task settings compile without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit 079fe96

2 files changed

Lines changed: 41 additions & 50 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/components/settings/ScheduledTasksSettings.tsx",
99100
] as const;

‎apps/web/src/components/settings/ScheduledTasksSettings.tsx‎

Lines changed: 40 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
PlusIcon,
1313
Trash2Icon,
1414
} from "lucide-react";
15-
import { type ReactNode, useCallback, useEffect, useMemo, useRef, useState } from "react";
15+
import { type ReactNode, useEffect, useRef, useState } from "react";
1616
import type {
1717
EnvironmentId,
1818
ModelSelection,
@@ -250,9 +250,9 @@ export function ScheduledTasksSettings(target: {
250250
environmentId: EnvironmentId;
251251
task: ScheduledTask | null;
252252
} | null>(null);
253-
const openForEdit = useCallback((environmentId: EnvironmentId, task: ScheduledTask) => {
253+
const openForEdit = (environmentId: EnvironmentId, task: ScheduledTask) => {
254254
setEditor({ environmentId, task });
255-
}, []);
255+
};
256256
const defaultEnvironment = environment ?? connectedEnvironments[0];
257257
const canCreate = useAtomValue(
258258
serverEnvironment.upsertScheduledTask.permissionAtom(defaultEnvironment?.environmentId ?? null),
@@ -340,32 +340,28 @@ function ScheduledTaskEnvironmentList({
340340
}) {
341341
const { scope, environments } = useSettingsScope();
342342
const states = useAtomValue(
343-
useMemo(
344-
() =>
345-
Atom.make((get) =>
346-
environments.map((environment) => {
347-
const connected =
348-
environment.connection.phase === "connected" && environment.serverConfig !== null;
349-
const query = connected
350-
? get(
351-
serverEnvironment.scheduledTasksLive({
352-
environmentId: environment.environmentId,
353-
input: {},
354-
}),
355-
)
356-
: null;
357-
const data = query === null ? null : Option.getOrNull(AsyncResult.value(query));
358-
return {
359-
environment,
360-
connected,
361-
tasks: data?.tasks.filter((task) =>
362-
matchesScheduledTaskScope(scope, environment.environmentId, task.projectId),
363-
),
364-
error: query?._tag === "Failure" ? formatEnvironmentQueryError(query.cause) : null,
365-
};
366-
}),
367-
),
368-
[environments, scope],
343+
Atom.make((get) =>
344+
environments.map((environment) => {
345+
const connected =
346+
environment.connection.phase === "connected" && environment.serverConfig !== null;
347+
const query = connected
348+
? get(
349+
serverEnvironment.scheduledTasksLive({
350+
environmentId: environment.environmentId,
351+
input: {},
352+
}),
353+
)
354+
: null;
355+
const data = query === null ? null : Option.getOrNull(AsyncResult.value(query));
356+
return {
357+
environment,
358+
connected,
359+
tasks: data?.tasks.filter((task) =>
360+
matchesScheduledTaskScope(scope, environment.environmentId, task.projectId),
361+
),
362+
error: query?._tag === "Failure" ? formatEnvironmentQueryError(query.cause) : null,
363+
};
364+
}),
369365
),
370366
);
371367
const linkedState = states.find((state) => state.environment.environmentId === environmentId);
@@ -937,14 +933,10 @@ function ScheduledTaskEditorDialog({
937933
connected ? serverEnvironment.scheduledTasksLive({ environmentId, input: {} }) : null,
938934
);
939935
const allProjects = useProjects();
940-
const projects = useMemo(
941-
() =>
942-
allProjects.filter(
943-
(project) =>
944-
project.environmentId === environmentId &&
945-
matchesScheduledTaskScope(scope, environmentId, project.id),
946-
),
947-
[allProjects, environmentId, scope],
936+
const projects = allProjects.filter(
937+
(project) =>
938+
project.environmentId === environmentId &&
939+
matchesScheduledTaskScope(scope, environmentId, project.id),
948940
);
949941
const settings = useEnvironmentSettings(environmentId);
950942
const providers =
@@ -969,16 +961,12 @@ function ScheduledTaskEditorDialog({
969961
: task;
970962
const selectedProjectId = draft.projectId || projects[0]?.id || "";
971963
const selectedProject = projects.find((project) => project.id === selectedProjectId);
972-
const instanceEntries = useMemo(
973-
() =>
974-
sortProviderInstanceEntries(
975-
applyProviderInstanceSettings(
976-
deriveProviderInstanceEntries(providers),
977-
settings,
978-
selectedProject?.id ?? null,
979-
),
980-
),
981-
[providers, settings, selectedProject?.id],
964+
const instanceEntries = sortProviderInstanceEntries(
965+
applyProviderInstanceSettings(
966+
deriveProviderInstanceEntries(providers),
967+
settings,
968+
selectedProject?.id ?? null,
969+
),
982970
);
983971

984972
const firstInstance = instanceEntries[0];
@@ -991,9 +979,11 @@ function ScheduledTaskEditorDialog({
991979
const activeInstanceId =
992980
activeSelection?.instanceId ?? firstInstance?.instanceId ?? ("" as ProviderInstanceId);
993981
const activeModel = activeSelection?.model ?? "";
994-
const modelOptionsByInstance = useMemo(
995-
() => getCustomModelOptionsByInstance(settings, providers, activeInstanceId, activeModel),
996-
[settings, providers, activeInstanceId, activeModel],
982+
const modelOptionsByInstance = getCustomModelOptionsByInstance(
983+
settings,
984+
providers,
985+
activeInstanceId,
986+
activeModel,
997987
);
998988

999989
const reportFailure = (title: string, error: unknown) => {

0 commit comments

Comments
 (0)