Skip to content

Commit 06b62fb

Browse files
fix(desktop): nightly update notes no longer list the Full Changelog link as a change (#24358)
Co-authored-by: maria-rcks <[email protected]>
1 parent 88fec6f commit 06b62fb

2 files changed

Lines changed: 44 additions & 1 deletion

File tree

‎apps/desktop/src/updates/releaseNotes.test.ts‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,4 +232,45 @@ describe("normalizeDesktopUpdateReleaseNotes", () => {
232232
omittedReleaseCount: 0,
233233
});
234234
});
235+
236+
it("ignores the Full Changelog paragraph that ends GitHub's generated notes", () => {
237+
const fullChangelog = (from: string, to: string) =>
238+
`<p><strong>Full Changelog</strong>: <a class="commit-link" href="https://github.com/pingdotgg/t3code/compare/v${from}...v${to}"><tt>v${from}...v${to}</tt></a></p>`;
239+
const result = normalizeDesktopUpdateReleaseNotes(
240+
[
241+
{
242+
version: "0.1.3-nightly.20261024.3604",
243+
note: fullChangelog("0.1.3-nightly.20261023.3592", "0.1.3-nightly.20261024.3604"),
244+
},
245+
{
246+
version: "0.1.3-nightly.20261023.3592",
247+
note:
248+
"<h2>What's Changed</h2>\n<ul>\n" +
249+
'<li>fix(web): A by <a href="https://github.com/a">@a</a> in <a href="https://github.com/pingdotgg/t3code/pull/1">#1</a></li>\n' +
250+
'<li>fix(web): B by <a href="https://github.com/b">@b</a> in <a href="https://github.com/pingdotgg/t3code/pull/2">#2</a></li>\n' +
251+
"<li>Full Changelog: links open in the browser in #3</li>\n" +
252+
"</ul>\n" +
253+
fullChangelog("0.1.3-nightly.20261023.3579", "0.1.3-nightly.20261023.3592"),
254+
},
255+
],
256+
"0.1.3-nightly.20261024.3604",
257+
"nightly",
258+
);
259+
260+
expect(result).toEqual({
261+
releaseNotes: [
262+
{
263+
version: "0.1.3-nightly.20261023.3592",
264+
items: [
265+
"Full Changelog: links open in the browser in #3",
266+
"fix(web): B by @b in #2",
267+
"fix(web): A by @a in #1",
268+
],
269+
releasedAt: "2026-10-23",
270+
totalItems: 3,
271+
},
272+
],
273+
omittedReleaseCount: 0,
274+
});
275+
});
235276
});

‎apps/desktop/src/updates/releaseNotes.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ function isIgnoredReleaseNoteLine(line: string): boolean {
8686
normalized === "what's changed" ||
8787
normalized === "whats changed" ||
8888
normalized.startsWith("compare: ") ||
89-
normalized.includes("/compare/")
89+
normalized.includes("/compare/") ||
90+
// The feed's HTML footer loses its compare URL to stripMarkup, leaving only the range.
91+
/^full changelog: \S+\.\.\.\S+$/.test(normalized)
9092
);
9193
}
9294

0 commit comments

Comments
 (0)