Repository navigation
Commit 0604de5
committed
fix(web): set allowpopups before the preview webview attaches
Electron reads allowpopups when the guest attaches. The attribute was set from
the ref callback, which runs after the element is in the DOM, so every preview
guest attached with popups disabled and Electron blocked window.open before the
window-open handler ran.
Verified in a running desktop build: will-attach-webview reported
allowpopups: false before this change and true after.1 parent 7c5b69a commit 0604de5
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
96 | 95 | | |
97 | 96 | | |
98 | 97 | | |
| |||
259 | 258 | | |
260 | 259 | | |
261 | 260 | | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
262 | 265 | | |
263 | 266 | | |
264 | 267 | | |
| |||
0 commit comments