Repository navigation
Commit 05b84f7
refactor(mobile): pull request list, filters and viewed files without synchronizing effects
The mobile pull request screens kept state in step with effects: the list
copied its query head into the pages atom and its stats answers into the
stats atom, tracked the active scope in a layout effect to abort loads, the
Android filter menu was published from the list to the header through a
layout effect, viewed-file presses were reconciled with server reads in four
effects over refs, and the reviewer list scrolled to the top whenever its
candidates changed.
- usePullRequestList: the head is merged in the sources atom's read; stats
answers land through the listStats query's onAnswer (new hook in
client-runtime); page loads and refreshes are per-scope Atom.fn families,
so leaving a scope interrupts them. 3 effects -> 0.
- PullRequestsScreen builds the filters and hands the header menu to a
renderFrame prop, so the Android toolbar reads it in the same render.
PullRequestFilterMenuContext is deleted. 1 effect -> 0.
- usePullRequestFilesViewed keeps presses (version, read-at-write) in state
and derives the overlay in render (pullRequestFilesViewed.ts, tested).
The head-change refresh moves to the detail query's onAnswer. 4 -> 0.
- PullRequestReviewersScreen scrolls to the top from the search handler.
1 -> 0.
- PullRequestToolbar.android drops its navigation-state subscription; the
back handler already checks focus when pressed. Its effect stays: it
registers a native listener for as long as search is open.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent 278588a commit 05b84f7
13 files changed
Lines changed: 480 additions & 392 deletions
File tree
- apps/mobile/src
- features
- pull-requests
- workspace
- state
- packages/client-runtime/src/state
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
62 | 61 | | |
63 | 62 | | |
64 | 63 | | |
65 | | - | |
66 | | - | |
67 | | - | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
| |||
280 | 288 | | |
281 | 289 | | |
282 | 290 | | |
283 | | - | |
| 291 | + | |
284 | 292 | | |
285 | 293 | | |
286 | 294 | | |
| |||
296 | 304 | | |
297 | 305 | | |
298 | 306 | | |
299 | | - | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
300 | 336 | | |
301 | 337 | | |
302 | 338 | | |
| |||
319 | 355 | | |
320 | 356 | | |
321 | 357 | | |
322 | | - | |
| 358 | + | |
323 | 359 | | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
| 360 | + | |
328 | 361 | | |
329 | | - | |
| 362 | + | |
330 | 363 | | |
331 | 364 | | |
332 | 365 | | |
333 | 366 | | |
334 | | - | |
335 | | - | |
| 367 | + | |
| 368 | + | |
336 | 369 | | |
337 | | - | |
| 370 | + | |
338 | 371 | | |
339 | 372 | | |
340 | 373 | | |
341 | | - | |
342 | | - | |
| 374 | + | |
| 375 | + | |
343 | 376 | | |
344 | | - | |
| 377 | + | |
345 | 378 | | |
346 | 379 | | |
347 | 380 | | |
348 | | - | |
349 | | - | |
| 381 | + | |
| 382 | + | |
350 | 383 | | |
351 | | - | |
| 384 | + | |
352 | 385 | | |
353 | 386 | | |
354 | 387 | | |
355 | 388 | | |
356 | 389 | | |
357 | 390 | | |
358 | | - | |
| 391 | + | |
359 | 392 | | |
360 | 393 | | |
361 | 394 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
91 | 92 | | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
95 | | - | |
| 96 | + | |
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| |||
118 | 119 | | |
119 | 120 | | |
120 | 121 | | |
121 | | - | |
| 122 | + | |
122 | 123 | | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
129 | | - | |
130 | | - | |
| 130 | + | |
| 131 | + | |
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
| |||
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
153 | | - | |
| 154 | + | |
154 | 155 | | |
155 | 156 | | |
156 | 157 | | |
| |||
182 | 183 | | |
183 | 184 | | |
184 | 185 | | |
185 | | - | |
| 186 | + | |
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
| |||
287 | 288 | | |
288 | 289 | | |
289 | 290 | | |
290 | | - | |
| 291 | + | |
291 | 292 | | |
292 | 293 | | |
293 | 294 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | | - | |
| 20 | + | |
18 | 21 | | |
19 | 22 | | |
20 | | - | |
21 | | - | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
| 45 | + | |
45 | 46 | | |
46 | | - | |
| 47 | + | |
| 48 | + | |
47 | 49 | | |
48 | 50 | | |
49 | 51 | | |
| |||
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
55 | | - | |
| 57 | + | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
| |||
0 commit comments