Skip to content

Commit 0563b84

Browse files
committed
feat(diff-panel): show total line additions and deletions
1 parent 32843c2 commit 0563b84

3 files changed

Lines changed: 61 additions & 1 deletion

File tree

‎apps/web/src/components/DiffPanel.tsx‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import { useTheme } from "../hooks/useTheme";
3030
import {
3131
buildFileDiffRenderKey,
3232
getDiffCollapseIconClassName,
33+
getDiffLineStat,
3334
getRenderablePatch,
3435
resolveDiffThemeName,
3536
resolveFileDiffPath,
@@ -41,6 +42,7 @@ import { resolveThreadRouteRef } from "../threadRoutes";
4142
import { useClientSettings } from "../hooks/useSettings";
4243
import { formatShortTimestamp } from "../timestampFormat";
4344
import { DiffPanelLoadingState, DiffPanelShell, type DiffPanelMode } from "./DiffPanelShell";
45+
import { DiffStatLabel } from "./chat/DiffStatLabel";
4446
import { AnnotatableCodeView, type AnnotatableCodeViewHandle } from "./diffs/AnnotatableCodeView";
4547
import { Button } from "./ui/button";
4648
import { ToggleGroup, Toggle } from "./ui/toggle-group";
@@ -452,6 +454,7 @@ export default function DiffPanel({
452454
);
453455
const diffFileKeys = useMemo(() => codeViewFiles.map((file) => file.fileKey), [codeViewFiles]);
454456
const allDiffFilesCollapsed = areAllDiffFilesCollapsed(diffFileKeys, collapsedDiffFileKeys);
457+
const diffLineStat = useMemo(() => getDiffLineStat(renderableFiles), [renderableFiles]);
455458

456459
useEffect(() => {
457460
if (!selectedFilePath) return;
@@ -713,6 +716,14 @@ export default function DiffPanel({
713716
)}
714717
</div>
715718
<div className="flex shrink-0 items-center gap-1 [-webkit-app-region:no-drag]">
719+
{codeViewFiles.length > 0 && (
720+
<DiffStatLabel
721+
additions={diffLineStat.additions}
722+
deletions={diffLineStat.deletions}
723+
className="mr-1 text-[11px]"
724+
layout="inline"
725+
/>
726+
)}
716727
{codeViewFiles.length > 0 && (
717728
<Tooltip>
718729
<TooltipTrigger

‎apps/web/src/lib/diffRendering.test.ts‎

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { describe, expect, it } from "vite-plus/test";
2-
import { buildPatchCacheKey, getRenderablePatch } from "./diffRendering";
2+
import { buildPatchCacheKey, getDiffLineStat, getRenderablePatch } from "./diffRendering";
33

44
describe("buildPatchCacheKey", () => {
55
it("returns a stable cache key for identical content", () => {
@@ -82,3 +82,33 @@ describe("getRenderablePatch", () => {
8282
expect(parsed.files[0]?.hunks[0]?.unifiedLineStart).toBe(47);
8383
});
8484
});
85+
86+
describe("getDiffLineStat", () => {
87+
it("totals additions and deletions across every file and hunk", () => {
88+
const patch = [
89+
"diff --git a/example.ts b/example.ts",
90+
"--- a/example.ts",
91+
"+++ b/example.ts",
92+
"@@ -1,2 +1,3 @@",
93+
"-before",
94+
"+after",
95+
"+added",
96+
" context",
97+
"@@ -10,2 +11,1 @@",
98+
"-removed",
99+
" context",
100+
"diff --git a/README.md b/README.md",
101+
"--- a/README.md",
102+
"+++ b/README.md",
103+
"@@ -1 +1,2 @@",
104+
" title",
105+
"+description",
106+
].join("\n");
107+
108+
const parsed = getRenderablePatch(patch);
109+
expect(parsed?.kind).toBe("files");
110+
if (parsed?.kind !== "files") return;
111+
112+
expect(getDiffLineStat(parsed.files)).toEqual({ additions: 3, deletions: 2 });
113+
});
114+
});

‎apps/web/src/lib/diffRendering.ts‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,25 @@ export type RenderablePatch =
5252
reason: string;
5353
};
5454

55+
export interface DiffLineStat {
56+
additions: number;
57+
deletions: number;
58+
}
59+
60+
export function getDiffLineStat(files: ReadonlyArray<FileDiffMetadata>): DiffLineStat {
61+
return files.reduce<DiffLineStat>(
62+
(total, file) => {
63+
for (const hunk of file.hunks) {
64+
total.additions += hunk.additionLines;
65+
total.deletions += hunk.deletionLines;
66+
}
67+
68+
return total;
69+
},
70+
{ additions: 0, deletions: 0 },
71+
);
72+
}
73+
5574
interface RenderablePatchOptions {
5675
/**
5776
* Pierre's partial-patch parser keeps hunk render starts in source-file

0 commit comments

Comments
 (0)