Skip to content

Commit 04f4a55

Browse files
committed
fix(web): align pull request state glyph to top of row
- Wrap PullRequestStateGlyph in a self-start span so the icon pins to the top when PR titles wrap - Change ml-4 to pl-4 in PullRequestDetailPanel header to use padding instead of margin
1 parent d4d5d12 commit 04f4a55

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1542,7 +1542,7 @@ export function PullRequestDetailPanel({
15421542
!detail && !onClose && "hidden",
15431543
)}
15441544
>
1545-
<div className="ml-4 grid h-7 min-w-0 items-center overflow-hidden">
1545+
<div className="pl-4 grid h-7 min-w-0 items-center overflow-hidden">
15461546
<div
15471547
aria-hidden={condensed}
15481548
inert={condensed}

‎apps/web/src/components/pullRequest/PullRequestRow.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ function PullRequestRowImpl({
116116
{/* The conflict warning rides the corner of the lifecycle glyph, over the arrow's
117117
merge circle, so the leading slot stays one icon wide and titles line up whether or
118118
not a row is blocked. The background fill cuts it out of the glyph beneath. */}
119-
<span className="relative inline-flex shrink-0">
119+
<span className="relative inline-flex self-start mt-0.75 shrink-0">
120120
<PullRequestStateGlyph state={entry.state} isDraft={entry.isDraft} />
121121
{/* The wrapper takes the offset, not the icon, so the tooltip trigger inside keeps the
122122
badge's size and anchors the popup to it. */}

0 commit comments

Comments
 (0)