fix nullability

juliusmarminge · juliusmarminge · commit 041acf158a27 · 2026-02-26T21:36:44.000-08:00
diff --git a/apps/server/src/persistence/NodeSqliteClient.test.ts b/apps/server/src/persistence/NodeSqliteClient.test.ts
@@ -4,23 +4,27 @@ import * as SqlClient from "effect/unstable/sql/SqlClient";
 
 import * as SqliteClient from "./NodeSqliteClient.ts";
 
-it.effect("runs prepared queries and returns positional values", () =>
-  Effect.gen(function* () {
-    const sql = yield* SqlClient.SqlClient;
+const layer = it.layer(SqliteClient.layerMemory());
 
-    yield* sql`CREATE TABLE entries(id INTEGER PRIMARY KEY, name TEXT NOT NULL)`;
-    yield* sql`INSERT INTO entries(name) VALUES (${"alpha"}), (${"beta"})`;
+layer("NodeSqliteClient", (it) => {
+  it.effect("runs prepared queries and returns positional values", () =>
+    Effect.gen(function* () {
+      const sql = yield* SqlClient.SqlClient;
 
-    const rows = yield* sql<{ readonly id: number; readonly name: string }>`
+      yield* sql`CREATE TABLE entries(id INTEGER PRIMARY KEY, name TEXT NOT NULL)`;
+      yield* sql`INSERT INTO entries(name) VALUES (${"alpha"}), (${"beta"})`;
+
+      const rows = yield* sql<{ readonly id: number; readonly name: string }>`
       SELECT id, name FROM entries ORDER BY id
     `;
-    assert.equal(rows.length, 2);
-    assert.equal(rows[0]?.name, "alpha");
-    assert.equal(rows[1]?.name, "beta");
+      assert.equal(rows.length, 2);
+      assert.equal(rows[0]?.name, "alpha");
+      assert.equal(rows[1]?.name, "beta");
 
-    const values = yield* sql`SELECT id, name FROM entries ORDER BY id`.values;
-    assert.equal(values.length, 2);
-    assert.equal(values[0]?.[1], "alpha");
-    assert.equal(values[1]?.[1], "beta");
-  }).pipe(Effect.provide(SqliteClient.layerMemory())),
-);
+      const values = yield* sql`SELECT id, name FROM entries ORDER BY id`.values;
+      assert.equal(values.length, 2);
+      assert.equal(values[0]?.[1], "alpha");
+      assert.equal(values[1]?.[1], "beta");
+    }),
+  );
+});
diff --git a/packages/contracts/src/orchestration.ts b/packages/contracts/src/orchestration.ts
@@ -142,8 +142,8 @@ export const OrchestrationSession = Schema.Struct({
   providerName: Schema.NullOr(TrimmedNonEmptyString),
   providerSessionId: Schema.NullOr(ProviderSessionId),
   providerThreadId: Schema.NullOr(ProviderThreadId),
-  approvalPolicy: ProviderApprovalPolicy,
-  sandboxMode: ProviderSandboxMode,
+  approvalPolicy: ProviderApprovalPolicy.pipe(Schema.withDecodingDefault(() => "on-failure")),
+  sandboxMode: ProviderSandboxMode.pipe(Schema.withDecodingDefault(() => "workspace-write")),
   activeTurnId: Schema.NullOr(TurnId),
   lastError: Schema.NullOr(TrimmedNonEmptyString),
   updatedAt: IsoDateTime,
@@ -500,8 +500,8 @@ export const ThreadTurnStartRequestedPayload = Schema.Struct({
   model: Schema.optional(TrimmedNonEmptyString),
   effort: Schema.optional(TrimmedNonEmptyString),
   assistantDeliveryMode: Schema.optional(AssistantDeliveryMode),
-  approvalPolicy: ProviderApprovalPolicy,
-  sandboxMode: ProviderSandboxMode,
+  approvalPolicy: ProviderApprovalPolicy.pipe(Schema.withDecodingDefault(() => "on-failure")),
+  sandboxMode: ProviderSandboxMode.pipe(Schema.withDecodingDefault(() => "workspace-write")),
   createdAt: IsoDateTime,
 });
 
