Skip to content

Commit 033dc6e

Browse files
maria-rckssaphid
andcommitted
fix(pi): publish approval cards before actionable requests
Co-authored-by: Alex Southwell <[email protected]>
1 parent 7eb9949 commit 033dc6e

2 files changed

Lines changed: 27 additions & 5 deletions

File tree

‎packages/provider-pi/src/server/adapter.test.ts‎

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3649,9 +3649,31 @@ describe("PiAdapterV2", () => {
36493649
title: "Run project extensions?",
36503650
message: "This project has .pi/extensions.",
36513651
});
3652-
const pending = yield* takeEvent(
3653-
(event) =>
3654-
event.type === "runtime_request.updated" && event.runtimeRequest.status === "pending",
3652+
const artifacts: ProviderAdapter.ProviderAdapterV2Event[] = [];
3653+
const pending = yield* takeEvent((event) => {
3654+
artifacts.push(event);
3655+
return (
3656+
event.type === "runtime_request.updated" && event.runtimeRequest.status === "pending"
3657+
);
3658+
});
3659+
if (pending.type !== "runtime_request.updated") return;
3660+
assert.isTrue(
3661+
artifacts.some(
3662+
(event) =>
3663+
event.type === "node.updated" &&
3664+
event.node.id === pending.runtimeRequest.nodeId &&
3665+
event.node.status === "waiting",
3666+
),
3667+
"the node must exist before an immediately answerable request",
3668+
);
3669+
assert.isTrue(
3670+
artifacts.some(
3671+
(event) =>
3672+
event.type === "turn_item.updated" &&
3673+
event.turnItem.nodeId === pending.runtimeRequest.nodeId &&
3674+
event.turnItem.status === "waiting",
3675+
),
3676+
"the card must exist before an immediately answerable request",
36553677
);
36563678
const requestId =
36573679
pending.type === "runtime_request.updated" ? pending.runtimeRequest.id : undefined;

‎packages/provider-pi/src/server/adapter.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1576,14 +1576,14 @@ export const makePiAdapterV2 = Effect.fn("makePiAdapterV2")(function* (
15761576
turnItem,
15771577
};
15781578
pendingPrompts.set(String(requestId), pending);
1579+
yield* emit({ type: "node.updated", driver: PI_PROVIDER, node });
1580+
yield* emit({ type: "turn_item.updated", driver: PI_PROVIDER, turnItem });
15791581
yield* emit({
15801582
type: "runtime_request.updated",
15811583
driver: PI_PROVIDER,
15821584
threadId,
15831585
runtimeRequest,
15841586
});
1585-
yield* emit({ type: "node.updated", driver: PI_PROVIDER, node });
1586-
yield* emit({ type: "turn_item.updated", driver: PI_PROVIDER, turnItem });
15871587
if (expiresAt !== null) {
15881588
const now = yield* DateTime.now;
15891589
pending.expirationFiber = yield* Effect.sleep(

0 commit comments

Comments
 (0)