Skip to content

Commit 02f242a

Browse files
committed
fix(mobile): contrast pending-question links against card surfaces
Reuse themeColorWithContrast, themeColorWithAlpha, and flattenThemeColor for the question card, unselected input, and selected answer tint. Keep the adjustment local to pending questions and retain the existing theme hue. This is a color-contrast boundary invariant rather than a type invariant. Focused palette tests reproduce failures with screen-preview link colors and verify at least 4.5:1 for every built-in theme in both appearances after the existing contrast adjustment. A new native visual dark-theme pass was not run.
1 parent 2a2ccff commit 02f242a

2 files changed

Lines changed: 38 additions & 1 deletion

File tree

‎apps/mobile/src/features/threads/PendingUserInputCard.tsx‎

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ import { useMarkdownImageSource } from "../../native/useMarkdownImageSource";
55
import { useMarkdownPreviewStyles } from "../files/FileMarkdownPreview";
66
import { useScaledTextRole } from "../settings/appearance/useScaledTextRole";
77
import { useUniwindTheme } from "../../lib/useUniwindTheme";
8+
import {
9+
flattenThemeColor,
10+
themeColorWithAlpha,
11+
themeColorWithContrast,
12+
} from "../../lib/mobileTheme";
813
import { useThreadMarkdownLinkPress } from "./useThreadMarkdownLinkPress";
914
import { FilePreviewModal, type FilePreviewSource } from "../../components/FilePreviewModal";
1015
import { VideoPreviewModal, type VideoPreviewSource } from "../../components/VideoPreviewModal";
@@ -113,7 +118,17 @@ export function PendingUserInputCard(props: PendingUserInputCardProps) {
113118
const questionTextRole = useScaledTextRole("body");
114119
const optionTextRole = useScaledTextRole("footnote");
115120
const textStyles = useMemo(() => {
116-
const base = styles.nativeTextStyle;
121+
const base = {
122+
...styles.nativeTextStyle,
123+
linkColor: themeColorWithContrast(styles.nativeTextStyle.linkColor, [
124+
theme["--color-card-alt"],
125+
theme["--color-input"],
126+
flattenThemeColor(
127+
themeColorWithAlpha(theme["--color-primary"], 0.1),
128+
theme["--color-card-alt"],
129+
),
130+
]),
131+
};
117132
return {
118133
question: { ...base, ...questionTextRole, color: theme["--color-foreground"] },
119134
label: {

‎apps/mobile/src/lib/mobileTheme.test.ts‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
normalizeMobileThemeMode,
2727
resolveMobileThemeIds,
2828
themeColorWithAlpha,
29+
themeColorWithContrast,
2930
themeColorToNativeColor,
3031
} from "./mobileTheme";
3132

@@ -61,6 +62,27 @@ function compositeOver(overlay: string, background: string): string {
6162
}
6263

6364
describe("mobile themes", () => {
65+
it.each(MOBILE_THEME_IDS)("keeps pending-question links readable in %s", (themeId) => {
66+
for (const appearance of ["light", "dark"] as const) {
67+
const variables = getMobileThemeRuntimeVariables(themeId, appearance, "ios");
68+
const surfaces = [
69+
variables["--color-card-alt"],
70+
variables["--color-input"],
71+
flattenThemeColor(
72+
themeColorWithAlpha(variables["--color-primary"], 0.1),
73+
variables["--color-card-alt"],
74+
),
75+
];
76+
const link = themeColorWithContrast(variables["--color-md-link"], surfaces);
77+
for (const surface of surfaces) {
78+
expect(
79+
contrastRatio(link, surface),
80+
`${appearance}: ${link} on ${surface}`,
81+
).toBeGreaterThanOrEqual(4.5);
82+
}
83+
}
84+
});
85+
6486
it("declares every runtime theme variable in the static stylesheet", () => {
6587
const generatedVariables = createMobileThemeVariables(T3_CHAT_THEME.colors, "light");
6688
expect(Object.keys(readDefaultMobileThemeVariables("light")).sort()).toEqual(

0 commit comments

Comments
 (0)