@@ -54,9 +54,17 @@ const make = Effect.gen(function* () {
5454
5555 const save = Effect . fn ( "TaskCache.save" ) ( function * ( name : string , value : string ) {
5656 yield * fs . makeDirectory ( state , { recursive : true , mode : 0o700 } ) ;
57- const file = `${ state } /${ name } .json` ;
58- yield * fs . writeFileString ( file , value + "\n" , { mode : 0o600 } ) ;
59- yield * fs . chmod ( file , 0o600 ) ;
57+ yield * Effect . scoped (
58+ Effect . gen ( function * ( ) {
59+ const directory = yield * fs . makeTempDirectoryScoped ( {
60+ directory : state ,
61+ prefix : ".writer-" ,
62+ } ) ;
63+ const temporary = `${ directory } /${ name } .json` ;
64+ yield * fs . writeFileString ( temporary , value + "\n" , { mode : 0o600 } ) ;
65+ yield * fs . rename ( temporary , `${ state } /${ name } .json` ) ;
66+ } ) ,
67+ ) ;
6068 } ) ;
6169
6270 const updateWriter = Effect . fn ( "TaskCache.updateWriter" ) ( function * (
@@ -67,16 +75,35 @@ const make = Effect.gen(function* () {
6775 if ( ! isWriterName ( name ) ) return yield * new ManagementError ( { message : "Invalid writer name." } ) ;
6876 if ( ! revoke && ! endpoint )
6977 return yield * new ManagementError ( { message : "A deployed cache endpoint is required." } ) ;
70- const exists = yield * fs . exists ( `${ state } /writers.json` ) ;
71- const writers = { ...( exists || revoke ? yield * readWriters ( ) : { } ) } ;
72- const token = hex ( yield * crypto . randomBytes ( 32 ) ) ;
73- if ( revoke ) delete writers [ name ] ;
74- else {
75- writers [ name ] = hex ( yield * crypto . digest ( "SHA-256" , new TextEncoder ( ) . encode ( token ) ) ) ;
76- }
77- yield * save ( "writers" , yield * encodeWriters ( writers ) ) ;
78- if ( ! revoke && endpoint ) yield * save ( name , yield * encodeCredential ( { endpoint, name, token } ) ) ;
79- return revoke ? undefined : `${ state } /${ name } .json` ;
78+ return yield * Effect . scoped (
79+ Effect . gen ( function * ( ) {
80+ yield * fs . makeDirectory ( state , { recursive : true , mode : 0o700 } ) ;
81+ // Exclusive creation coordinates separate management processes as well as fibers.
82+ yield * Effect . acquireRelease (
83+ fs . makeDirectory ( `${ state } /writers.lock` ) . pipe (
84+ Effect . mapError (
85+ ( ) =>
86+ new ManagementError ( {
87+ message :
88+ "Writer registry is locked by another update. Retry after it completes; remove writers.lock only if that process has stopped." ,
89+ } ) ,
90+ ) ,
91+ ) ,
92+ ( ) => fs . remove ( `${ state } /writers.lock` , { recursive : true } ) . pipe ( Effect . orDie ) ,
93+ ) ;
94+ const exists = yield * fs . exists ( `${ state } /writers.json` ) ;
95+ const writers = { ...( exists || revoke ? yield * readWriters ( ) : { } ) } ;
96+ const token = hex ( yield * crypto . randomBytes ( 32 ) ) ;
97+ if ( revoke ) delete writers [ name ] ;
98+ else {
99+ writers [ name ] = hex ( yield * crypto . digest ( "SHA-256" , new TextEncoder ( ) . encode ( token ) ) ) ;
100+ }
101+ yield * save ( "writers" , yield * encodeWriters ( writers ) ) ;
102+ if ( ! revoke && endpoint )
103+ yield * save ( name , yield * encodeCredential ( { endpoint, name, token } ) ) ;
104+ return revoke ? undefined : `${ state } /${ name } .json` ;
105+ } ) ,
106+ ) ;
80107 } ) ;
81108 return WriterRegistry . of ( { read : readWriters , update : updateWriter } ) ;
82109} ) ;
0 commit comments