Repository navigation
feat(ios): split hosts take a portrait split behavior and display mode (t3.44) - #6
Merged
Merged
Conversation
A split that floats its sidebar in portrait used to learn about a rotation only after JS saw the new size, so the sidebar changed in a second animation after the rotation. The host now picks the portrait or default configuration in viewWillTransitionToSize, so the column change animates with the rotation. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A split that floats its sidebar in portrait (T3 Code on the unfolded iPhone Duo) only learned about a rotation after JS saw the new size. UIKit rotated with the landscape configuration, then JS switched to the overlay and the sidebar slid out in a second animation.
Change
Split.HosttakesportraitPreferredSplitBehaviorandportraitPreferredDisplayMode. While the split is taller than it is wide, they overridepreferredSplitBehaviorandpreferredDisplayMode;automatic(the default) keeps the base value.RNSSplitHostControllerapplies the configuration for the incoming size inviewWillTransitionToSize:before calling super, so UIKit lays the columns out for the new size inside the rotation animation. Regular prop updates pick the value for the current bounds.Released as
5.0.0-t3.44(tagt3-v5.0.0-t3.44, brancht3/release-t3.44).Claude Opus 5.5 in Claude Code, running in T3 Code.
🤖 Generated with Claude Code
Note
Add portrait-specific split behavior and display mode to iOS
SplitHostpreferredSplitBehaviorandpreferredDisplayMode(portrait variants) that apply only when the SplitHost is taller than it is wide; both default toautomatic, which falls back to the general preferences.RNSSplitHostController.viewWillTransitionToSizenow applies the destination size's split behavior and display mode before UIKit lays out the transition.updateAppearanceIfNeededandupdateSplitViewDisplayModeForuse size-dependent selectors, so existing SplitHosts may see different behavior/display mode in portrait if portrait values were previously unconfigured.Macroscope summarized 110d8cd.