Repository navigation
fix(core): flank strikethrough tildes like asterisk emphasis, matching GitHub - #11
Conversation
…g GitHub Carries software-mansion-labs/md4c fix/strikethrough-flanking. md4c's tilde opener and closer checks each looked at only one side of the run, so `~$0.48 vs ~$0.65` and `~/foo and ~/bar` struck through on mobile while web (remark-gfm) and GitHub leave them plain, and intraword `a~~b~~c` did not strike. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
Thanks! Landed on |
🤖 Generated with Claude Opus 5.5
Carries software-mansion-labs/md4c#6 in
packages/core/cpp/enrmrkd/enrmrkd.c, so T3 Code mobile strikes the same tildes web and GitHub do.~$0.48 vs ~$0.65 per runandfiles in ~/foo and ~/barstop striking, anda~~b~~cstarts. The md4c PR has the full comparison and tests;packages/coretests pass here.Not included: the web wasm bundle (
src/web/wasm/md4c.js) still needs an Emscripten rebuild. T3 Code doesn't use it, so I left it for your next bundle rebuild rather than commit a binary built on my machine.Follows up pingdotgg/t3code#18156, which will become the tarball bump.
Note
Fix strikethrough flanking to match asterisk emphasis, like GitHub
Changes the inline-mark collector in enrmrkd.c so strikethrough runs of one or two tildes get opener and closer flags like
*emphasis. Each side of the run gets a level of 0, 1, or 2 based on whitespace, punctuation, or other characters. A run is a potential closer when the left level is positive and at least the right level, and a potential opener when the right level is positive and at least the left level.Macroscope summarized d46f457.