Repository navigation
*: move most of the packages to 'pkg' - #47123
Merged
Merged
Conversation
Member
Author
|
I used the following scripts to update all '.go' files: |
1 of 13 tasks
bb7133
force-pushed
the
bb7133/pkg
branch
8 times, most recently
from
October 10, 2023 14:59
bfe4b2c to
48be5a1
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47123 +/- ##
================================================
+ Coverage 71.7785% 72.9145% +1.1359%
================================================
Files 1353 1418 +65
Lines 401276 410541 +9265
================================================
+ Hits 288030 299344 +11314
+ Misses 93707 92369 -1338
+ Partials 19539 18828 -711
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bb7133
force-pushed
the
bb7133/pkg
branch
2 times, most recently
from
October 10, 2023 15:24
0e9b4f5 to
1ed882a
Compare
Contributor
Could you also add a shell script attachment in this comment? |
Contributor
|
/priority p0 |
chrysan
approved these changes
Oct 13, 2023
chrysan
approved these changes
Oct 13, 2023
|
@chrysan: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
|
/approve just refresh the OWNERS links |
zanmato1984
approved these changes
Oct 13, 2023
2 of 19 tasks
This was referenced Oct 16, 2023
This was referenced Oct 17, 2023
2 of 13 tasks
This was referenced Oct 17, 2023
Merged
Merged
1 of 13 tasks
1 of 13 tasks
This was referenced Nov 3, 2023
budney
pushed a commit
to budney/tidb
that referenced
this pull request
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #41241
Problem Summary:
What is changed and how it works?
As mentioned in #41241, this PR will move most of first-level packages to a new 'pkg' directory. However,
dumplingandbrare not moved since further discussions are needed.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.