Repository navigation
docs: re-anchor execution documentation and fixture evidence - #821
Conversation
Update the CMake registration anchor to the actual final train token location; preserve the evidence row, predicate and reason.
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
Code graph out of date: Health delta baseline: last indexed commit f5e929d, 53 commit(s) behind this PR's base. Impact and hotspot numbers below may be wrong.
No verdict: the code graph is out of date. Static checks found no blocking issues, but they compared against an outdated graph. The next push after the repository re-indexes gets a full review.
Not checked: tests were not run; no formal proof of the changed code.
Graphify review — findings
Refreshes the file:line anchors in ADR 0001 (resolve_execution_terms, validate_precommit, margin_check_allowed, has_trail_request and others) so they point at the current positions in pine_adapter.cpp, pine_adapter.hpp and pine_strategy_host.cpp, with no change to the ADR's rulings. Also touches the surrounding docs set: the native-feature-parity design, the arena-bound and consumed-partial-exit-fold designs, the native-engine and pine-to-native pages, the memory-management page, and the native refactor progress log. The diff was truncated before those edits, so their content isn't covered here.
Review partial — this diff was larger than one review pass covers, so later files were not reviewed; some findings may be missing.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 223 functions depend on the 223 functions this change touches.
Health — grade A; no new coupling hotspots.
Verification — 223 functions in the blast radius were not formally verified this run (proofs are advisory here).
Health delta baseline: last indexed commit f5e929d, 53 commit(s) behind this PR's base.
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 223 function(s) in the blast radius were not formally verified this run
Test selection
Test selection
1420 of 1420 test file(s) selected (100%) via static blast radius.
Escalated to a full run for safety (
noncode-change,uncovered-code) — the selection is not trustworthy on its own (see below). CI should run the whole suite.
benchmarks/tests/test_aggregate.py— full-run-safetybenchmarks/tests/test_check_provenance.py— full-run-safetybenchmarks/tests/test_compare.py— full-run-safetybenchmarks/tests/test_public_names.py— full-run-safetybenchmarks/tests/test_run_all.py— full-run-safetybenchmarks/tests/test_run_strategy_feeds.py— full-run-safetydocker/pineforge_sink_finalize_test.py— full-run-safetydocker/pineforge_sink_replay_rq_test.py— full-run-safetydocker/pineforge_sink_replay_test.py— full-run-safetydocker/pineforge_sink_to_json_test.py— full-run-safetydocker/quota_columns_test.py— full-run-safetydocker/quota_convert_test.py— full-run-safetydocker/quota_finalize_test.py— full-run-safetydocker/replay_rq_engine_test.py— full-run-safetydocker/run_json_artifact_window_test.py— full-run-safetydocker/run_json_bin_test.py— full-run-safetydocker/run_json_bounded_transport_test.py— full-run-safetydocker/run_json_bulk_equity_fuzz_test.py— full-run-safetydocker/run_json_bulk_equity_test.py— full-run-safetydocker/run_json_codes_test.py— full-run-safetydocker/run_json_converter_metadata_test.py— full-run-safetydocker/run_json_converter_session_test.py— full-run-safetydocker/run_json_diagnostics_test.py— full-run-safetydocker/run_json_equity_scan_test.py— full-run-safetydocker/run_json_fused_test.py— full-run-safetydocker/run_json_harnesses_test.py— full-run-safetydocker/run_json_metrics_only_test.py— full-run-safetydocker/run_json_misc2_test.py— full-run-safetydocker/run_json_misc_test.py— full-run-safetydocker/run_json_pfbar_test.py— full-run-safetydocker/run_json_provenance_test.py— full-run-safetydocker/run_json_quota_supervisor_test.py— full-run-safetydocker/run_json_replay_test.py— full-run-safetydocker/run_json_selected_sink_test.py— full-run-safetydocker/run_json_sink_lexical_test.py— full-run-safetydocker/run_json_sink_summary_test.py— full-run-safetydocker/run_json_sink_test.py— full-run-safetydocker/run_json_sink_vectors_test.py— full-run-safetydocker/run_json_spool_work_test.py— full-run-safetydocker/run_json_stringio_test.py— full-run-safetydocker/run_json_symbol_feeds_test.py— full-run-safetydocker/run_json_syminfo_test.py— full-run-safetydocker/run_json_trade_scan_test.py— full-run-safetydocker/run_json_window_budget_test.py— full-run-safetydocker/run_json_wrapper_work_test.py— full-run-safetyinclude/pineforge/native_run_spec.hpp— full-run-safetyscripts/derive_corpus_feeds_self_test.py— full-run-safetyscripts/fingerprint_self_test.py— full-run-safetyscripts/run_corpus_self_test.py— full-run-safetyscripts/test_abi_receipt_skips.py— full-run-safety- … and 1370 more
non-code file(s) changed (
docs/adr/0001-kernel-adapter-boundary.md,docs/design/arena-bound.md,docs/design/consumed-partial-exit-fold.md,docs/design/cr150-contracts.md,docs/design/native-feature-parity.md…) → running the full suite for safety (a code graph can't see config/fixture/data deps)
changed code file(s) with no mapped test (
docs/adr/0001-kernel-adapter-boundary.md,docs/design/arena-bound.md,docs/design/consumed-partial-exit-fold.md,docs/design/cr150-contracts.md,docs/design/native-feature-parity.md…) — a coverage gap or a missing link — running the full suite rather than only the selected tests
Selection is safe under the controlled-regression assumption; always-run tests + a periodic full run are the backstops. Advisory — it never changes the check verdict.
Rebind documentation citations to the execution changes and update the
max_drawdowndescription for #804's fill-time peak, halt and immediate close. Mark MG10-a and MG10-b as historical measurements on enginef5e929df, before #804, while preserving their values, claim status and grade.Keep the private-fixture evidence update in a separate commit: its registration anchor moves from line 3470 to the actual token at line 3476; the row, predicate and reason are unchanged.
Validation on the exact resulting tree: all 2,345 documentation anchors resolve, documentation lint and the private-fixture checker pass, and 33 existing private-fixture checker tests pass. Source hashes stayed unchanged during those checks. These documentation and evidence edits do not change execution code or ABI pins. The Linux x86_64 layout probe passed on the preceding execution tree with the existing pins.
This member's checks do not establish the final branch's full CI, parity sweep or private-fixture runtime results.
🤖 Generated with Claude Code